From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web10.3099.1583784397205176035 for ; Mon, 09 Mar 2020 13:06:37 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bqNosEq5; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583784396; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Um0AeGEZPYUBUWaraxCQbLugLvURbUTTcLpEDEGPC1w=; b=bqNosEq5REtlgZm2NKAAJ5SScd3ccyrVI+1J4xMGPCB1shZ76yxx5QAZ1M0NsZcHuopfUd apO0aDpIe08GRqtX0zEj8hI6McGsD4/dpZns2d9kZaR/gBJPxfVj1BIKCWaT3DlUWrTlzj jWptvCJLXLdP7WXoVt7ZY8KhS90sVzU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-239-yUQcVGZaMum0xyIglhIWrA-1; Mon, 09 Mar 2020 16:06:30 -0400 X-MC-Unique: yUQcVGZaMum0xyIglhIWrA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D445318C8C01; Mon, 9 Mar 2020 20:06:28 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-76.ams2.redhat.com [10.36.116.76]) by smtp.corp.redhat.com (Postfix) with ESMTP id 170C15C28E; Mon, 9 Mar 2020 20:06:26 +0000 (UTC) Subject: Re: [edk2-devel] EDK II Maintainers - EDK II CI is now active on edk2/master To: "Kinney, Michael D" , "devel@edk2.groups.io" , "sean.brogan@microsoft.com" , Bret Barkelew , "Gao, Liming" Cc: "Leif Lindholm (Nuvia address)" , Andrew Fish References: From: "Laszlo Ersek" Message-ID: Date: Mon, 9 Mar 2020 21:06:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hello again, On 03/08/20 20:53, Kinney, Michael D wrote: > This one is failing PatchCheck with a missing Signed-off-by > https://github.com/tianocore/edk2/pull/430 The lack of signed-off-by is a red herring. Ard's pull request https://github.com/tianocore/edk2/pull/430 consists of four (4) patches, namely from two series (in the order as listed below): * [edk2-devel] [PATCH v4 0/2] ArmPkg/ArmMmuLib: rewrite and improve cache handling with MMU off https://edk2.groups.io/g/devel/message/55635 http://mid.mail-archive.com/20200307083849.8940-1-ard.biesheuvel@linaro.org * [edk2-devel] [PATCH 0/2] ArmPkg/ArmMmuLib AARCH64: final cleanups https://edk2.groups.io/g/devel/message/55638 http://mid.mail-archive.com/20200307091008.14918-1-ard.biesheuvel@linaro.org These 4 commits (and only these 4 commits) are listed correctly in the github.com PR. However, the raw log at: https://dev.azure.com/tianocore/11ea4a10-ac9f-4e5f-8b13-7def1f19d478/_apis/build/builds/4672/logs/7 lists five (5) commits: > 2020-03-08T19:48:43.0862971Z From *** > 2020-03-08T19:48:43.0875497Z * [new branch] master -> master > 2020-03-08T19:48:43.2525842Z Checking git commit: d9402e5f21 > 2020-03-08T19:48:43.2526905Z Merge branch 'master' into aarch64-mmulib > 2020-03-08T19:48:43.2527217Z The commit message format is not valid: > 2020-03-08T19:48:43.2527812Z * Missing Signed-off-by! (Note: this must be added by the code contributor!) > 2020-03-08T19:48:43.2528444Z https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format > 2020-03-08T19:48:43.2528710Z > 2020-03-08T19:48:43.2528942Z Checking git commit: 1ba3cff0dd > 2020-03-08T19:48:43.2529237Z ArmPkg/ArmMmuLib AARCH64: cosmetic fixups > 2020-03-08T19:48:43.2529542Z The commit message format passed all checks. > 2020-03-08T19:48:43.2529828Z The code passed all checks. > 2020-03-08T19:48:43.2529997Z > 2020-03-08T19:48:43.2530209Z Checking git commit: 5883dd0361 > 2020-03-08T19:48:43.2530582Z ArmPkg/ArmMmuLib AARCH64: drop pointless page table memory type check > 2020-03-08T19:48:43.2530951Z The commit message format passed all checks. > 2020-03-08T19:48:43.2531229Z The code passed all checks. > 2020-03-08T19:48:43.2531399Z > 2020-03-08T19:48:43.2531623Z Checking git commit: 553c37e1a3 > 2020-03-08T19:48:43.2531966Z ArmPkg/ArmMmuLib AARCH64: invalidate page tables before populating them > 2020-03-08T19:48:43.2532320Z The commit message format passed all checks. > 2020-03-08T19:48:43.2532773Z The code passed all checks. > 2020-03-08T19:48:43.2532942Z > 2020-03-08T19:48:43.2533149Z Checking git commit: 60c3f85a6e > 2020-03-08T19:48:43.2533450Z ArmPkg/ArmMmuLib AARCH64: rewrite page table code > 2020-03-08T19:48:43.2533775Z The commit message format passed all checks. > 2020-03-08T19:48:43.2534052Z The code passed all checks. Here, the commit with subject "Merge branch 'master' into aarch64-mmulib" seems like a bogus commit; I have no idea where it comes from. Our Mergify configuration forbids any kind of auto-rebasing or actual merging (i.e. creating merge commits, which have multiple parents), so I don't know why PatchCheck.py even had to look at such a commit. The 4 actual patches passed "PatchCheck.py". I'm going to pick up Ard's patches from the list now, afresh (they have all been reviewed by Leif), and submit a brand new PR with them. Thanks Laszlo