From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by mx.groups.io with SMTP id smtpd.web11.565.1599769999760589216 for ; Thu, 10 Sep 2020 13:33:20 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@broadcom.com header.s=google header.b=fe6XvVd1; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: broadcom.com, ip: 209.85.218.48, mailfrom: vladimir.olovyannikov@broadcom.com) Received: by mail-ej1-f48.google.com with SMTP id gr14so10720197ejb.1 for ; Thu, 10 Sep 2020 13:33:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:references:in-reply-to:mime-version:thread-index:date :message-id:subject:to:cc; bh=/S6Hg+ZB84E4b6Od3eKs6/ztSwvHbTYj4a/ouEV3jXc=; b=fe6XvVd1k4EZnc7jaNzrGyEdRXen6zVHhIZjQatVbJ2BSWUZD9TgghKT+CEJ4OY9Mo HpuCf7foZ35ADfYnVOc5425yLhyviGzViimoSjIfJ2RD9h/cTxZSbJuqo3JZ94dzKxQP T58zGS10jniIa3IrElTZMwGPubYQInBo+2oT8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:references:in-reply-to:mime-version :thread-index:date:message-id:subject:to:cc; bh=/S6Hg+ZB84E4b6Od3eKs6/ztSwvHbTYj4a/ouEV3jXc=; b=f+uiQ7S/9S4fiQpWi3z2TI6Zq5xjYGIOodZPhEKbx2wMoWpqsK2GWey15Na1K29DzL V0Tg1taNWaT8p5QiV0Zhzy711zHCv4vCdKNWbimi3J5mjfiEBua/g9FflsCEgHq8mUax ZdilydnFak+I4pFapdF8XwYEZf1uI9pYjU6M5DrrBizoJXDOwbBDzUGntl0ajV0ex1Zj H6SNKn7OVZO6nQ/uV52pDxtwqP3ZhrzaNxf+LzS0AS+nx34Oeyne2ZgUQlTj7bflGj9/ Jzlzh2uFePRMtFVEFUJI9qq02IgqeGGD1Mk7Bpe6Q75n4i7d2JFWgbT8PPVcRgCF1yBJ ex8A== X-Gm-Message-State: AOAM533UBjyZvokuufJzDIGfjjETftxDWAgEwmTggwmPFQjewtoMMuRf 2Jc1hVbFeV4rWlfj1jXdPQ+HBfh1Es9ucpZacAA9jg== X-Google-Smtp-Source: ABdhPJze3qVv7NW2bIJdzEh2EHXKkAIilJQLrlERJCAAo25NuIpPY8aXEv/V0PtV5jNPdLzW8COxGBChIbrto99IJMc= X-Received: by 2002:a17:906:c1c6:: with SMTP id bw6mr9617706ejb.374.1599769997987; Thu, 10 Sep 2020 13:33:17 -0700 (PDT) From: "Vladimir Olovyannikov" References: <20200909184904.11129-1-vladimir.olovyannikov@broadcom.com> In-Reply-To: MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHg3JNJWCcY2YJbD7AEaGyhEZCY1wHe2KTlqT6yS0A= Date: Thu, 10 Sep 2020 13:33:09 -0700 Message-ID: Subject: Re: [PATCH v11 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand To: Laszlo Ersek , devel@edk2.groups.io Cc: Zhichao Gao , Maciej Rabeda , Jiaxin Wu , Siyuan Fu , Ray Ni , Liming Gao , Nd , Samer El-Haj-Mahmoud Content-Type: text/plain; charset="UTF-8" Hi Laszlo, > -----Original Message----- > From: Laszlo Ersek > Sent: Wednesday, September 9, 2020 11:33 PM > To: Vladimir Olovyannikov ; > devel@edk2.groups.io > Cc: Zhichao Gao ; Maciej Rabeda > ; Jiaxin Wu ; Siyuan > Fu ; Ray Ni ; Liming Gao > ; Nd ; Samer El-Haj-Mahmoud > > Subject: Re: [PATCH v11 0/1] ShellPkg/DynamicCommand: add > HttpDynamicCommand > > On 09/09/20 20:49, Vladimir Olovyannikov wrote: > > Signed-off-by: Vladimir Olovyannikov > > > > Cc: Zhichao Gao > > Cc: Maciej Rabeda > > Cc: Jiaxin Wu > > Cc: Siyuan Fu > > Cc: Ray Ni > > Cc: Liming Gao > > Cc: Nd > > Cc: Laszlo Ersek > > Cc: Samer El-Haj-Mahmoud > > > > This patchset introduces an http client utilizing EDK2 HTTP protocol, > > to allow fast image downloading from http/https servers. > > HTTP download speed is usually faster than tftp. > > The client is based on the same approach as tftp dynamic command, and > > uses the same UEFI Shell command line parameters. This makes it easy > > integrating http into existing UEFI Shell scripts. > > Note that to enable HTTP download, feature Pcd > > gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections must be set to > TRUE. > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2860 > > > > PATCH v11 changes: > > Address comments from Laszlo: > > - use TimeBaseLib.h header to get rid of duplicated constants; > > - explicitly return UINT32 in EfiTimeToEpoch(). > > to be clear, I explicitly *disagree* with returning UINT32 from > EfiTimeToEpoch(). > > I'm not "demanding" (or even suggesting) that you update the > EfiTimeToEpoch() implementation in this patch to return UINTN, but I'd > like > to be very clear that, IMO, for EfiTimeToEpoch() to suffer from a year > 2106 > problem on 64-bit systems too, is bad design. So please don't list the > UINT32 > return type as my suggestion -- that's the exact opposite of what I'd > actually > suggest. Sorry, I must have misunderstood. Do you want me to resubmit the patch? I am open to ideas. Thank you, Vladimir > > Zhichao: are you ready to merge this patch? If so, please let me know; > I'll test > it then. > > Thanks > Laszlo > > > > > > > Vladimir Olovyannikov (1): > > ShellPkg/DynamicCommand: add HttpDynamicCommand > > > > ShellPkg/ShellPkg.dec | 1 + > > ShellPkg/ShellPkg.dsc | 5 + > > .../HttpDynamicCommand/HttpApp.inf | 58 + > > .../HttpDynamicCommand/HttpDynamicCommand.inf | 63 + > > .../DynamicCommand/HttpDynamicCommand/Http.h | 91 + > > ShellPkg/Include/Guid/ShellLibHiiGuid.h | 5 + > > .../DynamicCommand/HttpDynamicCommand/Http.c | 1823 > +++++++++++++++++ > > .../HttpDynamicCommand/HttpApp.c | 61 + > > .../HttpDynamicCommand/HttpDynamicCommand.c | 137 ++ > > .../HttpDynamicCommand/Http.uni | 117 ++ > > 10 files changed, 2361 insertions(+) > > create mode 100644 > > ShellPkg/DynamicCommand/HttpDynamicCommand/HttpApp.inf > > create mode 100644 > > > ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand > .inf > > create mode 100644 > ShellPkg/DynamicCommand/HttpDynamicCommand/Http.h > > create mode 100644 > ShellPkg/DynamicCommand/HttpDynamicCommand/Http.c > > create mode 100644 > > ShellPkg/DynamicCommand/HttpDynamicCommand/HttpApp.c > > create mode 100644 > > > ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand > .c > > create mode 100644 > > ShellPkg/DynamicCommand/HttpDynamicCommand/Http.uni > >