From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=93.95.224.70; helo=mail-03.1984.is; envelope-from=alan@softiron.com; receiver=edk2-devel@lists.01.org Received: from mail-03.1984.is (mail-03.1984.is [93.95.224.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C860B203B8CBC for ; Thu, 3 May 2018 05:08:29 -0700 (PDT) Received: from localhost by mail-03.1984.is with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.84_2) (envelope-from ) id 1fED1v-00005F-Gx; Thu, 03 May 2018 12:08:12 +0000 To: Ard Biesheuvel , Alexei Fedorov References: <1525339461-12432-1-git-send-email-alexei.fedorov@arm.com> Cc: "edk2-devel@lists.01.org" , Arvind Chauhan , Daniil Egranov , Thomas Panakamattam Abraham , Leif Lindholm , Matteo Carlini , Stephanie Hughes-Fitt , nd , Evan Lloyd , Sami Mujawar , Jeremy Linton , Laszlo Ersek From: Alan Ott Message-ID: Date: Thu, 3 May 2018 08:07:53 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Subject: Re: [PATCH edk2-platforms v1] Platform/ARM: Add PeiReportStatusCodeLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2018 12:08:31 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 05/03/2018 07:44 AM, Ard Biesheuvel wrote: > (add some potentially interested parties to cc) > > On 3 May 2018 at 11:24, Alexei Fedorov wrote: >> From: Alexei Fedorov >> >> UEFI build fails for ArmVExpress-FVP-AArch64 when using >> "-D ARM_FVP_RUN_NORFLASH" build option, which prevents >> EDK2_SKIP_PEICORE macro from being defined in >> ArmVExpress-FVP-AArch64.dsc: >> >> !ifndef ARM_FVP_RUN_NORFLASH >> DEFINE EDK2_SKIP_PEICORE=1 >> !endif >> >> When EDK2_SKIP_PEICORE macro is not defined, build fails with >> errors 1001: >> Module type [PEI_CORE] is not supported by library instance >> [MdeModulePkg\Library\DxeReportStatusCodeLib\DxeReportStatusCodeLib.inf] >> consumed by [n:\edk2\MdeModulePkg\Core\Pei\PeiMain.inf] >> and >> Module type [PEIM] is not supported by library instance >> [MdeModulePkg\Library\DxeReportStatusCodeLib\DxeReportStatusCodeLib.inf] >> consumed by [n:\edk2\MdeModulePkg\Core\DxeIplPeim\DxeIpl.inf] >> >> This patch fixes the above build errors by adding >> MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf >> in [LibraryClasses.common.PEI_CORE] and [LibraryClasses.common.PEIM] >> sections of ArmVExpress.dsc.inc. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Alexei Fedorov >> Reviewed-by: Evan Lloyd >> --- >> All the changes can be reviewed at: >> https://github.com/AlexeiFedorov/edk2-platforms/tree/237_add_peireportstatuscodelib_v1 >> >> Notes: >> v1: >> - Add PeiReportStatusCodeLib in PEI_CORE and PEIM sections [Alexei] >> >> Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 2 ++ >> 1 file changed, 2 insertions(+) >> > Just for my understanding: is anyone using these status codes on ARM, > and if so, how exactly? Not using status codes on ARM was the assumption here: https://github.com/tianocore/edk2-platforms/commit/a3877da646af4ce50d1b6be65969dd405383a3cf >> diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc >> index de201b0c81d020e1e06ee320cf0f14f186723657..bb899b91c525ee821b9506cca75224f4bc41e3ae 100644 >> --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc >> +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc >> @@ -166,6 +166,7 @@ [LibraryClasses.common.PEI_CORE] >> MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf >> PeiCoreEntryPoint|MdePkg/Library/PeiCoreEntryPoint/PeiCoreEntryPoint.inf >> PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf >> + ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf >> OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf >> PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf >> ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf >> @@ -179,6 +180,7 @@ [LibraryClasses.common.PEIM] >> MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf >> PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf >> PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf >> + ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf >> OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf >> PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf >> PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf >> -- >> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >> >>