From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 395F5223C177B for ; Tue, 20 Feb 2018 08:38:21 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 15C5F40A0971; Tue, 20 Feb 2018 16:44:19 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-24.rdu2.redhat.com [10.10.120.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id 98F3720A846E; Tue, 20 Feb 2018 16:44:17 +0000 (UTC) To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: ruiyu.ni@intel.com, michael.d.kinney@intel.com, liming.gao@intel.com, leif.lindholm@linaro.org, star.zeng@intel.com, afish@apple.com References: <20180220110524.9050-1-ard.biesheuvel@linaro.org> <20180220110524.9050-3-ard.biesheuvel@linaro.org> From: Laszlo Ersek Message-ID: Date: Tue, 20 Feb 2018 17:44:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180220110524.9050-3-ard.biesheuvel@linaro.org> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Tue, 20 Feb 2018 16:44:19 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Tue, 20 Feb 2018 16:44:19 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH 2/3] ArmVirtPkg: switch to DXE runtime version of DebugLib where appropriate X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Feb 2018 16:38:21 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 02/20/18 12:05, Ard Biesheuvel wrote: > Switch all users of ArmVirt.dsc.inc to the new DebugLib implementation > that was created especially for DXE_RUNTIME_DRIVER modules, ensuring > that DEBUG() calls do not touch the UART at runtime. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > ArmVirtPkg/ArmVirt.dsc.inc | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > index 0cb48f08e9bf..cde514958da2 100644 > --- a/ArmVirtPkg/ArmVirt.dsc.inc > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > @@ -231,6 +231,9 @@ [LibraryClasses.common.UEFI_DRIVER] > [LibraryClasses.common.DXE_RUNTIME_DRIVER] > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > +!if $(TARGET) != RELEASE > + DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > +!endif > > !if $(SECURE_BOOT_ENABLE) == TRUE > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > I think all occurrences of the DebugLib --> "MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf" resolution should be audited and possibly patched / extended in the edk2 tree. Otherwise those platforms will be broken by patch #3. But, that can wait for the next iteration. Reviewed-by: Laszlo Ersek Thanks! Laszlo