From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.6376.1657612010943019387 for ; Tue, 12 Jul 2022 00:46:51 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C76F81516; Tue, 12 Jul 2022 00:46:50 -0700 (PDT) Received: from [10.34.100.102] (pierre123.nice.arm.com [10.34.100.102]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9D9AF3F73D; Tue, 12 Jul 2022 00:46:49 -0700 (PDT) Message-ID: Date: Tue, 12 Jul 2022 09:46:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v3 0/3] DynamicTablesPkg: Pcie generation updates To: Jeff Brasen , devel@edk2.groups.io Cc: Sami.Mujawar@arm.com, Alexei.Fedorov@arm.com References: From: "PierreGondois" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello Jeff, Thanks for the answers, for the 3 patches: Reviewed-by: Pierre Gondois Regards, Pierre On 7/8/22 22:59, Jeff Brasen wrote: > > Add fixes/features to dynamic PCIe support > > - Correct issue with translation in generated ACPI tables. > - Allow for more than 16 controllers to be generated. > - Add support library to allow for override of _OSC and slot info. > > Updates: > v3 - Remove segment as UID patch, convert override to library > v2 - Add IsPosDecode logic to translation patch > > > Jeff Brasen (3): > DynamicTablesPkg: AcpiSsdtPcieLibArm: Correct translation value > DynamicTablesPkg: AcpiSsdtPcieLibArm: Support UID > 0xF > DynamicTablesPkg: AcpiSsdtPcieLibArm: Create support library > > .../Include/Library/SsdtPcieSupportLib.h | 73 +++++++ > .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.c | 191 ++--------------- > .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.h | 17 +- > .../Arm/AcpiSsdtPcieLibArm/SsdtPcieLibArm.inf | 2 +- > .../SsdtPcieOscTemplate.asl | 0 > .../SsdtPcieSupportLib/SsdtPcieSupportLib.c | 200 ++++++++++++++++++ > .../SsdtPcieSupportLib/SsdtPcieSupportLib.inf | 30 +++ > .../SsdtPcieSupportLibPrivate.h | 25 +++ > 8 files changed, 349 insertions(+), 189 deletions(-) > create mode 100644 DynamicTablesPkg/Include/Library/SsdtPcieSupportLib.h > rename DynamicTablesPkg/Library/{Acpi/Arm/AcpiSsdtPcieLibArm => Common/SsdtPcieSupportLib}/SsdtPcieOscTemplate.asl (100%) > create mode 100644 DynamicTablesPkg/Library/Common/SsdtPcieSupportLib/SsdtPcieSupportLib.c > create mode 100644 DynamicTablesPkg/Library/Common/SsdtPcieSupportLib/SsdtPcieSupportLib.inf > create mode 100644 DynamicTablesPkg/Library/Common/SsdtPcieSupportLib/SsdtPcieSupportLibPrivate.h >