From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78]) by mx.groups.io with SMTP id smtpd.web09.2128.1615953302567739653 for ; Tue, 16 Mar 2021 20:55:02 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@oracle.com header.s=corp-2020-01-29 header.b=hjrRV/Uw; spf=pass (domain: oracle.com, ip: 141.146.126.78, mailfrom: ankur.a.arora@oracle.com) Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12H3nx2I017883; Wed, 17 Mar 2021 03:54:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=Bp9zfCl52vH8Rp8PV1zLVH5hPxM66pUfpU3z88l7Eqo=; b=hjrRV/UwFx8XK5uhdViTc+FGG2np5nqrfs9xHnXkqCHqNa7fsVehURQA9Bm4JSuUIt45 8VHXbjy4n4/vtJ6oGuazq8X8iGK2pngx174vTZ8XjCcm0CVXFV2YzNhrfm1BlTS7v6dY XCbzLL0Y/stlPlWrC7lMaVFpNEVugFe35WOvdf0ewyPAkIejV1Nr5429Ff/q/O+WonWf Ei+iXQ99I/7Q0DN0bLsyr92dT0Xy8o9psy4EFnitTSiIm5ppb6p4yDlmKxIOvCkigWWn zb6bqXnf4D2Yfk5eZYaMNlsxJBGTuuc2hQjTxVqckCZvL/fJyifm/Mhgq0dmPkd4H2AR MQ== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 378nbmaprq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Mar 2021 03:54:53 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12H3pLLL089053; Wed, 17 Mar 2021 03:54:53 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2175.outbound.protection.outlook.com [104.47.59.175]) by userp3020.oracle.com with ESMTP id 37a4etu2a5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Mar 2021 03:54:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kmLUCI9Gmbaa+tbaSf3k8NcQsiLezfEJ3E/c1cpHcVkeht6YKD3/ZBn9sq26htVf82umceik8PDkdeG/vLyQDlqsGbcVSwcYdpGuU51fDNgOBng34XIqF0ZQsrxYWb5FX4EjvH2KbOKQ+lct5KoC40xZ3RX27KgthAeaY9zhF9F/ps8lhg7QFDnWeMof3/8lak6IN13eefR6W9CEMKV2nzB58jBjYfADdSWn431Pnqsiv4ANcgKLL2l/CGvrwt3JAK1CIDr5Ne4f7MJFa6FnkrYSIF12FynK3hCOlac9t8NBRUmoi6+r2zC5jWQIpPLpiMnPiiF1kUuTqLsLnmqL7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D+PNHGqM3OWCgUve8GxL8ErdIhyxOozYj+7yiUs52kc=; b=EQHzjEFsu357HO1Isw6G1ZQzlleE7U7Ue9mlWy1aVcd8fWhQx+lSTWvo039aIUA//OE3WfZhl1LSbrYwXhBtD0nLlWF06Bq34qYx1Bp74ZpUQ8FX44W7A7lz9JWmu7picOxLjgFE5WwHLLyQdqczyc9hurFwuUmGZzHgyQFPXk2TE/ZaPwCBjjDgUOmpS0nzKz7FKhii6VsCN4Ht2Lncatqfblqmq5QspE1z1AWvK6diSyryNHyENtVw8bc8kRkgptLL/w4chtjEJxAZYPD4WQikLzJDF2pD57GqT8ixwpPIvyk4EbdS5MOLxkhPpuJ9FRCwXXZXuru62dyZSEi54w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D+PNHGqM3OWCgUve8GxL8ErdIhyxOozYj+7yiUs52kc=; b=eOkazqusLO04eAzyqdzg6PUdu8QORmKkhm1NnZ3Xz0PY+cDAKvrD2EUjrdxpFJxMWzonx7dztwb1RTPvx0mlyVfaNw4+DCJdurDp2LyhJlSSkWF5no4OBKoVmNPlkIF6q4LfMgpmS354Q1hXnPGRaX1pyMw34DEMChufryoesnI= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=oracle.com; Received: from SJ0PR10MB4605.namprd10.prod.outlook.com (2603:10b6:a03:2d9::24) by BYAPR10MB3030.namprd10.prod.outlook.com (2603:10b6:a03:92::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Wed, 17 Mar 2021 03:54:50 +0000 Received: from SJ0PR10MB4605.namprd10.prod.outlook.com ([fe80::a021:790:7ce6:6f16]) by SJ0PR10MB4605.namprd10.prod.outlook.com ([fe80::a021:790:7ce6:6f16%6]) with mapi id 15.20.3912.031; Wed, 17 Mar 2021 03:54:50 +0000 Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW1BBVENIXSBNZGVQa2c6IHVzZSBDcHVQYXVzZSgpIGluIENwdURlYWRMb29wKCk=?= To: gaoliming , devel@edk2.groups.io Cc: 'Michael D Kinney' References: <20210316225918.2625938-1-ankur.a.arora@oracle.com> <00a801d71aca$08347310$189d5930$@byosoft.com.cn> From: "Ankur Arora" Message-ID: Date: Tue, 16 Mar 2021 20:54:48 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 In-Reply-To: <00a801d71aca$08347310$189d5930$@byosoft.com.cn> X-Originating-IP: [70.36.60.91] X-ClientProxiedBy: MW4PR04CA0384.namprd04.prod.outlook.com (2603:10b6:303:81::29) To SJ0PR10MB4605.namprd10.prod.outlook.com (2603:10b6:a03:2d9::24) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.108] (70.36.60.91) by MW4PR04CA0384.namprd04.prod.outlook.com (2603:10b6:303:81::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Wed, 17 Mar 2021 03:54:50 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cddeebc7-1a53-442e-304a-08d8e8f86a57 X-MS-TrafficTypeDiagnostic: BYAPR10MB3030: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3383; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ysIZP1KHbEvBczALw+tEZ7IasnWbCvcIlVl3h+jbIQKVd9fYMFIrnyNvZkqWWt4edK+sPA4aTKPVIoOibrfEhT/Vo6Tg/KSEWMla9kmbOxRomWStOOah8mYTGiiPjRMl/8nXFsXX7nxBpbnoHhU55kZupUoRY17oYmVkjCfnyisiid8pN59dwNTda8BsURWaR71iMEjuHmqQiTQXbN5/IhJLSVadUNSPip2UpJmd2hIN5cTrTqaoGOKz6BCKYi4y2we88p8G/qjVeMdtdhCCi/8yMEWY0uJnyRyu768bVeQtrFRNuOLbFLVODzeYvrTZ5OT/m1wno0shCeKkidhDp9u5MXg03sCCJDi6K8lk9U/XKY+p1wYvrQlpF59+mmkgt2CT6NxWza1L+wZSimluM1LHmijCvr3HZmV4aBNWsEC8gc8y4p2NlQRt8Hi1AoBSv3PFuC/efS5g65ATfGEGLwS7UKyFLMfF+yveOROvO0+OnPya1wr0zzTiwZnGXET477DEQ9I4Ogqx7pmi3yJhrJDiKSCY4CSIsNLsIuZWt/7dC+SMj/3w7MfqYUGbfKYIhygOqjUBjVxOkp7LgAEo9U+9kqlYbHbCElw68e96RKhzoHox6F3IHX0XN2gZ0Walw6yhxJaKX8YsUXsVdN3urQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR10MB4605.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(346002)(366004)(396003)(376002)(39860400002)(8936002)(5660300002)(316002)(16576012)(83380400001)(66946007)(6486002)(31686004)(478600001)(2906002)(224303003)(66476007)(4326008)(66556008)(2616005)(36756003)(86362001)(31696002)(53546011)(26005)(16526019)(186003)(956004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?gb2312?B?RFdTWnpGZGVUYmh6RkpQMGNwYXNIK21GNmVtVkY2ZWNTWTI2MlpGODVobDFD?= =?gb2312?B?dnpsVUR5K04wa3V0b1dNSFdFMi9iajZQWjFmaXEwcDl2RzAvUTNCTmNyYUhZ?= =?gb2312?B?TjM5R1F2VUU5Vlo1SXJycWQ1NGUweHZuakNLalFvQW9YRURkRmhobjhaTmp3?= =?gb2312?B?VEtvK21VYXl1dGlQK3NyQkhIUGl2M093R1RiNDRIUjJPWk9WZXlkZm9zci9s?= =?gb2312?B?eWc2QjcrQ3dJNlZNclJTNWpqVjYzTnRLSlZERVRxY1RBdEVuSy83QlZQbGdj?= =?gb2312?B?UnpMdWZjYVZKTVZzTU5VRzFCUm5wWmxaR1ozeWdwOGJqNmpGaS9aaFRtVUZN?= =?gb2312?B?WTV4VVhjTTZTVW1jVWhCYklORnJzcE5QVk5wYVhITlVITW1yeFAyWXlOa0RU?= =?gb2312?B?L29DMW11d1RRUzlqK05tWmdTUElvczlQS2RGc3JYMm5tNmxUZC9VTllBMFUx?= =?gb2312?B?QnZQT0xpRFhWWXF6YUhuVHdxcTNkRzVkZ2l0bmxsYUdxM0RGYXpwc29VMkFm?= =?gb2312?B?TmY4cXcrOUdKVXdrcVpLQUdTd3VPNWJrS3VNMitBb0VWR0VxenRya1NqYlFH?= =?gb2312?B?SGt3SWpReEtnQ2owazJTZUY1TWhhbUNTajhsTzdyYWgvQUh0bmJlQktQZVFD?= =?gb2312?B?MWZTODJQTG02eDk3UEdVYW9HRzM1b3dnUkMwM3NDTVFtMGZjcTVvb3ZIeHFU?= =?gb2312?B?VDVBVHZEY0wwNCtub0ZyVVQrMDA2VmVXRUFKS0thc2pMNjU3ZG1BTnFGYnhl?= =?gb2312?B?aHc2ejcvWDZRWWo5OVpzWjBpR0RUalJOV0R6a2lUcmhQTXdvTnowTGdIWWxo?= =?gb2312?B?eXNtV09OeDFRck5Ya2R4R2FRem5ndG5GU0IvSU1iQ0RsVnBFUWxkVlc2dFh6?= =?gb2312?B?L0dGeFRMT2hTblpuRGk5Wm1VelJDdjdVUHFyT0hVbzMyVXBydE5pS1VLcXFI?= =?gb2312?B?QVR5RWdjU08yVVlxeU5pOG56dzIra1VLMm5Tb0dZMitlSExVRlJMS3lSdzk1?= =?gb2312?B?V0g4NVBSUEtGOUtzSHFUWWNTTlVHVnM0SWlUdWxYTFNvRVg2b2M3eVZqSEl5?= =?gb2312?B?VjByOEdFQ1kzK25nM0FSakFyWlZMaTJqYnkyaVNzRjhBZ2pRYlRZaHN2WW11?= =?gb2312?B?QUNELy9LaGdYRjZFVzZSQ2dZVTdkWXNYREZkclh2UUVoRWE1RDRwWGlHV3M0?= =?gb2312?B?aTlPUnhMTEdRY1RYWjFFUmRqMmpYY29vTE5ySDh5SExkMTc4emoybFRJRjBJ?= =?gb2312?B?aStzbUNLWkduM25oWlRSS3NUK0Q0d2hQd0lzUVBudE14WDFnYjdSVWYvcUlq?= =?gb2312?B?VFUrRDd0dmVSaS94UXZNK0pLaVEyaUhlLzFUTmgvWWpzNHA2SWJ1cVZrYnBN?= =?gb2312?B?aysxL05VUVlmUDBvUG5rWXgxOENFT2Z4TUoySVhtUHdPeS9TSDNGM3FQRmFr?= =?gb2312?B?bngxdHlZVm84aEdUS1luaGYrVjllenU5UnpmMjhVSVM0QVFPNTNJWFQ5YVAz?= =?gb2312?B?VHp3d3JXMTQwT0o5cEluZVBoSW1FUEVPU3A2OFd5SVpuVXhDaXBONTFjN3Bl?= =?gb2312?B?TXFLRm9ncGo3d051YWxJbWxDUVVaL0pTRmNnRXVNajhWMTc2bjNBU1Z6b0NI?= =?gb2312?B?TG1IVVRzMEJsanFFVitseXpneE1OQmtyNlhpNHNpZnlxNEZxKzhNTFNoRmdP?= =?gb2312?B?V1UvdGFyZWZsTFJEcCtPZkxxRFJiNHRyd1k4TmUzb21NSnF2OStnN0pMUG84?= =?gb2312?Q?DWyWStcClhs63b3VC7ROGecS8IgNWV3kPD90rE0?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: cddeebc7-1a53-442e-304a-08d8e8f86a57 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4605.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2021 03:54:50.7602 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +4PZkyzYJ7q8pd3dyZ2BljHKOcEl5x9grHKwY2RKwb2yT8CF/FqVwQqPpn5P4NUmkw8goneU4/73h5w6FbO6M8N55uu6qz6m4yirC7GGnB0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3030 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9925 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103170027 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9925 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 impostorscore=0 malwarescore=0 adultscore=0 mlxscore=0 clxscore=1015 mlxlogscore=999 lowpriorityscore=0 phishscore=0 priorityscore=1501 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103170027 X-MIME-Autoconverted: from 8bit to quoted-printable by aserp2120.oracle.com id 12H3nx2I017883 Content-Type: text/plain; charset=gbk; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 2021-03-16 6:08 p.m., gaoliming wrote: > Ankur: > Can you give the detail usage for the lower power state when enter i= nto > CpuDeadLoop()? I'm not really familiar with ARM and RiscV, both of which also have imple= mentations for CpuPause(), for the details for X86 variants are below. From Intel's instruction-set reference: "An additional function of the PAUSE instruction is to reduce the power c= onsumed by a processor while executing a spin loop. A processor can execute a spi= n-wait loop extremely quickly, causing the processor to consume a lot of power w= hile it waits for the resource it is spinning on to become available. Inserting a= pause instruction in a spin-wait loop greatly reduces the processor=A1=AFs powe= r consumption." And, from AMD's instruction-set reference: "Improves the performance of spin loops, by providing a hint to the proce= ssor that the current code is in a spin loop. The processor may use this to op= timize power consumption while in the spin loop. Architecturally, this instructi= on behaves like a NOP instruction." Happy to add this to the commit message if you think it'll be useful. Thanks Ankur >=20 > Thanks > Liming >> -----=D3=CA=BC=FE=D4=AD=BC=FE----- >> =B7=A2=BC=FE=C8=CB: Ankur Arora >> =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA3=D4=C217=C8=D5 6:59 >> =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io >> =B3=AD=CB=CD: Ankur Arora ; Liming Gao >> ; Michael D Kinney >> >> =D6=F7=CC=E2: [PATCH] MdePkg: use CpuPause() in CpuDeadLoop() >> >> Use CpuPause() to allow the CPU to go into a lower power state >> state while we spin wait. >> >> Cc: Liming Gao >> Signed-off-by: Ankur Arora >> Reviewed-by: Michael D Kinney >> --- >> MdePkg/Library/BaseLib/CpuDeadLoop.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/MdePkg/Library/BaseLib/CpuDeadLoop.c >> b/MdePkg/Library/BaseLib/CpuDeadLoop.c >> index 9e110cacbc96..3cd304351a65 100644 >> --- a/MdePkg/Library/BaseLib/CpuDeadLoop.c >> +++ b/MdePkg/Library/BaseLib/CpuDeadLoop.c >> @@ -28,5 +28,7 @@ CpuDeadLoop ( >> { >> volatile UINTN Index; >> >> - for (Index =3D 0; Index =3D=3D 0;); >> + for (Index =3D 0; Index =3D=3D 0;) { >> + CpuPause(); >> + } >> } >> -- >> 2.9.3 >=20 >=20 >=20