From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mx.groups.io with SMTP id smtpd.web10.13706.1644002031607567789 for ; Fri, 04 Feb 2022 11:13:51 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=OarkVxgT; spf=pass (domain: nuviainc.com, ip: 209.85.216.41, mailfrom: rebecca@nuviainc.com) Received: by mail-pj1-f41.google.com with SMTP id m7so6521074pjk.0 for ; Fri, 04 Feb 2022 11:13:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to; bh=OzZkTe/cxWeymGeoKzUhXPoX+bd+Bnlb72qhCjBzQik=; b=OarkVxgTczu/QEh+V30F39xgClzTxidKdwSWZsLVG7sk/16sBEBjzkq4AL97sdw/6E 8fNKuJakjBKJ+G8MCWNRlLGK6K5nRhyWLcwP7JpjqGRERj7S5Vx78TsFhoBQmNXN8Lhl vTXmRIsRZI0VO/uZOrUm5ofwg8uj0PolXeYKS67z5Y2Huebtf/tXLgJfq8WVR1EzIGQo o4EXj7463UYi3FhMvenRBapkaM5AqyyD1obYbQNm+cLOrjyiMqqciH4/kLMh9Tk5gX3u nVFssrQUp9oZUGMAwKN4+LH1oEBbPtE1uKX4RBuTo+5zNpSVkT3vnrofmeBptqJimJP0 ugXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to; bh=OzZkTe/cxWeymGeoKzUhXPoX+bd+Bnlb72qhCjBzQik=; b=58FIErBBImk4nTffhSSf6M5ARiPp5AkHG+fG8PAaoVm1pj6csuq2F3VUITNWiQZBXu kKuCE/LkOI1jGyjlSlOnfZOOAFonsk5ozfe3yavghz8WFPOL5C2h3o2WKiZBDy8ZUJ2D r7uf5O0XDQPh5oIcg6AKwDAmTLOpRtxWtjO35+9XCGRNGQHig4kjz30dkDosyABP80er jNwhU5lx95yXBcvFTCb6CzYzeUaOkn9Gc4G5mmBieKQoZXevHmV9wa/HkgPzhk3D3VfJ r/FL4fC4AXjh1Fd4rATfMKheJxV6/Bj6sH2U/RxolQY0FhbSrol3pk8wvICJUoh7G6CK b/7A== X-Gm-Message-State: AOAM531+L0d3KYikVoETzROPzNBhFaH493bBpjZev90Didj+K29pQS7W cB3bPfAIlzxl+h31eS6K6Fmqqg== X-Google-Smtp-Source: ABdhPJx/XEllaewaSRN4oqKd2XVwbsZoEI657AeQLtV+9bULhUVMasILQ14RXFc2UewpylxxPGQUSw== X-Received: by 2002:a17:902:bb83:: with SMTP id m3mr4437346pls.114.1644002031146; Fri, 04 Feb 2022 11:13:51 -0800 (PST) Return-Path: Received: from ?IPV6:2601:681:4300:69e:9e7b:efff:fe2b:884c? ([2601:681:4300:69e:9e7b:efff:fe2b:884c]) by smtp.gmail.com with ESMTPSA id nk11sm2809650pjb.55.2022.02.04.11.13.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Feb 2022 11:13:50 -0800 (PST) Message-ID: Date: Fri, 4 Feb 2022 12:13:48 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3 1/4] ArmPkg: Replace CoreId and ClusterId with Mpidr in ARM_CORE_INFO struct To: Ard Biesheuvel Cc: edk2-devel-groups-io , Ard Biesheuvel , Gerd Hoffmann , Samer El-Haj-Mahmoud , Leif Lindholm , Sami Mujawar References: <20211216034634.15468-1-rebecca@nuviainc.com> <20211216034634.15468-2-rebecca@nuviainc.com> From: Rebecca Cran In-Reply-To: Content-Type: multipart/alternative; boundary="------------vjSu0rKT0n6VIM9KglqcisE0" Content-Language: en-US --------------vjSu0rKT0n6VIM9KglqcisE0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/31/22 04:42, Ard Biesheuvel wrote: > On Mon, 31 Jan 2022 at 00:22, Ard Biesheuvel wrote: >> I've had a stab at refactoring this code. Branch can be found here: >> https://github.com/ardbiesheuvel/edk2/tree/armpkg-mpservicesdxe-refactor >> > OK, I've did some more work on this, and ended up with a branch that > builds and runs correctly on Raspberry Pi 4. Note that it requires > cache maintenance in the test app as well, or the ApFunction() routine > may be sitting in the cache on the BSP, and the AP will branch to who > knows where. Thanks. I'll do some testing on my end and review the changes. I did notice thatDmaLib is missing from ArmPkg/ArmPkg.dsc. -- Rebecca Cran --------------vjSu0rKT0n6VIM9KglqcisE0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

On 1/31/22 04:42, Ard Biesheuvel wrote:

On Mon, 31 Jan 2022 at 00:22, Ard Biesheuvel <ardb@kernel.org> wrote:
I've had a stab at refactoring this code. Branch can be found here:
https://github.com/ardbiesheuvel/edk2/tree/armpkg-mpservicesdxe-refactor

OK, I've did some more work on this, and ended up with a branch that
builds and runs correctly on Raspberry Pi 4. Note that it requires
cache maintenance in the test app as well, or the ApFunction() routine
may be sitting in the cache on the BSP, and the AP will branch to who
knows where.
Thanks. I'll do some testing on my end and review the changes.
I did notice that DmaLib is missing from ArmPkg/ArmPkg.dsc.

-- 
Rebecca Cran
--------------vjSu0rKT0n6VIM9KglqcisE0--