From: "Laszlo Ersek" <lersek@redhat.com>
To: Leif Lindholm <leif@nuviainc.com>,
Michael Kubacki <michael.kubacki@outlook.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ard.biesheuvel@arm.com>
Subject: Re: [PATCH v3 2/7] ArmVirtPkg: Add Platform CI and configuration for Core CI
Date: Tue, 28 Apr 2020 14:47:56 +0200 [thread overview]
Message-ID: <e8b17b7b-e2b4-ee8d-6d81-49424b8d2b3f@redhat.com> (raw)
In-Reply-To: <20200428102329.GC21486@vanye>
On 04/28/20 12:23, Leif Lindholm wrote:
> On Mon, Apr 27, 2020 at 14:21:07 -0700, Michael Kubacki wrote:
>> I believe I misunderstood the conclusion of which Signed-off-by to include
>> in the v1 series discussion - https://edk2.groups.io/g/devel/message/57129.
>>
>> These patches are taken from a branch on Sean's fork of edk2 as noted in the
>> cover letter - https://edk2.groups.io/g/devel/message/58114. Sean has given
>> a Signed-off-by on these patches in that branch.
>>
>> Is the guidance in this case to only include my Signed-off-by?
>
> Yes. You can only attest to your own legal understanding of a given
> situation, not to that of others - so "passing on" attestations given
> by someone else in a different context ends up being misleading.
>
> But this isn't the first time this has been misunderstood - perhaps we
> should add an explicit statement to ReadMe.rst (as it will be after
> this set) that "When importing patches from external sources, existing
> Signed-off-by tags must be stripped out.".
That would be nice. I know I need such a reminder.
Thanks
Laszlo
next prev parent reply other threads:[~2020-04-28 12:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200424213108.19888-1-michael.kubacki@outlook.com>
2020-04-24 21:31 ` [PATCH v3 1/7] .azurepipelines: Add Platform CI template Michael Kubacki
2020-04-24 21:31 ` [PATCH v3 2/7] ArmVirtPkg: Add Platform CI and configuration for Core CI Michael Kubacki
2020-04-27 12:22 ` Leif Lindholm
2020-04-27 21:21 ` Michael Kubacki
2020-04-28 10:23 ` Leif Lindholm
2020-04-28 12:47 ` Laszlo Ersek [this message]
2020-04-24 21:31 ` [PATCH v3 3/7] EmulatorPkg: " Michael Kubacki
2020-04-28 11:22 ` [edk2-devel] " Liming Gao
2020-04-24 21:31 ` [PATCH v3 4/7] OvmfPkg: " Michael Kubacki
2020-04-24 21:31 ` [PATCH v3 5/7] .pytool: Update CI Settings to support Emulator, ArmVirt, and Ovmf packages Michael Kubacki
2020-04-24 21:31 ` [PATCH v3 6/7] .azurepipelines: Update Core CI build matrix to include platforms Michael Kubacki
2020-04-24 21:31 ` [PATCH v3 7/7] ReadMe: Convert to rst and add Platform CI Status Michael Kubacki
2020-04-27 12:30 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8b17b7b-e2b4-ee8d-6d81-49424b8d2b3f@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox