From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web10.6533.1588078084687622512 for ; Tue, 28 Apr 2020 05:48:04 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cSe9hTLX; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588078083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I1SyFuHID0Wk4Nu89UJmWr0BzsxqL++bGwSADSTpJQw=; b=cSe9hTLXz4hec4jhq8NLOSqkuo57vEY8O9wjEbO2cDZMo1OobD4TaUqwitxDLq3s8Xp/p0 OwTgO6xdUwLtd2fkyzjRW/4eX8CcU6NiAU/lJ3xPmyaKovuJz4FmM/7pJIt+qkgICL3IvJ NPjUgK7clut0hrr/B6rtS4CaNdc/r6g= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-379-W-tEi3TbM5-hrJKbTCSC6A-1; Tue, 28 Apr 2020 08:47:59 -0400 X-MC-Unique: W-tEi3TbM5-hrJKbTCSC6A-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1CE9C835B4A; Tue, 28 Apr 2020 12:47:58 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-33.ams2.redhat.com [10.36.113.33]) by smtp.corp.redhat.com (Postfix) with ESMTP id 29A6E1002397; Tue, 28 Apr 2020 12:47:56 +0000 (UTC) Subject: Re: [PATCH v3 2/7] ArmVirtPkg: Add Platform CI and configuration for Core CI To: Leif Lindholm , Michael Kubacki Cc: devel@edk2.groups.io, Ard Biesheuvel References: <20200424213108.19888-1-michael.kubacki@outlook.com> <20200427122252.GQ14075@vanye> <20200428102329.GC21486@vanye> From: "Laszlo Ersek" Message-ID: Date: Tue, 28 Apr 2020 14:47:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200428102329.GC21486@vanye> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 04/28/20 12:23, Leif Lindholm wrote: > On Mon, Apr 27, 2020 at 14:21:07 -0700, Michael Kubacki wrote: >> I believe I misunderstood the conclusion of which Signed-off-by to include >> in the v1 series discussion - https://edk2.groups.io/g/devel/message/57129. >> >> These patches are taken from a branch on Sean's fork of edk2 as noted in the >> cover letter - https://edk2.groups.io/g/devel/message/58114. Sean has given >> a Signed-off-by on these patches in that branch. >> >> Is the guidance in this case to only include my Signed-off-by? > > Yes. You can only attest to your own legal understanding of a given > situation, not to that of others - so "passing on" attestations given > by someone else in a different context ends up being misleading. > > But this isn't the first time this has been misunderstood - perhaps we > should add an explicit statement to ReadMe.rst (as it will be after > this set) that "When importing patches from external sources, existing > Signed-off-by tags must be stripped out.". That would be nice. I know I need such a reminder. Thanks Laszlo