From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 712C921A02918 for ; Fri, 26 May 2017 09:55:51 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DDBF472477; Fri, 26 May 2017 16:55:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com DDBF472477 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=lersek@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com DDBF472477 Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-105.phx2.redhat.com [10.3.116.105]) by smtp.corp.redhat.com (Postfix) with ESMTP id E73F8179D8; Fri, 26 May 2017 16:55:49 +0000 (UTC) To: "Wei, David" Cc: edk2-devel-01 , "Justen, Jordan L" References: <20170518150427.16435-1-lersek@redhat.com> <20170518150427.16435-9-lersek@redhat.com> <89954A0B46707A448411A627AD4EEE3468F328E4@SHSMSX101.ccr.corp.intel.com> From: Laszlo Ersek Message-ID: Date: Fri, 26 May 2017 18:55:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <89954A0B46707A448411A627AD4EEE3468F328E4@SHSMSX101.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 26 May 2017 16:55:51 +0000 (UTC) Subject: Re: [PATCH 8/8] Vlv2TbltDevicePkg/FvbRuntimeDxe: correct NumOfLba vararg type in EraseBlocks() X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 May 2017 16:55:51 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit David, On 05/19/17 03:49, Wei, David wrote: > Reviewed-by: zwei4 > > > Thanks, > David Wei thanks for committing & pushing this patch on my behalf -- I've been waiting for the rest of the reviews to trickle in. I figured I'd push the DuetPkg, Nt32Pkg, QuarkPlatformPkg and Vlv2TbltDevicePkg patches in one go. The first two of these remain unreviewed (by the package maintainer), which is why I haven't pushed the QuarkPlatformPkg and Vlv2TbltDevicePkg patches either. Thanks, Laszlo > -----Original Message----- > From: Laszlo Ersek [mailto:lersek@redhat.com] > Sent: Thursday, May 18, 2017 11:04 PM > To: edk2-devel-01 > Cc: Wei, David ; Justen, Jordan L ; Guo, Mang > Subject: [PATCH 8/8] Vlv2TbltDevicePkg/FvbRuntimeDxe: correct NumOfLba vararg type in EraseBlocks() > > According to the PI spec, Volume 3, > EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL.EraseBlocks(): > >> The variable argument list is a list of tuples. Each tuple describes a >> range of LBAs to erase and consists of the following: >> * An EFI_LBA that indicates the starting LBA >> * A UINTN that indicates the number of blocks to erase > > (NB, in edk2, EFI_FIRMWARE_VOLUME_BLOCK_PROTOCOL is a typedef to > EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL.) > > In this driver, the NumOfLba local variable is defined with type UINTN, > but the TYPE argument passed to VA_ARG() is UINT32. Fix the mismatch. > > Cc: David Wei > Cc: Jordan Justen > Cc: Mang Guo > Reported-by: Jordan Justen > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek > --- > > Notes: > unbuilt, untested > > Vlv2TbltDevicePkg/FvbRuntimeDxe/FvbService.c | 4 ++-- > Vlv2TbltDevicePkg/FvbRuntimeDxe/FvbSmmDxe.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Vlv2TbltDevicePkg/FvbRuntimeDxe/FvbService.c b/Vlv2TbltDevicePkg/FvbRuntimeDxe/FvbService.c > index b0013f918368..89b941042420 100644 > --- a/Vlv2TbltDevicePkg/FvbRuntimeDxe/FvbService.c > +++ b/Vlv2TbltDevicePkg/FvbRuntimeDxe/FvbService.c > @@ -793,7 +793,7 @@ FvbProtocolEraseBlocks ( > break; > } > > - NumOfLba = VA_ARG (args, UINT32); > + NumOfLba = VA_ARG (args, UINTN); > > // > // Check input parameters. > @@ -817,7 +817,7 @@ FvbProtocolEraseBlocks ( > break; > } > > - NumOfLba = VA_ARG (args, UINT32); > + NumOfLba = VA_ARG (args, UINTN); > > while ( NumOfLba > 0 ) { > Status = FvbEraseBlock (FvbDevice->Instance, StartingLba); > diff --git a/Vlv2TbltDevicePkg/FvbRuntimeDxe/FvbSmmDxe.c b/Vlv2TbltDevicePkg/FvbRuntimeDxe/FvbSmmDxe.c > index 20aaf8720f72..22a4bdcdd492 100644 > --- a/Vlv2TbltDevicePkg/FvbRuntimeDxe/FvbSmmDxe.c > +++ b/Vlv2TbltDevicePkg/FvbRuntimeDxe/FvbSmmDxe.c > @@ -725,7 +725,7 @@ FvbEraseBlocks ( > break; > } > > - NumOfLba = VA_ARG (Marker, UINT32); > + NumOfLba = VA_ARG (Marker, UINTN); > if (NumOfLba == 0) { > return EFI_INVALID_PARAMETER; > } > @@ -742,7 +742,7 @@ FvbEraseBlocks ( > if (StartingLba == EFI_LBA_LIST_TERMINATOR ) { > break; > } > - NumOfLba = VA_ARG (Marker, UINT32); > + NumOfLba = VA_ARG (Marker, UINTN); > Status = EraseBlock (This, StartingLba, NumOfLba); > if (EFI_ERROR (Status)) { > break; >