From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web10.5752.1592041076871627483
 for <devel@edk2.groups.io>;
 Sat, 13 Jun 2020 02:37:57 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A50C41F1;
	Sat, 13 Jun 2020 02:37:55 -0700 (PDT)
Received: from [192.168.1.69] (unknown [172.31.20.19])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EEFCF3F6CF;
	Sat, 13 Jun 2020 02:37:52 -0700 (PDT)
Subject: Re: [edk2-devel] [PATCH v1 0/3] Compile AML bytecode array into OBJ file
To: devel@edk2.groups.io, pierre.gondois@arm.com
Cc: bob.c.feng@intel.com, liming.gao@intel.com, Sami.Mujawar@arm.com,
 Tomas.Pilar@arm.com, nd@arm.com
References: <20200518141120.66132-1-pierre.gondois@arm.com>
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
Message-ID: <e8c7b0d1-cb17-9d5c-6dcb-1f96786a153d@arm.com>
Date: Sat, 13 Jun 2020 11:37:49 +0200
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:68.0) Gecko/20100101
 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <20200518141120.66132-1-pierre.gondois@arm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

On 5/18/20 4:11 PM, PierreGondois via groups.io wrote:
> Following the BZ at https://bugzilla.tianocore.org/show_bug.cgi?id=3D24=
25
> This patch serie is a another way to solve the dependency
> of C files over ASL files. With this new method, the
> dependency is resolved at the linking stage.
>=20
> The last method to solve this dependency was to add
> the possibility to modify INF files to depict such a
> dependency. This method was not accepted. The discussion
> is available at https://edk2.groups.io/g/devel/topic/72655342#56658
>=20
> The last patch modifying the INF specification and INF
> parsing are available at:
> https://edk2.groups.io/g/devel/topic/72655342#56658
> https://edk2.groups.io/g/devel/topic/72656060#56662
>=20
> Pierre Gondois (3):
>    BaseTools: Generate multiple rules when multiple output files
>    BaseTools: Rename AmlToHex script to AmlToC
>    BaseTools: Compile AML bytecode arrays into .obj file
>=20


Hello Pierre,

I have no comments on this series, but I noticed that AmlToHex was=20
checked into the repository with CRLF line endings:

$ file BaseTools/BinWrappers/PosixLike/AmlToHex
Bourne-Again shell script, ASCII text executable, with CRLF line terminat=
ors

resulting in Build output like

Intel ACPI Component Architecture
ASL+ Optimizing Compiler/Disassembler version 20181213
Copyright (c) 2000 - 2018 Intel Corporation

ASL Input:=20
/home/ard/build/edk2-workspace/Build/ArmVirtQemuKernel-ARM/RELEASE_CLANG3=
8/ARM/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe/OUTPUT/./RamDisk.=
iiii=20
- 42 lines, 305 bytes, 6 keywords
AML Output:=20
/home/ard/build/edk2-workspace/Build/ArmVirtQemuKernel-ARM/RELEASE_CLANG3=
8/ARM/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe/OUTPUT/./RamDisk.=
aml=20
- 124 bytes, 5 named objects, 1 executable opcodes

Compilation complete. 0 Errors, 0 Warnings, 0 Remarks, 0 Optimizations
/usr/bin/env: =E2=80=98bash\r=E2=80=99: No such file or directory


Note that this platform has no use for the hex-dumped output of the AML,=20
so it would be better if we only call AmlToHex when necessary.

Thanks,
Ard.