Re: [PATCH 0/4] Add EDKII_UFS_HC_PLATFORM_PROTOCOL to support platform specific programming of UFS host controllers

["Laszlo Ersek" <lersek@redhat.com>]

On 08/08/19 04:37, Wu, Hao A wrote:
> Dear stewards and Liming,
> 
> Sorry for top-posting.
> 
> I plan to add the below new feature which is targeting for the upcoming
> edk2-stable201908 tag:
> 
> * Add EDKII_UFS_HC_PLATFORM_PROTOCOL to support platform specific programming of UFS host controllers
> 
> The BZ tracker for the feature request is at:
> https://bugzilla.tianocore.org/show_bug.cgi?id=1343
> 
> The 1st version of the patch series has been proposed at:
> https://edk2.groups.io/g/devel/message/45022
> And for the series, I think the changes are good in general and I plan to give
> my RB tag with some minor modifications.
> 
> If you have any concern with regard to adding this feature in the upcoming
> stable tag, please help to raise. Thanks in advance.

No concerns on my end.

Thanks
Laszlo

> Best Regards,
> Hao Wu
> 
> 
>> -----Original Message-----
>> From: Albecki, Mateusz
>> Sent: Thursday, August 08, 2019 12:51 AM
>> To: devel@edk2.groups.io
>> Cc: Albecki, Mateusz; Wu, Hao A
>> Subject: [PATCH 0/4] Add EDKII_UFS_HC_PLATFORM_PROTOCOL to support
>> platform specific programming of UFS host controllers
>>
>> To cover additional host controller programming mentioned in the UFS
>> specification
>> we have added an additional protocol that allows the UEFI driver to give
>> control
>> to platform driver. This allows the platform to perform any additional steps
>> needed for the stable operation.
>>
>> Test coverage:
>> Tested on platform with UFS 2.1 host controller with Samsung UFS2.0 part
>> with 3 LUs enabled
>> All LUs have been enumerated in boot manager.
>> Tested that enumeration works without platform protocol installed(on host
>> controller that can support it)
>> Tested that enumeration works with platform protocol installed and with
>> additional programming steps after
>> link startup(power mode change to GEAR2).
>>
>> Cc: Hao A Wu <hao.a.wu@intel.com>
>>
>> Mateusz Albecki (4):
>>   MdeModulePkg: Add definition of the
>> EDKII_UFS_HC_PLATFORM_PROTOCOL
>>   MdeModulePkg/UfsPassThruDxe: Refactor UfsExecUicCommand function
>>   MdeModulePkg/UfsPassThruDxe: Refactor private data to use
>>     EDKII_UFS_HC_INFO
>>   MdeModulePkg/UfsPassThruDxe: Implement
>> EDKII_UFS_HC_PLATFORM_PROTOCOL
>>
>>  MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c  |  25 ++-
>>  MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.h  |  44 +++++-
>>  .../Bus/Ufs/UfsPassThruDxe/UfsPassThruDxe.inf      |   3 +-
>>  .../Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c        | 172
>> ++++++++++++++++-----
>>  .../Include/Protocol/UfsHostControllerPlatform.h   | 124 +++++++++++++++
>>  MdeModulePkg/MdeModulePkg.dec                      |   3 +
>>  6 files changed, 324 insertions(+), 47 deletions(-)
>>  create mode 100644
>> MdeModulePkg/Include/Protocol/UfsHostControllerPlatform.h
>>
>> --
>> 2.14.1.windows.1
>