From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 08 Aug 2019 12:59:59 -0700 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2778F30860DA; Thu, 8 Aug 2019 19:59:59 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-122.ams2.redhat.com [10.36.117.122]) by smtp.corp.redhat.com (Postfix) with ESMTP id 90793608A7; Thu, 8 Aug 2019 19:59:57 +0000 (UTC) Subject: Re: [PATCH 0/4] Add EDKII_UFS_HC_PLATFORM_PROTOCOL to support platform specific programming of UFS host controllers To: "Wu, Hao A" , Andrew Fish , Leif Lindholm , "Kinney, Michael D" , "Gao, Liming" Cc: "Albecki, Mateusz" , "devel@edk2.groups.io" References: <20190807165107.688-1-mateusz.albecki@intel.com> From: "Laszlo Ersek" Message-ID: Date: Thu, 8 Aug 2019 21:59:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Thu, 08 Aug 2019 19:59:59 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/08/19 04:37, Wu, Hao A wrote: > Dear stewards and Liming, > > Sorry for top-posting. > > I plan to add the below new feature which is targeting for the upcoming > edk2-stable201908 tag: > > * Add EDKII_UFS_HC_PLATFORM_PROTOCOL to support platform specific programming of UFS host controllers > > The BZ tracker for the feature request is at: > https://bugzilla.tianocore.org/show_bug.cgi?id=1343 > > The 1st version of the patch series has been proposed at: > https://edk2.groups.io/g/devel/message/45022 > And for the series, I think the changes are good in general and I plan to give > my RB tag with some minor modifications. > > If you have any concern with regard to adding this feature in the upcoming > stable tag, please help to raise. Thanks in advance. No concerns on my end. Thanks Laszlo > Best Regards, > Hao Wu > > >> -----Original Message----- >> From: Albecki, Mateusz >> Sent: Thursday, August 08, 2019 12:51 AM >> To: devel@edk2.groups.io >> Cc: Albecki, Mateusz; Wu, Hao A >> Subject: [PATCH 0/4] Add EDKII_UFS_HC_PLATFORM_PROTOCOL to support >> platform specific programming of UFS host controllers >> >> To cover additional host controller programming mentioned in the UFS >> specification >> we have added an additional protocol that allows the UEFI driver to give >> control >> to platform driver. This allows the platform to perform any additional steps >> needed for the stable operation. >> >> Test coverage: >> Tested on platform with UFS 2.1 host controller with Samsung UFS2.0 part >> with 3 LUs enabled >> All LUs have been enumerated in boot manager. >> Tested that enumeration works without platform protocol installed(on host >> controller that can support it) >> Tested that enumeration works with platform protocol installed and with >> additional programming steps after >> link startup(power mode change to GEAR2). >> >> Cc: Hao A Wu >> >> Mateusz Albecki (4): >> MdeModulePkg: Add definition of the >> EDKII_UFS_HC_PLATFORM_PROTOCOL >> MdeModulePkg/UfsPassThruDxe: Refactor UfsExecUicCommand function >> MdeModulePkg/UfsPassThruDxe: Refactor private data to use >> EDKII_UFS_HC_INFO >> MdeModulePkg/UfsPassThruDxe: Implement >> EDKII_UFS_HC_PLATFORM_PROTOCOL >> >> MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c | 25 ++- >> MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.h | 44 +++++- >> .../Bus/Ufs/UfsPassThruDxe/UfsPassThruDxe.inf | 3 +- >> .../Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c | 172 >> ++++++++++++++++----- >> .../Include/Protocol/UfsHostControllerPlatform.h | 124 +++++++++++++++ >> MdeModulePkg/MdeModulePkg.dec | 3 + >> 6 files changed, 324 insertions(+), 47 deletions(-) >> create mode 100644 >> MdeModulePkg/Include/Protocol/UfsHostControllerPlatform.h >> >> -- >> 2.14.1.windows.1 >