From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4DE972063D741 for ; Tue, 22 May 2018 11:58:30 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 80DD84071181; Tue, 22 May 2018 18:58:29 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-18.rdu2.redhat.com [10.10.120.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1250E1002951; Tue, 22 May 2018 18:58:27 +0000 (UTC) To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: Leif Lindholm , Michael D Kinney , Liming Gao , Star Zeng , Eric Dong , Dandan Bi References: <20180522140850.30369-1-ard.biesheuvel@linaro.org> <20180522140850.30369-2-ard.biesheuvel@linaro.org> From: Laszlo Ersek Message-ID: Date: Tue, 22 May 2018 20:58:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180522140850.30369-2-ard.biesheuvel@linaro.org> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Tue, 22 May 2018 18:58:29 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Tue, 22 May 2018 18:58:29 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH 1/6] OvmfPkg/PlatformBootManagerLib: add missing report status code call X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2018 18:58:30 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05/22/18 16:08, Ard Biesheuvel wrote: > Consumers of status code reports may rely on a status code to be > reported when the ReadyToBoot event is signalled. For instance, > FirmwarePerformanceDxe will fail to install the FPDT ACPI table > in this case. So add the missing call. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 + > OvmfPkg/Library/PlatformBootManagerLib/QemuKernel.c | 4 ++++ > 2 files changed, 5 insertions(+) > > diff --git a/OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf b/OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > index 27789b7377bc..f10b68424b91 100644 > --- a/OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > +++ b/OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > @@ -55,6 +55,7 @@ [LibraryClasses] > QemuFwCfgS3Lib > LoadLinuxLib > QemuBootOrderLib > + ReportStatusCodeLib > UefiLib > > [Pcd] > diff --git a/OvmfPkg/Library/PlatformBootManagerLib/QemuKernel.c b/OvmfPkg/Library/PlatformBootManagerLib/QemuKernel.c > index ef728dfdeb60..f20df9533fda 100644 > --- a/OvmfPkg/Library/PlatformBootManagerLib/QemuKernel.c > +++ b/OvmfPkg/Library/PlatformBootManagerLib/QemuKernel.c > @@ -18,6 +18,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -149,6 +150,9 @@ TryRunningQemuKernel ( > // > EfiSignalEventReadyToBoot(); > > + REPORT_STATUS_CODE (EFI_PROGRESS_CODE, > + (EFI_SOFTWARE_DXE_BS_DRIVER | EFI_SW_DXE_BS_PC_READY_TO_BOOT_EVENT)); > + > Status = LoadLinux (KernelBuf, SetupBuf); > > FreeAndReturn: > Good catch! Reviewed-by: Laszlo Ersek Laszlo