Re: [PATCH v9 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

["Laszlo Ersek" <lersek@redhat.com>]

Hi Vladimir,

On 08/30/20 02:28, Vladimir Olovyannikov wrote:
> Signed-off-by: Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Nd <nd@arm.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
> 
> This patchset introduces an http client utilizing EDK2 HTTP protocol, to
> allow fast image downloading from http/https servers.
> HTTP download speed is usually faster than tftp.
> The client is based on the same approach as tftp dynamic command, and
> uses the same UEFI Shell command line parameters. This makes it easy
> integrating http into existing UEFI Shell scripts.
> Note that to enable HTTP download, feature Pcd
> gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections must be set to TRUE.
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2860
> 
> PATCH v9 changes:
>   - check that Response pointer is not NULL before accessing Data structure 
>     member, to prevent possible NULL pointer dereference.

looks like there's still intense development occurring in
HttpDynamicCommand.

I'd like to conserve some testing effort on my end, so I'd like to test
this feature only once more; just before it's merged. I suggest
stabilizing the feature set now, and only focusing on important bugfixes.

Thanks!
Laszlo