From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web10.49856.1598865327471987953 for ; Mon, 31 Aug 2020 02:15:27 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=a2WTu4Ek; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598865326; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gcp9wIpYTJTmwfu5bsquxWPpJZqiRY+2Ac5bVE1Tmso=; b=a2WTu4EkkWYr80Jk1hsN+1Nam3J0+8kFhYoxLCDDZPMZ9SBmAvR0Vprws35B7445PV5WjZ B2m7Rot/siPhlpfyxHZzdMIgsu2YUz90MEBmZlXTpCDxrQTWTXvmpNeX0SY6FB54JYzEgI OoiFfjykNekW0MgvshsZMwAOhmPulJM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-248-6L2h9hP-PN6L2OA44oC9Ng-1; Mon, 31 Aug 2020 05:15:18 -0400 X-MC-Unique: 6L2h9hP-PN6L2OA44oC9Ng-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CBF2A59; Mon, 31 Aug 2020 09:15:16 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-125.ams2.redhat.com [10.36.113.125]) by smtp.corp.redhat.com (Postfix) with ESMTP id A0BAD81184; Mon, 31 Aug 2020 09:15:14 +0000 (UTC) Subject: Re: [PATCH v9 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand To: Vladimir Olovyannikov , devel@edk2.groups.io Cc: Zhichao Gao , Maciej Rabeda , Jiaxin Wu , Siyuan Fu , Ray Ni , Liming Gao , Nd , Samer El-Haj-Mahmoud References: <20200830002847.12726-1-vladimir.olovyannikov@broadcom.com> From: "Laszlo Ersek" Message-ID: Date: Mon, 31 Aug 2020 11:15:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200830002847.12726-1-vladimir.olovyannikov@broadcom.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Hi Vladimir, On 08/30/20 02:28, Vladimir Olovyannikov wrote: > Signed-off-by: Vladimir Olovyannikov > Cc: Zhichao Gao > Cc: Maciej Rabeda > Cc: Jiaxin Wu > Cc: Siyuan Fu > Cc: Ray Ni > Cc: Liming Gao > Cc: Nd > Cc: Laszlo Ersek > Cc: Samer El-Haj-Mahmoud > > This patchset introduces an http client utilizing EDK2 HTTP protocol, to > allow fast image downloading from http/https servers. > HTTP download speed is usually faster than tftp. > The client is based on the same approach as tftp dynamic command, and > uses the same UEFI Shell command line parameters. This makes it easy > integrating http into existing UEFI Shell scripts. > Note that to enable HTTP download, feature Pcd > gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections must be set to TRUE. > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2860 > > PATCH v9 changes: > - check that Response pointer is not NULL before accessing Data structure > member, to prevent possible NULL pointer dereference. looks like there's still intense development occurring in HttpDynamicCommand. I'd like to conserve some testing effort on my end, so I'd like to test this feature only once more; just before it's merged. I suggest stabilizing the feature set now, and only focusing on important bugfixes. Thanks! Laszlo