From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 053D97803CD for ; Thu, 10 Aug 2023 13:33:58 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=XKJQWWHhmh035KTxyRM+jw42wuaSs9jj9uFcnqjp0cI=; c=relaxed/simple; d=groups.io; h=ARC-Message-Signature:ARC-Seal:ARC-Authentication-Results:Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References:User-Agent:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1691674437; v=1; b=tle73ewmMvdU8F0pdxtcOi9UZl5KHW/qrbNPKTfk6CuGM1014d8Y/aiASTZvIxyKkS4/cyYc in1VzvHWJ60+AQ8r8dmJhRQ6pjtZXl65I74dov4HuJ5Fk731azRkNi+nkHckfvdgIAr3sBMnTDu MMtw3y8yHY8q8zwoa9b/4RSs= X-Received: by 127.0.0.2 with SMTP id zjP0YY7687511xxLmOrMmG2J; Thu, 10 Aug 2023 06:33:57 -0700 X-Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by mx.groups.io with SMTP id smtpd.web11.17148.1691674436153416326 for ; Thu, 10 Aug 2023 06:33:56 -0700 X-Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4RM7D43fzQz4D96; Thu, 10 Aug 2023 13:33:24 +0000 (UTC) (envelope-from corvink@FreeBSD.org) X-Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RM7D42nl0z3P5H; Thu, 10 Aug 2023 13:33:24 +0000 (UTC) (envelope-from corvink@FreeBSD.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1691674404; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6Deraf9+fyvpLeVRvYUiRfMADeuHio/SP6orqS7PadA=; b=OWRNmGloxiwNUQ+tivFkPm9BI2JO1LLdWrfn304bWuxtn/62V7kWOJ6V8R9mxg23nIQ/oa c22N0ATILsML+ZIiVk/kXBtvmycmU9zwNTxabAfcXdMPBHLlO34OM+NbzmfPLSZm27OuUn jeE84Wm3OlIlqW+Edab9qrsDw36kqxeTNNRXT+6eTMmrHSErZ3/rsDS0dIVyKG8fSbhKDz qKzGk18VpAtKadSPhcuNs6Xj+xdbKIsiHTSXKcZ5BaF1ZgXwBJAkq8MFTEPXVB+pXuTP/2 vhd/B/+PloGTkjxgIjqvxb5tO6ZUqTMUPEdHFdnVPZDB2/sE04oMkLViNXWTcw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1691674404; a=rsa-sha256; cv=none; b=fxcRt6g2nA/zlKQcj6OOoh4O/87OXyUr5TrNap7hEA9yPDluwaP5n7ysihP1ID+EXSxQQJ 7Oe+MJSric36t7ujLV3Zlw+5z3TMbg85/CD/VBy1lIj/tLz3woXMl7VoBPKnYzA9nXEnIS ioDamU7nCfuvOP8m5/+Xa6EQoGbS2ZRy4OSrzdqHSymT6wLLs/UM4T3HIT0BbbjfhAtFKh vfTrY/u/WHnOKFBYPguDO3nnS7Yb7jbry0zkJSuWY+i4O/9wempduKRzMGXokni1c3lOcG HDWCWl8MhBWc8u7Y6MXAnMBfWUgnbyxV7+nPZ/jFPg8rP2+NioAwr/8Qx0znJw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-Received: from [172.21.179.63] (unknown [195.226.174.194]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: corvink) by smtp.freebsd.org (Postfix) with ESMTPSA id 4RM7D253HHz1kR; Thu, 10 Aug 2023 13:33:22 +0000 (UTC) (envelope-from corvink@FreeBSD.org) Message-ID: Subject: Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: build platform info HOB From: =?UTF-8?B?Q29ydmluIEvDtmhuZQ==?= To: Ard Biesheuvel , devel@edk2.groups.io Cc: Rebecca Cran , Michael Kinney , Jiewen Yao , Jordan Justen , Gerd Hoffmann , Peter Grehan , Michael Kubacki Date: Thu, 10 Aug 2023 15:33:21 +0200 In-Reply-To: References: <20230724130006.427522-1-corvink@FreeBSD.org> <20230724130006.427522-2-corvink@FreeBSD.org> <899bbdac-5aa3-50c4-f6e2-926b7a22c799@bsdio.com> User-Agent: Evolution 3.48.4 MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,corvink@FreeBSD.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: yrIITSW2rAnoXFL6qj6O8Z29x7686176AA= Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-B9k/v+a6J5bnvgIZxDFA" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=tle73ewm; arc=reject ("signature check failed: fail, {[1] = sig:freebsd.org:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --=-B9k/v+a6J5bnvgIZxDFA Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2023-08-10 at 14:55 +0200, Ard Biesheuvel wrote: > On Thu, 10 Aug 2023 at 14:53, Corvin K=C3=B6hne > wrote: > >=20 > > On Tue, 2023-08-08 at 18:25 +0200, Ard Biesheuvel wrote: > > > On Tue, 8 Aug 2023 at 15:33, Rebecca Cran > > > wrote: > > > >=20 > > > > Nit: "sizeof" is normally used like a function. And this patch > > > > mixes the > > > > two styles. > > > >=20 > > >=20 > > > Actually, this is not unidiomatic for OVMF - sizeof takes either > > > a > > > type name (in which case the () are required) or an expression > > > (in > > > which case they are optional), and we have always permitted both > > > idioms for the latter case. > > >=20 > > > $ git grep -cE 'sizeof\s*[:alnum:]' OvmfPkg/ > > > OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.c:4 > > > OvmfPkg/EnrollDefaultKeys/AuthData.c:4 > > > OvmfPkg/IncompatiblePciDeviceSupportDxe/IncompatiblePciDeviceSupp > > > ort. > > > c:7 > > > OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.c > > > :1 > > > OvmfPkg/PlatformPei/MemTypeInfo.c:1 > > > OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.c:5 > > > OvmfPkg/QemuVideoDxe/VbeShim.c:4 > > > OvmfPkg/SmmControl2Dxe/SmiFeatures.c:4 > > > OvmfPkg/Virtio10Dxe/Virtio10.c:1 > > > OvmfPkg/VirtioGpuDxe/DriverBinding.c:4 > > >=20 > > >=20 > > > > Other than that: > > > >=20 > > > >=20 > > > > Reviewed-by: Rebecca Cran > > > >=20 > > >=20 > > > Thanks > > >=20 > > >=20 > > > I've tried to merge this but I am getting errors and I cannot > > > figure > > > out what they are: > > >=20 > > > https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=3D9950= 5&view=3Dresults > > >=20 > >=20 > > Thanks. Have you tried > > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Code-Forma= tting#how-to-find-uncrustify-formatting-errors-in-continuous-integration-ci > >=20 > > I'm stuck at step 5. I can't see something like "92.5% passed". > > Maybe I > > don't have the permission to see it? > >=20 >=20 > I was having the same problem. The instructions don't match the > actual > situation, so it is impossible for me to figure why the CI decided to > reject the series. The function is copied from OvmfPkg/PlatformPei. So, it's unlikely that it causes issues. Nevertheless, I found a candidate: > diff --git a/OvmfPkg/Bhyve/PlatformPei/Platform.c b/OvmfPkg/Bhyve/PlatformPei/Platform.c > index 5bfe435327c1..bdfc1614d284 100644 > --- a/OvmfPkg/Bhyve/PlatformPei/Platform.c > +++ b/OvmfPkg/Bhyve/PlatformPei/Platform.c > @@ -17,6 +17,7 @@ > // > // The Library classes this module consumes > // > +#include > #include This is not in alphabetical order. > #include > #include --=20 Kind regards, Corvin -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107689): https://edk2.groups.io/g/devel/message/107689 Mute This Topic: https://groups.io/mt/100327419/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --=-B9k/v+a6J5bnvgIZxDFA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgvRSla3m2t/H2U9G2FTaVjFeAmoFAmTU5yEACgkQ2FTaVjFe AmoHfQ//dY7FuCLvtohsYK39BzOpwb2tXEaaZ2jrFMDfPDo/i4386qPivZavVoBc hLCQiQe5CFmXlUqJvm28GMSB/dOoUEjabJBr/dFE8Vbkv/nDOg/JmiLahxQZUMOe kXy3RfR/iJIL2AuRX0h2NwI2C9HlNTX2EooBTrRSCwQmr8gRZ4v4BwzKGd9rR/pD bNlHYmTBFC+L2qnMGNUgg3anHm8hIyymmf2kxW51i0wdKHuI16FjVP43U3v5wAoS 4NVB8Gw02niN184OkEVThAikQaJkr8qznb/ol+nekGWgViYdxAPHrfboACkZszGy tp1g5qrFNrovyTpZuiN0yKycxsQeqFstBWmDCf+CnrCrkX76i/u0DTJc89wVq3zK ZGZJFGoLuhMykf3oPrtFEUPFuvXHtzdjm83l9XPj4gdzp7kB1buKLENkiePeA/pV MFqfhSmNdpmqnUeRcGboZtdPfgPc37gCsZF2DfKtXd4Wly1o1XVVkat7rv/8QlxV C/ukW8g+obpyA4G0sw/VIFFOIzZH8NpumvUbp4fJ3C8i9Tn3TvRIaXIdVYH2h8Ve O+O8IfmoVV4r82ose+3jmUp6PsaM6gHTo1mvGoPRjGpzsBO0kvMUoF+P71ljxXoj qgKgFNZsyQrdfZ6VNNo09m5/t6zZcEGzYPQ7iZI5n/kbrVdGiM4= =+DdH -----END PGP SIGNATURE----- --=-B9k/v+a6J5bnvgIZxDFA--