From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: philmd@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 08 Oct 2019 06:11:50 -0700 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D43DC69078 for ; Tue, 8 Oct 2019 13:11:49 +0000 (UTC) Received: by mail-wm1-f72.google.com with SMTP id r21so964668wme.5 for ; Tue, 08 Oct 2019 06:11:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BetWesgjqONItWyabgHJREU84y5SPO5jd4A0/mZs71w=; b=tXNOnNYaB8vrHreq4aGcdexOfXJkAKDZO5oWNtsak+CUGUbU/tzyk8l92gI9cRZ2uO vT5tY+Q8Sq+Wg/4j9C38HffIIYEcN1EDUrK628R0Ti1zkERsHZAkSpqUVHKzaBQPvWsd LcxeJgWP92YbQMPHtZbxRmgofFTHDeb3N493TENJnL6q+PZNUUA/DTznaN0Hfp2d6tWr zuLW7PKptTcJbfhBN+F/kXPr+fIXBVu3h0dIj1OIHoARXliGOKQDIiLdjaMugVHKY310 EIpNzUFtS/GlxZTv+BXMjx8swTJsrxequOP6IVU4I5HnbOO9FGSIDMp18I8Mdc867AHw PyRQ== X-Gm-Message-State: APjAAAX2HH3r7V5ZjB69xyRcZ2vpudtFZR2ZahgJ116nd8GrgaVWN9NU R00QTCBe4Sh6ydFa6Eix5M7i2k4IXpv5zNKfROJh2ArxNFNYq0UsuGmN0wvkkTq/jvfRwNyMUre Ivlu4esp+GT6o4Q== X-Received: by 2002:a5d:6a8a:: with SMTP id s10mr6230952wru.209.1570540308669; Tue, 08 Oct 2019 06:11:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqyI9hL6e/obFUw7cZGoQHIHGmyQH98iu2YvUp8RxtjKH3Whh0WSU2fG4gQiQzwEZ+LHDlvFuQ== X-Received: by 2002:a5d:6a8a:: with SMTP id s10mr6230934wru.209.1570540308466; Tue, 08 Oct 2019 06:11:48 -0700 (PDT) Received: from [192.168.1.35] (46.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.46]) by smtp.gmail.com with ESMTPSA id t203sm4338909wmf.42.2019.10.08.06.11.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Oct 2019 06:11:47 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH 2/4] OvmfPkg/OvmfXen.dsc: remove PcdCpu* dynamic defaults To: devel@edk2.groups.io, lersek@redhat.com Cc: Anthony Perard , Ard Biesheuvel , Igor Mammedov , Jordan Justen , Julien Grall References: <20191008112714.6215-1-lersek@redhat.com> <20191008112714.6215-3-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Tue, 8 Oct 2019 15:11:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <20191008112714.6215-3-lersek@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/8/19 1:27 PM, Laszlo Ersek wrote: > PcdCpuMaxLogicalProcessorNumber and PcdCpuApInitTimeOutInMicroSeconds are > only referenced in "OvmfPkg/PlatformPei/PlatformPei.inf", and OvmfXen does > not include that module. Remove the unnecessary dynamic PCD defaults from > "OvmfXen.dsc". > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Igor Mammedov > Cc: Jordan Justen > Cc: Julien Grall > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1515 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/OvmfXen.dsc | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc > index 5a31f75f05d0..6deafea034c0 100644 > --- a/OvmfPkg/OvmfXen.dsc > +++ b/OvmfPkg/OvmfXen.dsc > @@ -481,10 +481,6 @@ [PcdsDynamicDefault] > gEfiMdeModulePkgTokenSpaceGuid.PcdSetNxForStack|FALSE > gEfiMdeModulePkgTokenSpaceGuid.PcdPropertiesTableEnable|FALSE > > - # UefiCpuPkg PCDs related to initial AP bringup and general AP management. > - gUefiCpuPkgTokenSpaceGuid.PcdCpuMaxLogicalProcessorNumber|64 > - gUefiCpuPkgTokenSpaceGuid.PcdCpuApInitTimeOutInMicroSeconds|50000 > - > # Set memory encryption mask > gEfiMdeModulePkgTokenSpaceGuid.PcdPteMemoryEncryptionAddressOrMask|0x0 > > Reviewed-by: Philippe Mathieu-Daude