From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.11267.1613753518222442801 for ; Fri, 19 Feb 2021 08:51:58 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: jeremy.linton@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6DE23ED1; Fri, 19 Feb 2021 08:51:57 -0800 (PST) Received: from [192.168.122.166] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0B2443F694; Fri, 19 Feb 2021 08:51:53 -0800 (PST) Subject: Re: [PATCH v3 0/4] RPi: SD/WiFi ACPI updates To: Ard Biesheuvel , jlinton Cc: devel@edk2.groups.io, Peter Batard , Andrei Warkentin , Samer El-Haj-Mahmoud , Leif Lindholm , Ard Biesheuvel References: <20210217061809.307479-1-lintonrjeremy@gmail.com> From: "Jeremy Linton" Message-ID: Date: Fri, 19 Feb 2021 10:51:53 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi, On 2/18/21 12:49 PM, Ard Biesheuvel wrote: > On Wed, 17 Feb 2021 at 07:18, jlinton wrote: >> >> From: Jeremy Linton >> >> The existing RPi3 ACPI entries for the Arasan >> and SDHCI controllers need updating to work >> with the RPi4. This is done by adding a caps >> override for the legacy Arasan controller and >> then adding an entirely new entry for the newer >> eMMC2 controller. >> >> Then we flip the default routing to make the eMMC2 >> the default for the SD card, so that the WiFi can >> start working on the Arasan. >> >> Additional we add a menu item to enable the SDMA/ADMA2 >> modes on the controller. >> >> v2->v3: Various small review tweaks, whitespace, wording >> spelling, etc. >> >> v1->v2: Add option for user to enable/disable eMMC DMA >> Only enable the emmc2 table on rpi4 & >> !Arasan routing >> Move emmc2 into its own SSDT and drop >> second _DMA entry >> >> Jeremy Linton (4): >> Platform/RaspberryPi: Add Negative table check >> Platform/RaspberryPi/Acpitables: Add eMMC2 device and tweak Arasan >> Platform/RaspberryPi: User control of eMMC2 DMA >> Platform/RaspberryPi: Invert default Arasan, eMMC2 routing >> > > Could you please resend these in a way that I can apply them? They > seem to have gone through some QP mangling filter, with long lines > broken and newlines doubled in some cases (depending on the line > ending mode of the file, it seems) Sorry about that, I did change my email path slightly due to the weather events here, but I don't see what in the path below could be causing the problem. Its still using the same mail server on my side. I have pushed this set, and the IORT fix, to github as well: https://github.com/jlinton/edk2-platforms.git Branch rpi_iortFix_acpiMmc Thanks, > > https://pastebin.com/yG74aygV > > >> Platform/RaspberryPi/AcpiTables/AcpiTables.inf | 1 + >> Platform/RaspberryPi/AcpiTables/Emmc.asl | 129 +++++++++++++++++++++ >> Platform/RaspberryPi/AcpiTables/Sdhc.asl | 18 ++- >> Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 26 +++++ >> .../RaspberryPi/Drivers/ConfigDxe/ConfigDxe.inf | 1 + >> .../RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.uni | 4 + >> .../RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr | 17 +++ >> Platform/RaspberryPi/Include/ConfigVars.h | 8 ++ >> Platform/RaspberryPi/RPi3/RPi3.dsc | 1 + >> Platform/RaspberryPi/RPi4/RPi4.dsc | 3 +- >> Platform/RaspberryPi/RPi4/Readme.md | 2 +- >> Platform/RaspberryPi/RaspberryPi.dec | 1 + >> 12 files changed, 206 insertions(+), 5 deletions(-) >> create mode 100644 Platform/RaspberryPi/AcpiTables/Emmc.asl >> >> -- >> 2.13.7 >>