From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.42]) by mx.groups.io with SMTP id smtpd.web10.11835.1620400760226736094 for ; Fri, 07 May 2021 08:19:20 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=fabIz8Mr; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.92.42, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c1CeTG6f8Y6ZhO+cIS7efnyYVGUuMqKTjoY/j+yTkjTObMXNPPTheqdHBE5EDeRNmsxkDN8azXt6LLOma2HoPHMlJephRpencLHIyRQXlzJJV5Tn+1pxiDYplb9sOLFYr33CkpIEq8EY76tyhSb5/PGXlrpBg1vn4iW4bBuaSAg6MO1BzyhkQX5SaAf1PQNhzx6c4rm+th+At+2IVwiCkz+zj469ROXu84FzbpvIw+I573v9xkOiM/u5MYmh3aQCKA0KXxc6q5AnLjQ4K23vha/0hNmO5IJVZwn7d/DcDIVTP6N4QFsXdlMHI1LH7wqP+C3RdvQa6jVP/EC3Pf+3cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=90Lr++ickNxWU0bNx4BTIfeYmB1oDUXQOxdduqFzX80=; b=e6tKTApwD0btzjkf0abIn2fMEtN/EExazwIfpV0dq8xw+ui1OTYRLtU0piHu22R1WwprKKU+Woo7IIiJy6+QinNZ3pqHea5/hT6+CRdn6t/VWn3bHHlazltc1kxDUZO8RplAv/vh8I8vCWBgEKHfV56bYWkhOSTZBMk/t7IdUvXPffnB1BK3iBkIWI8NuMlmEFQTc/9GYI7tQmzDhJSMujHHfrU8GzfxdT4cCONzeXfjQz6eycu35Br6rYl8FQDp+9DCIYKuQxngaRJxRtOQYEdH6VZ+UdiiVRH9my8wx0ExvULsvYrfxIzMVUXoydL1ki19GqNlLZx491Z4zVPLFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=90Lr++ickNxWU0bNx4BTIfeYmB1oDUXQOxdduqFzX80=; b=fabIz8Mr/P4WkZGuP9T+Qe85TteHP2uCgrlc2kk9ZvVVrqw+01vgMbQXq+z4xfR4EueHtKn1pXBhq6KBwVDNQzXsEuxCXjhG3CS4nDSmOxbUCYnaOJAUv7vx7PEAalgLpZ2ZmFv50/o0q/XuDh9a8EZhj54quSW0sHjz9Xr4LCE= Authentication-Results: google.com; dkim=none (message not signed) header.d=none;google.com; dmarc=none action=none header.from=amd.com; Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SN6PR12MB2637.namprd12.prod.outlook.com (2603:10b6:805:6b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.26; Fri, 7 May 2021 15:19:18 +0000 Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94%6]) with mapi id 15.20.4108.029; Fri, 7 May 2021 15:19:18 +0000 Cc: brijesh.singh@amd.com, devel@edk2.groups.io, James Bottomley , Min Xu , Jiewen Yao , Jordan Justen , Ard Biesheuvel , Erdem Aktas Subject: Re: [edk2-devel] [PATCH RFC v2 09/28] OvmfPkg/VmgExitLib: Allow PMBASE register access in Dxe phase To: Laszlo Ersek , Tom Lendacky References: <20210430115148.22267-1-brijesh.singh@amd.com> <20210430115148.22267-10-brijesh.singh@amd.com> <39e81516-ae93-e737-4203-af10cb07a9f9@redhat.com> From: "Brijesh Singh" Message-ID: Date: Fri, 7 May 2021 10:19:16 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 In-Reply-To: X-Originating-IP: [70.112.153.56] X-ClientProxiedBy: SA9PR13CA0148.namprd13.prod.outlook.com (2603:10b6:806:27::33) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) Return-Path: brijesh.singh@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from Brijeshs-MacBook-Pro.local (70.112.153.56) by SA9PR13CA0148.namprd13.prod.outlook.com (2603:10b6:806:27::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.28 via Frontend Transport; Fri, 7 May 2021 15:19:17 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f3e9fb66-9c85-4e14-227c-08d9116b7b7e X-MS-TrafficTypeDiagnostic: SN6PR12MB2637: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7hVJsR7RGMzTAM+nhKL0k2SFtymp9NgxSjbisct1v0B0fkq208WMEazIAovqUCif2q9I9jyaDtHbIilvYtBMI3ff3PWBjKUVECaLYiFSr4toZPzOHyQpd5G/iT5tbcN09zckg+c7lzNoIy9GPCt9v5S9v4wbgeT0hVzhqdrXAoMctWnhVtX07++2pYuEdzPH080Jy/7esY4S/tUEKgWoGAd3x+334akj5sbAqRulq5DmIgZoq2zmFYaZ0Z9ut+o/xvqrR5UmGoSJHx8IY5c6SAUzL9qm99buGXPb5DgEAds581xF33iZKqioL+YNk7ROo0FIGhKYuqQPOXO7ubbE82ihpFPT6GFMya2kvy52HjNy3OfQ8JT6rNWSm6WaCuCn4lK1yzno6aLtc/mF6aLPy2Pdo2VSOrx7OD1SQ0n+n/+ZN923JToRZpAbbUca7QIaMa4L9NLMQ1aE5k0nAjoh1ojkQPC0uL9Ez0kmWlPINeEUrH3LBZATkPFjvw4uyc/HDj+TEjmlVfZ/D7w2lyc1zyJgvjC21wIwDcOr/7Tt35vwUOi3hnW5Zj9ygoEGKIvinJCCO0zkjkmyFDahsyrq8oXv+eR59wGQXA6TewSn8WcIG4c33ko3fT/mSzwwkeVJv/E5VwzzMG7NOtLf9XbAAjg+xR7X/Fd1NGgae/oNH0997GkD8rPkAKB5UluTPHhwqkqGR2CZzGFpAl2tfPWf180L7UwqAjwV3v+dxa10tEE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2718.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(376002)(39860400002)(366004)(346002)(396003)(2906002)(53546011)(16526019)(478600001)(956004)(110136005)(186003)(54906003)(26005)(31686004)(44832011)(2616005)(38100700002)(6506007)(38350700002)(5660300002)(8936002)(8676002)(66946007)(4326008)(52116002)(36756003)(6512007)(6636002)(86362001)(66556008)(66476007)(316002)(31696002)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?d3hHZXRjQ1VPbVNqWnR4N214WFREL3h1V2tnYmIwaVljZDViVFNKMnhMYWoy?= =?utf-8?B?NGlRSXRTSEZZRWJ3OTUvY21nYVpVb2ZNN0pkMHJVK2x4a1RHakxYWHNBdWlI?= =?utf-8?B?R3Fkd3EzTm9BRms1cTlrTitPKzZBODdVVHJlbi9UVXA4NE82SUdxRm92NjlJ?= =?utf-8?B?THJwS05rdS9WNGNtNWpmT2NmODZnbXJzZDNDQ1premczVXlTeW1OaXZPVmc5?= =?utf-8?B?Wjd6T3hTbXo3TzlmY3o3NG03QXBVRXRjR3loTFVZUE83Ui9XdVJnaG5EMkVw?= =?utf-8?B?eGhRMlhsZ3FVaFNmVVdlaDV1NVRKRFNQN294ZDBveTJuL3dUMGJrT0tSVWVk?= =?utf-8?B?RmJLczg4dWEwZ0JldEVzb2REMFE5aUd4dWNoMDlYNGNvNS90UzBnbmV0OHB3?= =?utf-8?B?YjcxejVSVWl5djc1Mko2Tk9hVU4rbTYycGk5Q1BDUkRudTFhL29MSHpmT3g3?= =?utf-8?B?OUJHT2VJZ2NpdWROSXVKbVBSREVhVDN5NEhyeUJUWFRUb09UTWtJbVFPYmJ6?= =?utf-8?B?OTFyQ2xuNS82Z1ZzQ3JVTDdwNk1jQWxRTTlYZHBncUYrRzZoSFRVR1dvK3VC?= =?utf-8?B?RjVhODFlV3BYYjNqWTRQV2FlRTJTNkdEbU01ZzRGRkt2TjMwSUVhaXNqRmhy?= =?utf-8?B?K2IxbTNUMkhCRW9NQ2RwZ1FNSE9uTjNZODg0NWl5UUlYdXdUNjcrYW4wcWtY?= =?utf-8?B?VEJjekIxTlJvZW5sYllNK1MvQ3RrMDRTKzJlK1R0bXVFOXoyZmJkRlM4NHVD?= =?utf-8?B?aWcwMFZCcGxxV0lTQzllOGcrY0xrYzYzUyt5VDNZWU0yMkZtMFN1dTY5WXBu?= =?utf-8?B?c3VnY1RoYjloalFzc0ZncUs1TGllQjI3aXk0b05yWndwa2FVL3JSeC9KckJQ?= =?utf-8?B?ZXFKSnFlOWRjZ21Ba1I2aGJUb2pGelpJRmZiT0VoUjJNT1lBQlFNdHhMbFpU?= =?utf-8?B?dlNyaXpLZHF5QVA4UWN6R1RqQk9VNmpmRlFVUjgvNHFtd3JWUWhLVXViZkFK?= =?utf-8?B?akF6K2tUOFhHRkltVUlhSmppZzF3cC9iT0gvUEF2YnUxYW90WGpVYnZud0Fn?= =?utf-8?B?SUhjUHF4aVZqKzJ1MDczQ3ZoRU1SNEo4YTE1cnBKbFRnWFI0aWZHNUNVUkpR?= =?utf-8?B?bWVIMXRFRXlEQmIxc3ovbVBwcmtXTkRXdko3NkcrTEY2RWkvRStSRlVqWXlH?= =?utf-8?B?dytLUWtGSG95aXZJeVZ1b3d6MkpWOTlZYmlUN29DNFBGOGpVb2EyamUwTDdy?= =?utf-8?B?NFIrK1ZiZElqZVJqazFpbFVNbTJXQ1k5eENVK1ZDZXJ1YkJRWm8zQ0h0TitE?= =?utf-8?B?WlZLY0lTZHFScTg4OTZ4bEZJQ2xsVUhtQVNvWnpsa2lOWUUxeG9YOVhLam9D?= =?utf-8?B?aGczZ1VwU2RJSTVXakJCRlB4TWNOTnZHNWdJVWtYWjNBZjhZQ1NjdDVnckZH?= =?utf-8?B?Vnh1aGVuNEE0RGRYV3RqcDdyMXJLdGdMM09IT2pnQXRseXMxWUM2YjlEd0cx?= =?utf-8?B?UXEwOW1jZGZyTkFlalhJQzRoZEZwbjFjdTFTeWo5bWVFdmpFblUyUTVCSzFq?= =?utf-8?B?UXV2SjI1WHFON0pyU2VEZUxvMWpSc3FjN0x5WXUvT2hIMVVVNzh4VzdaVDlO?= =?utf-8?B?ZFcrYjRMc0oxOFJyUGx3TjFmNTdBTEU1eDJCZERTQ1ZxTm1BT3RETXFrY05J?= =?utf-8?B?emJOTVVLMzZuL3lQOUZydnIvUkZRSHNjb01ZV3UrNDZ3am4rSWhMaFI4bDJQ?= =?utf-8?Q?4AQVYT+5kiseKOpKP/PpXTcTe51kw5k+w28oMjI?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f3e9fb66-9c85-4e14-227c-08d9116b7b7e X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2021 15:19:18.1841 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Xn6tmUa5bLcM020ZvI/5olYvHVKRTxTcGhv0mJJdCek6pgBkKFWyhqqvQAlc2vswmbMR5xIJgQao/8Zp4muY5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2637 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US On 5/7/21 10:10 AM, Laszlo Ersek wrote: > >> Sounds good. What's your thought if I take out patch 1 - 9 from this RFC >> series and submit them as non-RFC for the further review and acceptance >> ? The patch# 1-9 are basically prepatch before we get into SNP specific >> bits. > More precisely, that means patches 1-8 (because patch#9 should be > replaced by the module-scope override, and also moved to just before > what is currently patch#21). > > Other than that, I agree, this is a good idea. I've anyway thought that > the MdePkg stuff (5 patches) could be / should be merged up-front in > separation, and then the subsequent 3 patches for OvmfPkg are basically > refactoring. We can record the resultant commit range (8 commits) in > TianoCore#3275, and keep the BZ open for the rest of the work. So go > ahead please. Yes, I will keep patch#9 in SNP series. FYI, I will add couple of more patches in MdePkg to define the macros for AP creation and RMPAJUST instruction. Now that GHCB spec is final, we are working to get the AP creation implemented for the next version. -Brijesh