From: "Wang, Yin" <yin.wang@intel.com>
To: Gerd Hoffmann <kraxel@redhat.com>, <devel@edk2.groups.io>
Cc: <ard.biesheuvel@arm.com>, <jordan.l.justen@intel.com>,
<sunilvl@ventanamicro.com>
Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg:Fix Hii form name mismatch with EFI variable
Date: Thu, 20 Jul 2023 08:57:54 +0800 [thread overview]
Message-ID: <e9d2079e-97cf-e822-f87b-889d73ce8a5b@intel.com> (raw)
In-Reply-To: <kvtfn25l3q4wxw26wqehg4inotquxwhzca4puirexaqh2mbe3s@32dk4owzb4bd>
Hi, Could you help to review on it?
Thanks in advance!
Yin
On 7/17/2023 7:36 PM, Gerd Hoffmann wrote:
> On Fri, Jul 14, 2023 at 04:59:48PM +0800, Wang, Yin wrote:
>> Onemore need change beside fixs:16acacf24c ("OvmfPkg: fix PlatformConfig")
>> Find by sct case:ExtractConfigConformance fail.
>>
>> Signed-off-by: Yin Wang <yin.wang@intel.com>
>> ---
>> OvmfPkg/PlatformDxe/Platform.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/OvmfPkg/PlatformDxe/Platform.c b/OvmfPkg/PlatformDxe/Platform.c
>> index cd3bfd554c98..c32439683d83 100644
>> --- a/OvmfPkg/PlatformDxe/Platform.c
>> +++ b/OvmfPkg/PlatformDxe/Platform.c
>> @@ -279,7 +279,7 @@ ExtractConfig (
>> //
>> ConfigRequestHdr = HiiConstructConfigHdr (
>> &gOvmfPlatformConfigGuid,
>> - mVariableName,
>> + mHiiFormName,
>> mImageHandle
>> );
>> if (ConfigRequestHdr == NULL) {
> Acked-by: Gerd Hoffmann <kraxel@redhat.com>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107078): https://edk2.groups.io/g/devel/message/107078
Mute This Topic: https://groups.io/mt/100142143/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-07-20 0:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1689314786.git.yin.wang@intel.com>
2023-07-14 8:59 ` [PATCH 1/1] OvmfPkg:Fix Hii form name mismatch with EFI variable Wang, Yin
2023-07-17 2:52 ` [edk2-devel] " Wang, Yin
2023-07-17 11:36 ` Gerd Hoffmann
2023-07-20 0:57 ` Wang, Yin [this message]
2023-08-07 12:02 ` Sunil V L
2023-08-08 1:44 ` Wang, Yin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9d2079e-97cf-e822-f87b-889d73ce8a5b@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox