Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing libraries to [Components] in DSC

["Michael Kubacki" <mikuback@linux.microsoft.com>]

Thanks for the review.

Can you please merge this soon if there are no concerns?

On 3/23/2022 2:15 AM, Chiu, Chasel wrote:
> 
> Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> 
>> -----Original Message-----
>> From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
>> Sent: Wednesday, March 23, 2022 9:28 AM
>> To: devel@edk2.groups.io
>> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
>> <nathaniel.l.desimone@intel.com>; Gao, Liming
>> <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
>> Subject: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing
>> libraries to [Components] in DSC
>>
>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>
>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3619
>>
>> Adds libraries implemented in MinPlatformPkg to the [Components]
>> section in MinPlatformPkg.dsc so they are included in the package build.
>>
>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>> Cc: Eric Dong <eric.dong@intel.com>
>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>> ---
>>   Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
>> b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
>> index 0f47182c2647..a8373a4ecb37 100644
>> --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
>> +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
>> @@ -211,6 +211,13 @@ [Components]
>>
>> MinPlatformPkg/Library/BaseVariableReadLibNull/BaseVariableReadLibNull.
>> inf
>>
>> MinPlatformPkg/Library/SmmVariableReadLib/StandaloneMmVariableRead
>> Lib.inf
>>
>> MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneMmVariableWri
>> teLib.inf
>> +  MinPlatformPkg/Library/PeiVariableReadLib/PeiVariableReadLib.inf
>> +
>> +
>> MinPlatformPkg/Library/DxeRuntimeVariableReadLib/DxeRuntimeVariableR
>> ea
>> + dLib.inf
>> +
>> MinPlatformPkg/Library/DxeRuntimeVariableWriteLib/DxeRuntimeVariable
>> Wr
>> + iteLib.inf
>> +
>> MinPlatformPkg/Library/SmmVariableReadLib/TraditionalMmVariableRead
>> Lib
>> + .inf
>> +
>> MinPlatformPkg/Library/SmmVariableWriteLib/TraditionalMmVariableWrit
>> eL
>> + ib.inf
>> +
>> MinPlatformPkg/Library/BaseLargeVariableLib/BaseLargeVariableReadLib.i
>> + nf
>> + MinPlatformPkg/Library/BaseLargeVariableLib/BaseLargeVariableWriteLib.
>> + inf
>>
>>   [BuildOptions]
>>     *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
>> --
>> 2.28.0.windows.1
> 
> 
> 
> 
>