From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.11222.1648822372175396841 for ; Fri, 01 Apr 2022 07:12:52 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=iW9uj0tD; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.202.59.224]) by linux.microsoft.com (Postfix) with ESMTPSA id 1441A20DEEC6; Fri, 1 Apr 2022 07:12:50 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1441A20DEEC6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1648822371; bh=jY+Ipu8hdQ4si+Teqh9zwlF2Yq6z01fWHVDgASj5Tbk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=iW9uj0tDlz/MOMMhLaPhY6EGyt+AgbckX6ZZNB8aPR1lNFqAJDFxXhMwUqB+pZedh ANmI7RVEVINMOf8gmzdrvewI1GT8XUThX/dzPdB95uVAf9ADq/jlCWhvho3q9E3LaZ 39rjy6EG1L+lsGvwke2O06YuIB5q3CKf4XaWH3xw= Message-ID: Date: Fri, 1 Apr 2022 10:12:49 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing libraries to [Components] in DSC To: devel@edk2.groups.io, chasel.chiu@intel.com Cc: "Desimone, Nathaniel L" , "Gao, Liming" , "Dong, Eric" References: <20220323012736.9609-1-mikuback@linux.microsoft.com> From: "Michael Kubacki" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Thanks for the review. Can you please merge this soon if there are no concerns? On 3/23/2022 2:15 AM, Chiu, Chasel wrote: > > Reviewed-by: Chasel Chiu > >> -----Original Message----- >> From: mikuback@linux.microsoft.com >> Sent: Wednesday, March 23, 2022 9:28 AM >> To: devel@edk2.groups.io >> Cc: Chiu, Chasel ; Desimone, Nathaniel L >> ; Gao, Liming >> ; Dong, Eric >> Subject: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing >> libraries to [Components] in DSC >> >> From: Michael Kubacki >> >> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3619 >> >> Adds libraries implemented in MinPlatformPkg to the [Components] >> section in MinPlatformPkg.dsc so they are included in the package build. >> >> Cc: Chasel Chiu >> Cc: Nate DeSimone >> Cc: Liming Gao >> Cc: Eric Dong >> Signed-off-by: Michael Kubacki >> --- >> Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc >> b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc >> index 0f47182c2647..a8373a4ecb37 100644 >> --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc >> +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc >> @@ -211,6 +211,13 @@ [Components] >> >> MinPlatformPkg/Library/BaseVariableReadLibNull/BaseVariableReadLibNull. >> inf >> >> MinPlatformPkg/Library/SmmVariableReadLib/StandaloneMmVariableRead >> Lib.inf >> >> MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneMmVariableWri >> teLib.inf >> + MinPlatformPkg/Library/PeiVariableReadLib/PeiVariableReadLib.inf >> + >> + >> MinPlatformPkg/Library/DxeRuntimeVariableReadLib/DxeRuntimeVariableR >> ea >> + dLib.inf >> + >> MinPlatformPkg/Library/DxeRuntimeVariableWriteLib/DxeRuntimeVariable >> Wr >> + iteLib.inf >> + >> MinPlatformPkg/Library/SmmVariableReadLib/TraditionalMmVariableRead >> Lib >> + .inf >> + >> MinPlatformPkg/Library/SmmVariableWriteLib/TraditionalMmVariableWrit >> eL >> + ib.inf >> + >> MinPlatformPkg/Library/BaseLargeVariableLib/BaseLargeVariableReadLib.i >> + nf >> + MinPlatformPkg/Library/BaseLargeVariableLib/BaseLargeVariableWriteLib. >> + inf >> >> [BuildOptions] >> *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES >> -- >> 2.28.0.windows.1 > > > > >