From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.52]) by mx.groups.io with SMTP id smtpd.web10.7101.1634125475666280100 for ; Wed, 13 Oct 2021 04:44:35 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amd.com header.s=selector1 header.b=CP34wAB6; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.94.52, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xnge0QZKPSPjvUiE9bNj1M7NN7aDJiCdjtRktY8tO5oyiL7ZTB4RfAoQp03CiDi9WMDYiX59/Cb4Ps7YPtlDvP+Duqp8qkqGNLWDaJtugDZAgaZEWLrupbbGQdthJPWi1atC7i818jx5wfgqshAp0zz174a6hgEL3of68MiveOaWik7oVXBvG/EyyCg9KjB9NVpN+S7T7LWmISj6BuJ5g+LYYFvvjuJ26zbEv1oOtHMWU6Suq/+H3QmSBuH7zPrDCa8/tLZyVUqL1dEh5QlhkzsFXeF/D0GiRLFZGnGxlguU5Nr6k8uyRLEkhztEPUMIpZKocr9U7MgNi7nLeWZeuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OL6tawHhyP2E7A1DWkj43YwVvmyOON7Xz3MAgJ/Q7uY=; b=mu3o9aIKlq5lwMQJnEXeeah/ZM7KzwmDwu4U1MaptylbOaaighcCsiST9oyb9ATIwy+zR2aWfpKRYHBHpkWpKZFH5CnZI6R8WO+lPyE+//fBbKH/HZC3AWECk+uImRRCXC6apf7EEHrLuH5utkWq37yAy0SdnGJuhVcX7R+My4ucaCmx2OzTol7KKFj8VO2n+/88gNj3q5eP6U3V3Icbu5RiFlqVwnP5LNw6ocFo0VBn/7juAOubQ4k4xh7QRFBKBc1NC6RkY6TWHaTNAnaUtNKLsgIuZRx8KnNCc/vk8oT5dMvP9CoBsWQHOxqrDtghk+THkwNd8/gui9E6Pdxang== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OL6tawHhyP2E7A1DWkj43YwVvmyOON7Xz3MAgJ/Q7uY=; b=CP34wAB6Qg7R10kO27c1mLoqNdhlnFNa2nrh+vS8/7nHZG+XvKJrHpK4RJsbc+7HBU4ieBwhSD0FpA24m/0uelGLiIvnN1hSExDzt7zvGIaM6nvxqW1ucFDl9K10xGWI1Ze1SujLuQx0hiTDgFyhBwlJB2HBv9w6mgjS1HcFE/w= Authentication-Results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=amd.com; Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SN6PR12MB2782.namprd12.prod.outlook.com (2603:10b6:805:73::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Wed, 13 Oct 2021 11:44:31 +0000 Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::78b7:7336:d363:9be3]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::78b7:7336:d363:9be3%6]) with mapi id 15.20.4587.026; Wed, 13 Oct 2021 11:44:31 +0000 CC: brijesh.singh@amd.com, Ard Biesheuvel , Jordan Justen , Erdem Aktas , James Bottomley , Jiewen Yao , Tom Lendacky Subject: Re: [edk2-devel] [PATCH V9 3/4] OvmfPkg: Add IntelTdxMetadata.asm To: devel@edk2.groups.io, kraxel@redhat.com, Min Xu References: <62bb7a8bf025bce78b012c8f92d59cbd203f3674.1634005437.git.min.m.xu@intel.com> <20211012072228.h3meki5hmw27fn32@sirius.home.kraxel.org> From: "Brijesh Singh" Message-ID: Date: Wed, 13 Oct 2021 06:44:28 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <20211012072228.h3meki5hmw27fn32@sirius.home.kraxel.org> X-ClientProxiedBy: SA9P221CA0007.NAMP221.PROD.OUTLOOK.COM (2603:10b6:806:25::12) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) Return-Path: brijesh.singh@amd.com MIME-Version: 1.0 Received: from Brijeshs-MacBook-Pro.local (165.204.77.11) by SA9P221CA0007.NAMP221.PROD.OUTLOOK.COM (2603:10b6:806:25::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend Transport; Wed, 13 Oct 2021 11:44:30 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c4a4d9b0-b4da-4363-8025-08d98e3ed1fb X-MS-TrafficTypeDiagnostic: SN6PR12MB2782: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2TzBf9zI6WNIg8FCV4hCPpexSB4fI9csyMpHxmiE2IPzAi4UDh/LOkn46VLvbPgln0MVaKQfhFkBKPmZ/dHIh+7o/Ez4OI5x4scn5RDX2QXyrPR5cdUrImxl1J86KfyPj7JuqkYKP/V9I+C70rl5R3CfhhlPLkPj22S7+24r6EydgzyqqFwX33Z8LwopYLt5/CGjbVHavh621u+3a4dYaF+FjzlvfV8h29OvDgHVf/ALpPGgsxluxq237iZkDy1Co5NsTjDws2uzopgpwyCgfmVcPv8VaYE9ej/yq4Kwd6B6CgbhPh9r1gAfCkMgQHbbfnUmO+moEXHDuSLqbKhHXOT2wAoexj1vkxIQaion2thohZ1riS4A0/jGs1NgDt+ywp2C/AHdKtxIiPjQxUaMDgN1F51SrNb+qQqW3Nih6V7IKVVDlZCMqYBGIlqJBTQt1Ay7W4mxLXhjFiHqSCqD5by9ucYICn36CwlI6wIBXc/Ib0K/79SKlw1AwrToluoeM37VTX91tEZJ67AIX6GWEIOk/TTzkY5SZ1HiaxHntFlBTQYRQdOx/MSoT4rPb2tu+jHg0Dg3HXwCYItpO+8GbWDTEqAptk7gdPEMg6KpVVv9Vk1KpIyFSwbzNNLJMZ03Y4DGHz3VTHG32oPE5zeDDanNI7leaPEYFH4XlVr7jA1TM4PlElkKoldVOiyy1n7nMqFK19lVfOtl4VoahODvtzpW3o3lY2wO+KOsqtN0j1aIv55MExpyy8J+34Za1a8pXgLPG1ohRiaWUIC3UJ5sUFZeKtUBRCMXajvvcS/b9rzMcOvHlTIsHhUtCSZElJJpZFNdT8NAEirhyQpEd6210w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2718.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(5660300002)(31686004)(508600001)(38100700002)(31696002)(45080400002)(316002)(26005)(54906003)(2616005)(44832011)(8936002)(956004)(83380400001)(86362001)(2906002)(8676002)(66556008)(66946007)(6506007)(6486002)(66476007)(4326008)(6512007)(36756003)(53546011)(6916009)(966005)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6QH0N38iju1wDvT3SonkwRXDXw3Yw2Wh55S5sN7uuXGiz7CgSwM02oW6GmQ2?= =?us-ascii?Q?aWLRwhWWbIGfKm22IRFFTo3il6oOSnWdL/zYVLCw/cbMzKIDVE7eCugWJBu0?= =?us-ascii?Q?SI04iMZZIPqb2eJgeikQ/dxpKlgp6hR/QrnGM9YMQKso5g+2G5rZXNKM2PWE?= =?us-ascii?Q?U0ecD0zANJHpkQy6WugAjOaNnt4/5WO5GyEh5LNLYPi1CSP1v+JA7SiuU9Ow?= =?us-ascii?Q?n+OqsUGY/f1eLtBp3kv8ppkuAIuxMd9SPD/+IDNop6yUPEMAHamXb8Mi45m/?= =?us-ascii?Q?PgZLbRcCuIxTGbGNbsuT+nfe6uscOUnqoMtFCZKRw0qIfJRU4rHDcRin/sb0?= =?us-ascii?Q?09/gkGqowDwmljGnFGV1UesYmjeQ9dwZnjN9Fd/L0eSwnAZBAx3dLqCmNuul?= =?us-ascii?Q?k26YZHooUfHnkWAGVLxJf3NBmbmFwrGMFZn0oNwAdqdx6QudyZMqr1JfQJjO?= =?us-ascii?Q?BI7pm4nKmt5QWf00ozYTGDoby0mdllE/gDprDT3iWpcFhpFzUskM4X30eMT4?= =?us-ascii?Q?YH0lw70QgEk4V5ntDSD2Sj06qN5KTJNgLN7vJdi1+nIZF0wiAetXKyJXt1Ae?= =?us-ascii?Q?TplAKM/Wda3UUPyBl3TqiGqt9s9nZFkR8O9YTCWXtpXb52MIZKaUQs+i/MYc?= =?us-ascii?Q?UGdXt35RDLbMmcfgPoM60kxKayrEN4Yi40u81XTwJvLtHlknP2IWW1SpLA57?= =?us-ascii?Q?XSn33ed0geFMjEuEeejWtNt3Ask2EC9dTseQnfv+JMvZs3+eqBoYJ8ad2jF5?= =?us-ascii?Q?3uTouadbb7h1cEU1hXLDJ9qJ/X277mB+0XeMpOye8BdLcLMkt0rsbJ6SqB77?= =?us-ascii?Q?jOltNtatAD67FPyNipia4rhfS55f0o+5GC9YoUMj78a9rR+t4Blpc8Se6CBB?= =?us-ascii?Q?r+dhqFjAbD9GSp7X/XG41bnRfSlj1Y8KXwqicRBuvuhOz1dYuKWwy89sTsZE?= =?us-ascii?Q?XSrXpgmr40pz1wBvyjCKJK/lz1I2vViYCtIKJDSKHAKnmEs6D6LpEwlkuAlP?= =?us-ascii?Q?Cojvtu7qUM7vjApnHnx5uko8ZQba4Z9CrSX7jekbpt/MqbThbytaWMk1IneN?= =?us-ascii?Q?Qu9N3GRO8G+LJ0zifkidjxwcKs0MDo2W8xxUbHC8HsWoqsM5CtW2Ehr/hvB6?= =?us-ascii?Q?d/jqw7zKjlqOcqdr54QlYfox6yYR3bpoMCkIfnjnXm35zKHpJ4Lmdt0kNL0E?= =?us-ascii?Q?JR3rItV42xLgAvi+CmwalgrAFpfqkvhSVjgwnYEsiz7XuHvF4/V0dQDnlQLq?= =?us-ascii?Q?gSg1VacB1gGzE9/BjEJzSd/3AC9iPupvOK2AGOG5d91sqnJGzeysTQurj8+P?= =?us-ascii?Q?0mc3cT8vzLDDGOfew8lYhxFC?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c4a4d9b0-b4da-4363-8025-08d98e3ed1fb X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 11:44:31.2652 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /Wz+RWjCUeYJu1Yy+LV7erw1JvbIHSEfVSkO8Ui7DFahwfr9BBLtiIVauKe8t+m+kABYu1P9EqJDRUf7Khr5uw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2782 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-US On 10/12/21 12:22 AM, Gerd Hoffmann via groups.io wrote: > Hi, > >> +; - Type field means this section is of BFV. This field is designed for= the >> +; purpose that in some case host VMM may do some additional processin= g based >> +; upon the section type. TdHob section is an example. Host VMM pass t= he >> +; physical memory information to the guest firmware by writing the da= ta in >> +; the memory region designated by TdHob section. > Brijesh? What are your plans? Do you want use this too? Based on the previous comment by Jiewen it seems TDX folks want to have a separate metadata for flexibility. In the v9, I am creating metadata just for the SEV with a different GUID. Basically same as version 8 but now the number of descriptors will be smaller (since we focus on SEV-SNP). thanks=C2=A0 > If so, then the section types need some more structure. I think best > would be reserve blocks, something like 0x00 -> 0xff common types (bfv, > cfv, temp_mem), 0x100 -> 0x1ff tdx (td_hob), 0x200 -> 0x2ff sev (cpuid, > secrets, ...). > > take care, > Gerd > > > >=20 > >