From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65]) by mx.groups.io with SMTP id smtpd.web08.22098.1628512844596187521 for ; Mon, 09 Aug 2021 05:40:45 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@posteo.de header.s=2017 header.b=sKIJiRz0; spf=pass (domain: posteo.de, ip: 185.67.36.65, mailfrom: mhaeuser@posteo.de) Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id E1D56240027 for ; Mon, 9 Aug 2021 14:40:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1628512841; bh=FBrWTPkXKRh32/6C9xlaE58gqdVQCDRdALU0w7R+rKI=; h=Subject:To:Cc:From:Date:From; b=sKIJiRz0qERHbcRoLQqU+r3SidRdWFSwmt6aFrNkL+yqFHdWZep2bmAr3BwyEAcyG HE1q8b3AFaFADCSFGp//l5hTL2+un+zUvl7z0KTXQCkAsvu1An6oTQaaIhWdofgAYR pcNQfcMuC0qgo41o9hr1lRVYEJoTDknxVjycOX9uCASaDbPzeXutfCOAcrG2eP6i91 ySLyezL3iiDBFfIYgeMnPwjxkwKSvDAlzusjX7hLbMvbusw+mHu5sb2QDlN6u9+omU e6TV/s+E1hETXXkxB6ZfSWdhbftoouIoCcOdEoWIpuxAhbmh2/l/60MPlJg/NjYMQE MR1zLyX+bFK4A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Gjwfc3qD3z9rxM; Mon, 9 Aug 2021 14:40:40 +0200 (CEST) Subject: Re: [edk2-devel] [PATCH v2 4/7] ArmPkg/DefaultExceptionHandlerLib: Check DebugImageInfoTable type safely To: devel@edk2.groups.io, ardb@kernel.org Cc: Leif Lindholm , Ard Biesheuvel , Vitaly Cheptsov References: <961f3436a2b52a67aa6c8cd45c75c76835a3a5d8.1628502345.git.mhaeuser@posteo.de> From: =?UTF-8?B?TWFydmluIEjDpHVzZXI=?= Message-ID: Date: Mon, 9 Aug 2021 12:40:40 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: quoted-printable On 09/08/2021 13:55, Ard Biesheuvel wrote: > On Mon, 9 Aug 2021 at 11:51, Marvin H=C3=A4user wrot= e: >> C does not allow casting to or dereferencing incompatible pointer >> types. Use the ImageInfoType member of the union first to determine >> the data type before dereferencing NormalImage. >> >> Cc: Leif Lindholm >> Cc: Ard Biesheuvel >> Cc: Vitaly Cheptsov >> Signed-off-by: Marvin H=C3=A4user > Hi Marvin, > > Could you please organize your patches into a consistent series, > include a cover letter and cc me on everything? Hey Ard, It's a series and there is a cover letter at:=20 https://edk2.groups.io/g/devel/topic/patch_v2_0_7_fix_various/84764899?p=3D= ,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,84764899 The mails from yesterday can certainly be discarded, for some reason=20 format-patch did not number the patches without the argument. The mails from today are numbered and there is a cover letter, but for=20 some reason the threading is all wrong in Thunderbird for me. All=20 subsequent patches have the "In-Reply-To" header in the patch files, I=20 think it is supposed to work off of that? Is threading broken for you as=20 well? Any idea what could have gone wrong? I will create a V3 with you CC'd on all patches once I understand=20 everything that went wrong. Is it normal to CC all people from each=20 patch on all patches of a series? Thanks and so sorry for the hassle! Best regards, Marvin > I am going to disregard anything you sent yesterday and today, as it > is a bit of a jumble. > > Thanks, > Ard. > > >> --- >> ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerUefi.= c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionH= andlerUefi.c b/ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHa= ndlerUefi.c >> index e9fea4038252..9befb6d4db9b 100644 >> --- a/ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerU= efi.c >> +++ b/ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerU= efi.c >> @@ -51,8 +51,8 @@ GetImageName ( >> >> Address =3D (CHAR8 *)(UINTN)FaultAddress; >> for (Entry =3D 0; Entry < DebugTableHeader->TableSize; Entry++, Debu= gTable++) { >> - if (DebugTable->NormalImage !=3D NULL) { >> - if ((DebugTable->NormalImage->ImageInfoType =3D=3D EFI_DEBUG_IMAG= E_INFO_TYPE_NORMAL) && >> + if (DebugTable->ImageInfoType !=3D NULL) { >> + if ((*DebugTable->ImageInfoType =3D=3D EFI_DEBUG_IMAGE_INFO_TYPE_= NORMAL) && >> (DebugTable->NormalImage->LoadedImageProtocolInstance !=3D N= ULL)) { >> if ((Address >=3D (CHAR8 *)DebugTable->NormalImage->LoadedImag= eProtocolInstance->ImageBase) && >> (Address <=3D ((CHAR8 *)DebugTable->NormalImage->LoadedIma= geProtocolInstance->ImageBase + DebugTable->NormalImage->LoadedImageProtoco= lInstance->ImageSize))) { >> -- >> 2.31.1 >> > >=20 > >