From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2C07ED811C4 for ; Mon, 26 Feb 2024 14:01:34 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=MJiY4S6m5a/NVjIL4gLPxA5VF+l8mg2oanKmctlGvas=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708956092; v=1; b=F/kOf0az3p3FQ7dAzxNdRDQf/vvYc/yn7HTe1KFm5wsfffZPIMUqPg/FoVpMKBeYQvFxtbaI CN8v4TH/btwzOa8lWRkP6dcdB0kkCMNLw/YdPnacio835tQLEHw39MBT3fMlxvqLT3W37Rc2kHA bypRB0AUpY4RcAB5DEsitm0E= X-Received: by 127.0.0.2 with SMTP id tf2jYY7687511xnxFK9azN7P; Mon, 26 Feb 2024 06:01:32 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.20684.1708956092155377192 for ; Mon, 26 Feb 2024 06:01:32 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-266-7gY2j4eOOK27atNvO0QGqA-1; Mon, 26 Feb 2024 09:01:28 -0500 X-MC-Unique: 7gY2j4eOOK27atNvO0QGqA-1 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BB19B10AF988; Mon, 26 Feb 2024 14:01:27 +0000 (UTC) X-Received: from [10.39.194.99] (unknown [10.39.194.99]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BA3C71816; Mon, 26 Feb 2024 14:01:26 +0000 (UTC) Message-ID: Date: Mon, 26 Feb 2024 15:01:25 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v3 6/6] UefiCpuPkg/MpInitLib: return early in GetBspNumber() To: devel@edk2.groups.io, kraxel@redhat.com Cc: Ray Ni , Rahul Kumar , Oliver Steffen References: <20240222160106.686484-1-kraxel@redhat.com> <20240222160106.686484-7-kraxel@redhat.com> From: "Laszlo Ersek" In-Reply-To: <20240222160106.686484-7-kraxel@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: VhGqkvzNQVMZg8V0pGl21OOhx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="F/kOf0az"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) On 2/22/24 17:01, Gerd Hoffmann wrote: > After finding the BSP Number return the result instead of > continuing to loop over the remaining processors. >=20 > Suggested-by: Laszlo Ersek > Signed-off-by: Gerd Hoffmann > --- > UefiCpuPkg/Library/MpInitLib/MpLib.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) >=20 > diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c b/UefiCpuPkg/Library/Mp= InitLib/MpLib.c > index 4b6d6d02b027..2051554207dc 100644 > --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c > +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c > @@ -1903,15 +1903,13 @@ GetBspNumber ( > ) > { > UINT32 ApicId; > - UINT32 BspNumber; > UINT32 Index; > CONST MP_HAND_OFF *MpHandOff; > =20 > // > // Get the processor number for the BSP > // > - BspNumber =3D MAX_UINT32; > - ApicId =3D GetInitialApicId (); > + ApicId =3D GetInitialApicId (); > =20 > for (MpHandOff =3D FirstMpHandOff; > MpHandOff !=3D NULL; > @@ -1919,14 +1917,13 @@ GetBspNumber ( > { > for (Index =3D 0; Index < MpHandOff->CpuCount; Index++) { > if (MpHandOff->Info[Index].ApicId =3D=3D ApicId) { > - BspNumber =3D MpHandOff->ProcessorIndex + Index; > + return MpHandOff->ProcessorIndex + Index; > } > } > } > =20 > - ASSERT (BspNumber !=3D MAX_UINT32); > - > - return BspNumber; > + ASSERT (FALSE); > + return 0; > } > =20 > /** There's a somewhat sneaky change in here: if we fail to find the BSP, then (beyond tripping an assert like before) we now return 0, rather than MAX_UINT32. However, that's arguably more sensible, even. Reviewed-by: Laszlo Ersek Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115965): https://edk2.groups.io/g/devel/message/115965 Mute This Topic: https://groups.io/mt/104510913/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-