From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 603C99412CC for ; Tue, 16 Jan 2024 06:18:51 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=7QtidcBjrShctUR6CmCp0HNbP59LgaWHTixkpAKHOAE=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1705385930; v=1; b=YWAVDGQygazPX7sZdjNwUR/s6S2JwOmoAigyBAmVhpq44zrAjWMjyCUvzz3FqhAWnHEmbh7k rm7UBuLL1PD6rJmBxI83b0PF5G1fthZ72ukLF4Q1eX2QHTUcBD0OrKLTUuxwLsZDWVfDD7ceUM1 98aiXveKUl7j3jA8s3oPHj2Y= X-Received: by 127.0.0.2 with SMTP id o3Q5YY7687511x4QnACENDqE; Mon, 15 Jan 2024 22:18:50 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.72807.1705307530367795001 for ; Mon, 15 Jan 2024 00:32:10 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-516-SRsj2GUdNdq78Tjb9NvKvw-1; Mon, 15 Jan 2024 03:32:04 -0500 X-MC-Unique: SRsj2GUdNdq78Tjb9NvKvw-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 91DCF811E9E; Mon, 15 Jan 2024 08:32:03 +0000 (UTC) X-Received: from [10.39.193.170] (unknown [10.39.193.170]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 66E28112131D; Mon, 15 Jan 2024 08:32:01 +0000 (UTC) Message-ID: Date: Mon, 15 Jan 2024 09:32:01 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v7 23/37] ArmVirtPkg: Move the FdtSerialPortAddressLib to OvmfPkg To: Chao Li , devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Gerd Hoffmann , Jiewen Yao References: <20240112082153.3284189-1-lichao@loongson.cn> <20240112082522.3298990-1-lichao@loongson.cn> From: "Laszlo Ersek" In-Reply-To: <20240112082522.3298990-1-lichao@loongson.cn> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: qoW2ppF1enWNqFn6c0EtHAK1x7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=YWAVDGQy; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 1/12/24 09:25, Chao Li wrote: > Move the FdtSerialPortAddressLib to Ovmfpkg so that other ARCH can > easily use it. >=20 > Build-tested only (with "ArmVirtQemu.dsc"). >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4584 >=20 > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Sami Mujawar > Cc: Gerd Hoffmann > Cc: Jiewen Yao > Cc: Laszlo Ersek > Signed-off-by: Chao Li > --- > ArmVirtPkg/ArmVirt.dsc.inc | 2 +- > .../Include/Library/FdtSerialPortAddressLib.h | 0 > .../Library/FdtSerialPortAddressLib/FdtSerialPortAddressLib.c | 0 > .../FdtSerialPortAddressLib/FdtSerialPortAddressLib.inf | 2 +- > OvmfPkg/OvmfPkg.dec | 4 ++++ > 5 files changed, 6 insertions(+), 2 deletions(-) > rename {ArmVirtPkg =3D> OvmfPkg}/Include/Library/FdtSerialPortAddressLib= .h (100%) > rename {ArmVirtPkg =3D> OvmfPkg}/Library/FdtSerialPortAddressLib/FdtSeri= alPortAddressLib.c (100%) > rename {ArmVirtPkg =3D> OvmfPkg}/Library/FdtSerialPortAddressLib/FdtSeri= alPortAddressLib.inf (90%) >=20 > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > index 9b23ef97ec..2bc6a29eb1 100644 > --- a/ArmVirtPkg/ArmVirt.dsc.inc > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > @@ -122,7 +122,7 @@ > # ARM PL011 UART Driver > PL011UartLib|ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf > SerialPortLib|ArmVirtPkg/Library/FdtPL011SerialPortLib/FdtPL011SerialP= ortLib.inf > - FdtSerialPortAddressLib|ArmVirtPkg/Library/FdtSerialPortAddressLib/Fdt= SerialPortAddressLib.inf > + FdtSerialPortAddressLib|OvmfPkg/Library/FdtSerialPortAddressLib/FdtSer= ialPortAddressLib.inf > =20 > PeCoffExtraActionLib|ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeC= offExtraActionLib.inf > #PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/Base= PeCoffExtraActionLibNull.inf > diff --git a/ArmVirtPkg/Include/Library/FdtSerialPortAddressLib.h b/OvmfP= kg/Include/Library/FdtSerialPortAddressLib.h > similarity index 100% > rename from ArmVirtPkg/Include/Library/FdtSerialPortAddressLib.h > rename to OvmfPkg/Include/Library/FdtSerialPortAddressLib.h > diff --git a/ArmVirtPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddr= essLib.c b/OvmfPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddressLib.= c > similarity index 100% > rename from ArmVirtPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddre= ssLib.c > rename to OvmfPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddressLib= .c > diff --git a/ArmVirtPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddr= essLib.inf b/OvmfPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddressLi= b.inf > similarity index 90% > rename from ArmVirtPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddre= ssLib.inf > rename to OvmfPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddressLib= .inf > index ae6d0d374b..e27742e9fa 100644 > --- a/ArmVirtPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddressLib.= inf > +++ b/OvmfPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddressLib.inf > @@ -18,9 +18,9 @@ > FdtSerialPortAddressLib.c > =20 > [Packages] > - ArmVirtPkg/ArmVirtPkg.dec > EmbeddedPkg/EmbeddedPkg.dec > MdePkg/MdePkg.dec > + OvmfPkg/OvmfPkg.dec > =20 > [LibraryClasses] > BaseLib > diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec > index 7bc2bf1674..13e69e6648 100644 > --- a/OvmfPkg/OvmfPkg.dec > +++ b/OvmfPkg/OvmfPkg.dec > @@ -29,6 +29,10 @@ > ## @libraryclass Verify blobs read from the VMM > BlobVerifierLib|Include/Library/BlobVerifierLib.h > =20 > + ## @libraryclass FdtSerialPortAddressLib > + # > + FdtSerialPortAddressLib|Include/Library/FdtSerialPortAddressLib.h > + > ## @libraryclass Loads and boots a Linux kernel image > # > LoadLinuxLib|Include/Library/LoadLinuxLib.h IIUC, the library class is not removed from "ArmVirtPkg.dec"; please do that as well, in the same patch. Otherwise, the patch looks OK to me. Thanks Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113807): https://edk2.groups.io/g/devel/message/113807 Mute This Topic: https://groups.io/mt/103679474/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-