From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by mx.groups.io with SMTP id smtpd.web10.12156.1597331585175008952 for ; Thu, 13 Aug 2020 08:13:05 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=ym7qmV4t; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.128.66, mailfrom: pete@akeo.ie) Received: by mail-wm1-f66.google.com with SMTP id k20so5362491wmi.5 for ; Thu, 13 Aug 2020 08:13:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=qbwuXApL/xgIC7DBn0o385srfARXkXLUTuIs3igpH8Q=; b=ym7qmV4tC4+AH9wgARNqdSHZrTuP+JbO2EuHYK+6q2mcjsqczFfTvjUR/gKsAjOzGD IZC/VntG5rnxjokbqKBJwlymHdimdNfev9FdBZWTEmyJbYeyaMDK5qVb+XhmKNkA2E3K Iwb/zWrJ3u6hlV2GQ1lx1ioyuJawipfrMQ110PV3UbqLREEuSDMlXT08ZH5jEZqQvC4P bJ170emZY0Mf5io2PxLeuQ6J7o8An42nGJHm6L5BHaQCG0jVjnmdPL7wkoMWY401nJIM Ib608ReAkoJKD5SqlZqH/KaktggalSUazYbSl3wdfd2aywJ1VPH6tIbtooyqW5z/+fC+ g3eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qbwuXApL/xgIC7DBn0o385srfARXkXLUTuIs3igpH8Q=; b=kdK/zt1qtUZZarvN5oml80LpVNY1K0SkuSEGaTcK5zgr5TP9rCwM+WZ9IVrFJuJMll TqUBpST3WmAcgFHgMnF9t4Hx9EdeIDIfU3gRpuzQPRgmAjgYB0RLgN9THqkXG3FAMzKj jk4I7aJ+GrR95UOGj0niAse+5mqZJwRjQ6Dd7LNorknVh5ok/Kg8RyXWh3PnEV6fcrLv 4jymEkOVD36cmaFGKincmUCYN/pBgcda0DEKnbXn1FOmCZW7P+V5i4nr+58UoNiTL3cX wAA9Cz2c8pyjj/j8dbPdOAgA5jdKVoBRLfnWxTrnuxgGRf2bngc9TiC6QPQ4Dq3DgH+7 J5NA== X-Gm-Message-State: AOAM533pjOeOAQjIOygp3D/KR6M6+q5d778gqN0SYCiFWdTDmfPfBd6+ xCYOOLHZAZU1eRwZZc+DXhP9bQ== X-Google-Smtp-Source: ABdhPJw3Q5P1ooYt2sumO+xfjtSjlELqzFpByAcXBNV9W3rkWmwHWqhSR5QszvDJDm2eJtlmU84C4A== X-Received: by 2002:a1c:de88:: with SMTP id v130mr4650077wmg.98.1597331583772; Thu, 13 Aug 2020 08:13:03 -0700 (PDT) Return-Path: Received: from [10.0.0.122] ([84.203.48.42]) by smtp.googlemail.com with ESMTPSA id y145sm10551435wmd.48.2020.08.13.08.13.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Aug 2020 08:13:02 -0700 (PDT) Subject: Re: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix DBG2 UART namespace reference To: Samer El-Haj-Mahmoud , devel@edk2.groups.io Cc: Leif Lindholm , Andrei Warkentin , Ard Biesheuvel References: <20200813142733.8727-1-Samer.El-Haj-Mahmoud@arm.com> From: "Pete Batard" Message-ID: Date: Thu, 13 Aug 2020 16:13:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200813142733.8727-1-Samer.El-Haj-Mahmoud@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 2020.08.13 15:27, Samer El-Haj-Mahmoud wrote: > The UART namespace reference in DBG2 is incorrect. Fix to point to the > correct name. > > This fixes the certification failure reported by FWTS tests at: > https://github.com/pftf/RPi4/issues/69 > > Cc: Leif Lindholm > Cc: Pete Batard > Cc: Andrei Warkentin > Cc: Ard Biesheuvel > Signed-off-by: Samer El-Haj-Mahmoud > --- > Platform/RaspberryPi/AcpiTables/Dbg2.aslc | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Platform/RaspberryPi/AcpiTables/Dbg2.aslc b/Platform/RaspberryPi/AcpiTables/Dbg2.aslc > index c35b15693f5a..e3f2adae7e21 100644 > --- a/Platform/RaspberryPi/AcpiTables/Dbg2.aslc > +++ b/Platform/RaspberryPi/AcpiTables/Dbg2.aslc > @@ -3,7 +3,7 @@ > * Debug Port Table (DBG2) > * > * Copyright (c) 2019, Pete Batard > - * Copyright (c) 2012-2016, ARM Limited. All rights reserved. > + * Copyright (c) 2012-2020, ARM Limited. All rights reserved. > * > * SPDX-License-Identifier: BSD-2-Clause-Patent > * > @@ -21,13 +21,13 @@ > > #define RPI_DBG2_NUM_DEBUG_PORTS 1 > #define RPI_DBG2_NUMBER_OF_GENERIC_ADDRESS_REGISTERS 1 > -#define RPI_DBG2_NAMESPACESTRING_FIELD_SIZE 10 > +#define RPI_DBG2_NAMESPACESTRING_FIELD_SIZE 15 > > #if (RPI_MODEL == 4) > #define RPI_UART_INTERFACE_TYPE EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_PL011_UART > #define RPI_UART_BASE_ADDRESS BCM2836_PL011_UART_BASE_ADDRESS > #define RPI_UART_LENGTH BCM2836_PL011_UART_LENGTH > -#define RPI_UART_STR { '\\', '_', 'S', 'B', '.', 'U', 'R', 'T', '0', 0x00 } > +#define RPI_UART_STR { '\\', '_', 'S', 'B', '.', 'G', 'D', 'V', '0', '.', 'U', 'R', 'T', '0', 0x00 } > #else > #define RPI_UART_INTERFACE_TYPE EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_BCM2835_UART > #define RPI_UART_BASE_ADDRESS BCM2836_MINI_UART_BASE_ADDRESS > @@ -35,7 +35,7 @@ > // > // RPI_UART_STR should match the value used Uart.asl > // > -#define RPI_UART_STR { '\\', '_', 'S', 'B', '.', 'U', 'R', 'T', 'M', 0x00 } > +#define RPI_UART_STR { '\\', '_', 'S', 'B', '.', 'G', 'D', 'V', '0', '.', 'U', 'R', 'T', 'M', 0x00 } > #endif > > typedef struct { > Reviewed-by: Pete Batard