From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.11367.1638465312132273621 for ; Thu, 02 Dec 2021 09:15:12 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=dWOJ2upg; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [10.0.0.19] (c-73-27-179-174.hsd1.fl.comcast.net [73.27.179.174]) by linux.microsoft.com (Postfix) with ESMTPSA id BBA9C20E65DD; Thu, 2 Dec 2021 09:15:10 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com BBA9C20E65DD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1638465311; bh=vZBsZ+NtMMp2RWuBxsKjK3gMxor2KKIPV19NL0lzx9U=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=dWOJ2upgbthCFSVDIl0XFaDZ1XNXs4Z+uF//n7DYlxNntbfhwKAPcDsEJd5PgtaC0 Kc+5Fc0jJuszXBI9yYrZ50+kTZfo+W8o3xF8soGj6O3UtJhyRMPdI5wMAaHTYoDBLq ME/vr6UI991DtZAVNzlRXNjAYR2Y8Bo+wNhc/0Pw= Message-ID: Date: Thu, 2 Dec 2021 12:15:10 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4 To: Gerd Hoffmann Cc: devel@edk2.groups.io, michael.d.kinney@intel.com, "Chang, Abner" , "Wang, Jian J" , Michael Kubacki , "Andrew Fish (afish@apple.com)" , Leif Lindholm References: <7d404a85-564d-d86f-1dd6-b01e2b7dc68c@linux.microsoft.com> <20211202110044.cdff4pp7nhecgpyw@sirius.home.kraxel.org> <54438448-46dc-72cb-2ee0-4c2356437cc6@linux.microsoft.com> <20211202162339.sgdnjeac255mbvn6@sirius.home.kraxel.org> From: "Michael Kubacki" In-Reply-To: <20211202162339.sgdnjeac255mbvn6@sirius.home.kraxel.org> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Thank you for clarifying. This case is more reasonable to me since the files are auto generated and not ported into edk2. There is an option to bring files like this in as a new submodule but I understand why that might not be desirable and would be disruptive to the current process. If there's no objection, I'll add an option to exclude paths within a package in a v6 patch of the plugin and leave this to maintainer discretion. I just ask that the spirit of consistent formatting be considered when making these decisions. Regards, Michael On 12/2/2021 11:23 AM, Gerd Hoffmann wrote: > On Thu, Dec 02, 2021 at 10:33:14AM -0500, Michael Kubacki wrote: >> Hi Gerd, >> >> To help me understand which files you're specifically referring to, can you >> please point them out from this commit? Or provide additional details? >> >> https://github.com/tianocore/edk2/pull/2229/commits/50654dfe5785964c9ae72961d13a50b26af77794 >> >> CryptoPkg/Library/Include/openssl/opensslconf.h is currently formatted. > > Yes, that one, and there is another in CryptoPkg/Library/Include/crypto/ > The switch to openssl 3.0 will add more of those files[1] > > They are generated from openssl source code, > CryptoPkg/Library/OpensslLib/process_files.pl handles that. > > I think the two reasonable options to deal with that are: > > (1) exclude those files from formating, or > (2) call uncrustify in process_files.pl to reformat them > each time they are generated. > > Given that these files will never be edited manually my personal > preference would be (1). > > take care, > Gerd > > [1] wip branch @ https://github.com/kraxel/edk2/commits/openssl3 >