Re: [PATCH V2] Change EDK II to BSD+Patent License

[Laszlo Ersek <lersek@redhat.com>]

Hi Mike,

On 03/23/19 03:25, Kinney, Michael D wrote:
> Hello,
>
> New in V2
> =========
> * Remove Cc lines from commit messages
> * Remove branch reference from commit messages
> * Change license in 2 files missed in OvmfPkg
> * Update OvmfPkg/License.txt to BSD+Patent as the default license
> * Move the portions of Contributions.txt in the root of edk2 to
>   Readme.md in the root of edk2 that describe how to contribute
>   along with the commit message format.
> * Add to Readme.md in the root of edk2 that Signed-off-by means that
>   the contributor certifies compliance to the Developer's Certificate
>   of Origin 1.1.  https://developercertificate.org
> =========
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1373
>
> This change is based on the following emails:
>   https://lists.01.org/pipermail/edk2-devel/2019-February/036260.html
>   https://lists.01.org/pipermail/edk2-devel/2018-October/030385.html
>
> RFCs with detailed process for the license change:
>   V3: https://lists.01.org/pipermail/edk2-devel/2019-March/038116.html
>   V2: https://lists.01.org/pipermail/edk2-devel/2019-March/037669.html
>   V1: https://lists.01.org/pipermail/edk2-devel/2019-March/037500.html
>
> I have posted the patch series for review on the following branch
> using edk2-stable201903 as the base for the patch series.
>
>   https://github.com/mdkinney/edk2/tree/Bug_1373_BsdPatentLicense_V2
>
> The commits in patch series can be viewed here:
>
>   https://github.com/mdkinney/edk2/commits/Bug_1373_BsdPatentLicense_V2
>
> The patch series has one patch per package along with a few patches
> to update the license information in the root of the edk2 repository
> as described in the RFC V3.
>
> Due to the size of the patch series, I prefer to not send the
> patch emails.  Instead, please perform code reviews using content
> from the branch.
>
> All EDK II package maintainers and package reviewers should provide
> review feedback for their packages.  The critical part of the review
> is:
> 1) Any changes that cause build breaks or logic changes.  These code
>    changes are intended to only modify license contents in comment
>    blocks.
> 2) Any file that has been changed to BSD+Patent, but should remain
>    with the current license.
> 3) Any file that that has not changed to BSD+Patent, but should be
>    changed to BSD+Patent.
>
> Feedback and Reviewed-by emails should identify the patch the feedback
> applies using the patch summary listed below.  The goal is to complete
> all reviews to support the commit of these patches on April 9, 2019.

Given that we've now entered the file addition/removal freeze:

  http://mid.mail-archive.com/E92EE9817A31E24EB0585FDF735412F5B9C772EE@ORSMSX112.amr.corp.intel.com

and that in that email you identify this (v2) series as "current", I'm
now reviewing v2.

Your v2 series was based on upstream commit 89910a39dcfd. The master
branch has since advanced to 7ed72121b753 however. Therefore, for this
review, I've rebased the three v2 patches listed below on top of commit
7ed72121b753 (i.e. on top the current master HEAD).


> f23540ea65 ArmVirtPkg: Replace BSD License with BSD+Patent License

I reviewed this patch most recently as part of your v1 series:

  http://mid.mail-archive.com/f2a32071-868a-e4fa-dcca-41bf28ba93aa@redhat.com

Content-wise, I'm in luck with the v2 review of this patch, because the
ArmVirtPkg directory tree is identical
- between your v1 patch set
- and your v2 patch set, rebased on top of current master.

Comparing the commit messages, I find:

- the RFC link list has been extended with the v3 RFC,
- the reference to your branch on github has been removed,
- the Cc: list in the commit message has been deleted.

Hence all my remarks have been observed. For this patch:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>


> e39d07266d OvmfPkg: Replace BSD License with BSD+Patent License

(While rebasing this patch from your v2 to current master, I ran into a
conflict, but that was easy to resolve and it's going to be covered
below anyway.)

Relative to v1:

(1) RFC link list updated, OK

(2) "Branch for review" removed, OK (v1/1.2)

(3) Cc: list removed, OK (v1/1.1)

(4) The "create-release.py" hunk doesn't apply any longer, so please
    remove it in v3. This conflict is due to us removing
    "create-release.py" altogether, for
    <https://bugzilla.tianocore.org/show_bug.cgi?id=1653>. (v1/2.1.1)

(5) At commit 7ed72121b753 (= current master HEAD), OvmfPkg contains the
    following new files:

      OvmfPkg/SioBusDxe/ComponentName.c
      OvmfPkg/SioBusDxe/SioBusDxe.c
      OvmfPkg/SioBusDxe/SioBusDxe.h
      OvmfPkg/SioBusDxe/SioBusDxe.inf
      OvmfPkg/SioBusDxe/SioBusDxe.uni
      OvmfPkg/SioBusDxe/SioService.c
      OvmfPkg/SioBusDxe/SioService.h

    All of them reference the URL
    <http://opensource.org/licenses/bsd-license.php>, so please convert
    them too, in v3.

(6) The set of small/trivial files, without any copyright notices, is
    unchanged; OK (v1/2.2.1)

(7) We now have a separate BZ for the MIT-covered files,
    <https://bugzilla.tianocore.org/show_bug.cgi?id=1654>. The set of
    those files is unchanged, OK. (v1/2.2.2)

(8) "OvmfPkg/License.txt" is converted in a new patch (below), I'll
    review it separately. So, for this patch, it's OK (v1/2.2.3)

(9) The files

      OvmfPkg/XenBusDxe/GrantTable.c
      OvmfPkg/XenPvBlkDxe/BlockFront.c

    are now correctly converted, OK. (v1/2.2.4)

Thus, in version 3, please fix (4) and (5).


> f9d59ccdc5 OvmfPkg: Change License.txt from 2-Clause BSD to BSD+Patent

For this patch:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>


Thanks!
Laszlo