From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web11.16551.1602779344505810738 for ; Thu, 15 Oct 2020 09:29:04 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QX8D6klr; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602779343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bjy5SeZx6mCQrzCrmGboh6et9f1RjPHaSpaDRMRQBms=; b=QX8D6klrktM1QZnwUY8JV5UOkZxWufqryilro6Ne482auPSCIinR28plOCidolfSjP7/m8 htkg5o4+TXKG/oORtgl3Sa47P0IZ3UA70SORSpFl8NurjilWAOQrhq5SPs/Qew1eqZJNVb P6LSF9L0AlC7Y5yBPrWcDTMNYKapTlY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-541-bv4rooSGMjebU_ilY9Vq8A-1; Thu, 15 Oct 2020 12:29:01 -0400 X-MC-Unique: bv4rooSGMjebU_ilY9Vq8A-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CFDD31084C84; Thu, 15 Oct 2020 16:28:59 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-119.ams2.redhat.com [10.36.113.119]) by smtp.corp.redhat.com (Postfix) with ESMTP id AA2CC76642; Thu, 15 Oct 2020 16:28:58 +0000 (UTC) Subject: Re: [PATCH 2/9] OvmfPkg/VmgExitLib: Set the SW exit fields when performing VMGEXIT To: Tom Lendacky , devel@edk2.groups.io Cc: Brijesh Singh , Jordan Justen , Ard Biesheuvel References: <34bc7f77-2b5a-2e74-e78e-ddf606b6305b@redhat.com> <729bf290-2864-a127-a93d-7b47b7db9b4a@amd.com> From: "Laszlo Ersek" Message-ID: Date: Thu, 15 Oct 2020 18:28:57 +0200 MIME-Version: 1.0 In-Reply-To: <729bf290-2864-a127-a93d-7b47b7db9b4a@amd.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/15/20 17:27, Tom Lendacky wrote: > On 10/15/20 3:47 AM, Laszlo Ersek wrote: >> On 10/10/20 18:07, Tom Lendacky wrote: >>> From: Tom Lendacky >>> >>> All fields that are set in the GHCB should have their associated bit in >>> the GHCB ValidBitmap field set. Add support to set the bits for the >>> software exit information fields when performing a VMGEXIT (SwExitCode, >>> SwExitInfo1, SwExitInfo2). >>> >>> Fixes: 61bacc0fa16f ("OvmfPkg/VmgExitLib: Implement library support for VmgExitLib in OVMF") > > Btw, what is the preferred method for a Fixes: tag in edk2? I've seen it > three different ways - the above way and also: > > Fixes: 61bacc0fa16fd6f595a2c4222425cb6286e19977 > > and > > Fixes: 61bacc0fa16f ("OvmfPkg/VmgExitLib: Implement library support ...") I don't think we've been consistent :) Personally I slightly prefer the Fixes: 61bacc0fa16fd6f595a2c4222425cb6286e19977 format, as a "tag" on the commit message. The natural text in the commit message may still refer to This patch fixes commit 61bacc0fa16f ("OvmfPkg/VmgExitLib: Implement library support ..."), which did so and so... But, it's not a big deal, either format from the two you cite should be OK. Thanks Laszlo