From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (NAM04-DM6-obe.outbound.protection.outlook.com [40.107.102.45]) by mx.groups.io with SMTP id smtpd.web09.1287.1645028911847967572 for ; Wed, 16 Feb 2022 08:28:32 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=kg3C5wFR; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.102.45, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hEVCzBkZJx4Ad4j62D0FRvxihaGVtY+ZH0zj0VhBA+80dbYCgTL9QDVMNzZFDDAEIn0R3R6mt3YVTns0H1vUc/MooEDuclOmWWtao4Zs17ePlEpZnBIuHHEIC+FseMs12vx1wHQvJ6P/m9UFhqrwn60Xv7Rj9vtwC30dCyksiaoExgMRZlj110sXHBAUU3o3l304W2jEXfM9kS5XTCIXtrdSmxtSwaLBdw1nMz2IjLA3mT/ucsB3scn3fmEfZh5rUszsMHmFBoOo3cNRGQh0U8QR9WPUpLOTjXBgRdeKHhF6UAEmrVX2bAp/X5+LHcuwI68eSPiE+gNdeAcIj6Tw+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Lyc9wFDVkk3+Hi27GHDA+rbWrlhAVtAfOCZs8vR9204=; b=UcGJNKgKS/bl88Yv9dhKFUQ9Evlq3w39oW4xV4wUWkr8mZxPNMT/T10zmRckq/igj8UbaLKNGUxmNEK3gKPUKosDvl9bxiVzdKmoT9VXMLyzIG7SunLrwCyqvtN1ZB93o4AGpxggADINetpPd58faU1hRXU6rOvuRIxl2+oxau5EvycRDnJc2q9UMaTUeq0eaE7Bt6Eu0Ckw2kKi3b0cZcST6VfulYJ5ynApPIV/Ohpn79BwXzoymT6FV+jhEJxBZLjYQICu+l5y4M5/FcOQcUm72k9kvP8iyjyuuw6b1xx1j8yHvJ3dlYnkm6mCRKVnzuBeS84Bz/C/2vtd8jC0zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lyc9wFDVkk3+Hi27GHDA+rbWrlhAVtAfOCZs8vR9204=; b=kg3C5wFRe0zqrJ2LSarFkWYfsC+3LLzU1nfvg10g9fh53vq/hlAXtLKAljEOJ+yvHwwHjzJ276Shnv0EmM0qhQdgoh5rFlU6nf26iCCXFZeinsN40yi19fmsgC/N5R2lTrhD9HG98Eoj7QeLgXFbe/z1bws+nuKSJaUtC2zG+xs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by DM5PR12MB1545.namprd12.prod.outlook.com (2603:10b6:4:7::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Wed, 16 Feb 2022 16:28:27 +0000 Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::500e:b264:8e8c:1817]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::500e:b264:8e8c:1817%5]) with mapi id 15.20.4975.021; Wed, 16 Feb 2022 16:28:26 +0000 Message-ID: Date: Wed, 16 Feb 2022 10:28:23 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Cc: brijesh.singh@amd.com, Jordan Justen , James Bottomley , Pawel Polawski , Erdem Aktas , Ard Biesheuvel , Tom Lendacky , Min Xu , Jiewen Yao Subject: Re: [PATCH 1/1] OvmfPkg/AmdSev: reserve snp pages To: Gerd Hoffmann , devel@edk2.groups.io References: <20220216070057.1307716-1-kraxel@redhat.com> From: "Brijesh Singh" In-Reply-To: <20220216070057.1307716-1-kraxel@redhat.com> X-ClientProxiedBy: CH2PR07CA0042.namprd07.prod.outlook.com (2603:10b6:610:5b::16) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) Return-Path: brijesh.singh@amd.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4c11f4a0-d866-4442-7200-08d9f1695be5 X-MS-TrafficTypeDiagnostic: DM5PR12MB1545:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9tMoATMyO7fGDIzynze6KQddcgHzu28rzKmxMTXnrcrjrCeE7v0SX823F0DLWkkz35j3cO73p0+4E0uKblvOkdF3PBWdC11Bq/lidGChIE5XjivZZc0P69YV2NdFE/ma5N7XAt277utWuzT8zyZKhSYrDzfWrzipAfqSJbITYAT9UD2jYwMqFYhif0v1QiuZCE7sM8Q9mkLox6JjbbwjJ0N9t69EdH1VnKJmVHM8DZo/ViLSPb3dRT/nVgCzXFJoRg5h3pk+zBJQKZboVfRMzqNDRkOpfeLnKWdVEqFAXqCR1IhBDuktoHRzYZI96otXf6w/N2yZ0Fmq/aCr/SKaaozeQ3Gajr5F0uM3ARep/imktwYUWBlIiWAHw4LXGvTJpRvspTGwKSzxAJBCBtqUgn17uQkkh7xerQHoYOHecS1+lQiFAptC20W7u5MwadAHJ+DuNUB5CJ9xpMIZjIxWzF14pLRXeR1Zpm7w0Wh6OEVGkhFi82KlFutd3IA4swueBHZArNxqIWLWpAL8OD1rUO9EjalG3CKQY/1P1CZc6hZgZQ+c3nRGovnSWtsBfOc1l30OzWoQYEBk4S+NQGw9st+Byfhu7q8S4pn0jriO6oB8uP5gN/t+nIJuSCnx7Af1p/P71sxoXDqpO9qUKodz28J/qG4eievKkAM+Ywd81kIX9mY0HuW8+QnVi8bmyn1je35Ri5Hkhv30eLjwuS4C1lfrNFF3WKsl5yOUSOXECL8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2718.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4744005)(8936002)(44832011)(6666004)(31686004)(36756003)(6506007)(6512007)(53546011)(5660300002)(38100700002)(2616005)(31696002)(86362001)(26005)(66476007)(66556008)(66946007)(4326008)(8676002)(316002)(508600001)(2906002)(83380400001)(6486002)(186003)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ODVDellTSmxTdk9FbDJ6VitZYktTdG5qWXVjQ2xCWW5UdnVHY2M2WUN6YmVw?= =?utf-8?B?Tnc5dU03SVA5U3dMQWNZazBxMmRvVGdwa2NIbk1KTWV0UFN1MUpaNld1Ynkv?= =?utf-8?B?aU0yOXZQRkdpUW1wdlNOdFZZMTE1dXgrbzB3RXdKMWdJejVJdm40MUNCMEJV?= =?utf-8?B?SndiQTBhYW1RNjczbnlHV2RGU2VRME5lZXpsWXNIM3Z5MFQ2cllnL3c4cnFo?= =?utf-8?B?U2M5cWpCWUhkRDBlWm1ubVBGZk10blNDcnJyQVhCd3Q1N29XampVQkVleCt6?= =?utf-8?B?UEtpRGZBSVU5dG9zWG9UMzZhazNrdlFudDFRWVRiSlNNdm1OVjhXYTFIbW1h?= =?utf-8?B?Nk5UM3VvK3lUOWQxa3EzMEcyN21lWHE1aURIYU5nY2lhRnRZNllHUlBqNUR5?= =?utf-8?B?OFFSVU92ZFBveTR2OUcwb3RJNjBQaTFWM0ltSm9rZXNPZVFVdkJFcU4xazBC?= =?utf-8?B?S050WTJ6N0dpS3BuKzZzN1E3cURvMW5iUzFvVUJSOEFXS0NML0dmSWpMSno3?= =?utf-8?B?Z2k3U1NEdXdaODcrampaZHY0UzduZkRya0hmeHB1a09HMmZoOFJNdWFJU2VP?= =?utf-8?B?UklwU1poOFF0ZEpnNnNockVmbXJnQ3hoZFZvTldHbnlQTkR4aUE3S3E3cUVQ?= =?utf-8?B?RVhPdWdBaUpuQVZSbitxaGFoN2xndXFZQXNzMU5SL0hUVUlFemM5RFQ1QkRN?= =?utf-8?B?UE04Z1VkK3g0d3NGR0FIUjNPellWSkNXbldidmlUR0JVYXFNL1Njc3cyaDZH?= =?utf-8?B?bS9vb2xPYTI2bHZjY05WYjg0ZmdnT29kb1dnVTE0VThrc3pFQklRN3JieUEr?= =?utf-8?B?Y2NBMmlXTzBFWEF0TllReUQ3TWtqWUV4VkhYN2tlUzlWTW5yRHRSMUFBekpj?= =?utf-8?B?blZSN1U2djBZMFkyTlQ0MzV6NFFpeEoxeGw1ZnBZMFljUDZqMVhMM3NuTUlL?= =?utf-8?B?Ny9VemttQksrenV1d2dHVitKZStxeUw1L0hLYmRFckFLRWJ4S3ZNVEllckIy?= =?utf-8?B?dU1hc0NNRFZyRDhEWnE4ZFNZT0haZ3ZTRHp2ekIxSVE1TVkraXFYb0JzSlp6?= =?utf-8?B?RkVobm4xSjdPcXdMZ0xyNU5xVWtwMHpaL2ZacVE3ejF5REdjZ3o3TTVMUHEv?= =?utf-8?B?WHllNVNNRXJ1aW5LQmFkSlhLSTV6aVkzRzB5Q1NSaGdFa1ZxeUJ3UHpZek1s?= =?utf-8?B?cXFtSDRsL0pNZGxKSlh6VWxqbTV3NEhsYnE3dkJxb2JOV0l4OTBaVXZQRUY4?= =?utf-8?B?M0NOM1BldVE2cHZ5ZzhhQVhPbHorN3RPSkFJcTl3QWFBbHhuMnhtZHh3cnJV?= =?utf-8?B?UXpjakNtZWZ6Tjd6ajY3NWJaMGhrcGVuaUd3MTNMV1MxSUlNVC9LQXI2Rmw2?= =?utf-8?B?Yk5nOU9oaGk5ZXN1a0hna0tkdXpWalJyajNvTC9nc0tHeEs3UVNlekRlRHFI?= =?utf-8?B?Njkya2RNQ3NoS29ldnljczczTk03U2wwaWdyR3o1Y2FVLzlvSW1od3RBdXBj?= =?utf-8?B?b2ZWd2xkUVRMSHBVcllMY0tObVFSaEJPU1BzQzRmREhnaUo3Q1BvcEs5c053?= =?utf-8?B?VjF2ME51V0ZPSkswMk9LMjV6aEhRcGNKVS9IWEE1UldCb0NVQXlVbzl5UlhV?= =?utf-8?B?QXZ1WTJXbXM1S05aUUJwcTBTbEpjVUNzR0xSSENYSE0rZ0czNlVzSC9mTG1r?= =?utf-8?B?U2hZa2ZXMkZUemhWS0tBejRFL2lBWkFJWmxBUXJqUjFOZll2eDM5SFQxSTdH?= =?utf-8?B?ZU9UZXU3UXh4RFVIeE9uci8zMjUzL0RraU1BamlEdGN4V2F5TGQ1dng0VXJK?= =?utf-8?B?NzNUMTk5NDFWQnQySGU4aDJWcndxd2NNa05NRVRDMURVMDhlWGJvWjRLVTM3?= =?utf-8?B?MzJyM1FpeEgxNEpDWmVMZEw1ZklrRTZRczA3NlBEbFVHdnNtcXpVZEttZytk?= =?utf-8?B?WnJZMGlCN1VzNFp4QlRIZjVmMzVTM3hVRnUyUWkwd0RBZWh5L0w2VHhGY2Mx?= =?utf-8?B?MzFWSlZFZmo2ZG1QLzY3ME1TNnFDKzM4VkxtMnhWRUxIN3gyZU8xdDRYZFR2?= =?utf-8?B?VUhKenZhZWx4VWtvM2dJWkdiNkNqRk90SmVMQmNIZGNrYXNqZG5PNEZSWTVx?= =?utf-8?B?K3o4cGdPVXo5eWo4Mzh5dlJjcWh5V1F3TGMwZnp4QUpYUnoxQUl5djBBaU1V?= =?utf-8?Q?5CVujQMmMk7SXoe1vd1Yyfo=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c11f4a0-d866-4442-7200-08d9f1695be5 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 16:28:26.8384 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YthThe8ktm2P1WfjGfrR3AWcJcf0H5Ia3ucVb17P7HVtAyZjw4KwpzFrwWlJvGT6OPsTtzGsiavdX2f5HSOeQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1545 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/16/22 01:00, Gerd Hoffmann wrote: > The SNP patch series updated the OvmfPkgX64 build but forgot the AmdSev > variant, resulting in a broken OvmfSevMetadata table. > > Fixes: cca9cd3dd6bf ("OvmfPkg: reserve CPUID page") > Fixes: 707c71a01b9d ("OvmfPkg: reserve SNP secrets page") > Signed-off-by: Gerd Hoffmann Thanks Gerd Reviewed-by: Brijesh Singh