Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: build platform info HOB

["Corvin Köhne" <corvink@FreeBSD.org>]

[-- Attachment #1: Type: text/plain, Size: 2034 bytes --]

On Tue, 2023-08-08 at 18:25 +0200, Ard Biesheuvel wrote:
> On Tue, 8 Aug 2023 at 15:33, Rebecca Cran <rebecca@bsdio.com> wrote:
> > 
> > Nit: "sizeof" is normally used like a function. And this patch
> > mixes the
> > two styles.
> > 
> 
> Actually, this is not unidiomatic for OVMF - sizeof takes either a
> type name (in which case the () are required) or an expression (in
> which case they are optional), and we have always permitted both
> idioms for the latter case.
> 
> $ git grep -cE 'sizeof\s*[:alnum:]' OvmfPkg/
> OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.c:4
> OvmfPkg/EnrollDefaultKeys/AuthData.c:4
> OvmfPkg/IncompatiblePciDeviceSupportDxe/IncompatiblePciDeviceSupport.
> c:7
> OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.c:1
> OvmfPkg/PlatformPei/MemTypeInfo.c:1
> OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.c:5
> OvmfPkg/QemuVideoDxe/VbeShim.c:4
> OvmfPkg/SmmControl2Dxe/SmiFeatures.c:4
> OvmfPkg/Virtio10Dxe/Virtio10.c:1
> OvmfPkg/VirtioGpuDxe/DriverBinding.c:4
> 
> 
> > Other than that:
> > 
> > 
> > Reviewed-by: Rebecca Cran <rebecca@bsdio.com>
> > 
> 
> Thanks
> 
> 
> I've tried to merge this but I am getting errors and I cannot figure
> out what they are:
> 
> https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=99505&view=results
> 

Thanks. Have you tried
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Code-Formatting#how-to-find-uncrustify-formatting-errors-in-continuous-integration-ci

I'm stuck at step 5. I can't see something like "92.5% passed". Maybe I
don't have the permission to see it?

> 
> 
> 
> 

-- 
Kind regards,
Corvin


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107686): https://edk2.groups.io/g/devel/message/107686
Mute This Topic: https://groups.io/mt/100327419/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]