From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3EEA0AC1798 for ; Thu, 10 Aug 2023 12:53:19 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=8zd5UYL+Vffp2uyn2qa8slXxsN0Fs/2M3gZrJDe1ihc=; c=relaxed/simple; d=groups.io; h=ARC-Message-Signature:ARC-Seal:ARC-Authentication-Results:Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References:User-Agent:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1691671997; v=1; b=eKp+TmhikJTmn0QU4lBBbCL7mH+H3REbcKKOePXq1NKgjxd00VDcfLwhDTd6ixeiTEM96Xu+ S1wPBFnLwNFxX//5G1APwAxMVhFdYDdKCSBl2fCX4N6d3RM2BS6t5R8Wn68EOcuc8GVbD8K//uR Vh5vB08IxMRX/cyA7u9coKW4= X-Received: by 127.0.0.2 with SMTP id acLwYY7687511xJGLeZigYI6; Thu, 10 Aug 2023 05:53:17 -0700 X-Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by mx.groups.io with SMTP id smtpd.web10.16290.1691671996704294290 for ; Thu, 10 Aug 2023 05:53:17 -0700 X-Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4RM6Kl5K8mz3bws; Thu, 10 Aug 2023 12:53:15 +0000 (UTC) (envelope-from corvink@FreeBSD.org) X-Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RM6Kl47Pdz3LB8; Thu, 10 Aug 2023 12:53:15 +0000 (UTC) (envelope-from corvink@FreeBSD.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1691671995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jJ1ZfyDKhRLP9L5EdqAfp8ugBwl++zsu2/qKvjeDajE=; b=e5g+587iPoaMb4beAyTYrAmEnU/N7a8SFxhEUneKMSZdcmh5Y+4dKR6wF+fXNCK9bymGLq 3e1+8C6GRS6rZ5StJgwrAuBYrm+Uj64Ti9o5zMzpoy5SPX0GyDNO8K6DdrNik/5z0wTajo Evc0A2ZzIDlgNvy7VtQ06R9//pWck4dLHFrHcqZGbM+Pm/htaKKgSF8f0oUJrnyjd/0Ytl td1u01PHx0wWNBicc+gyb7qdUoV0P0vygd2fTyU13dSzr4wiVY875rdsde3d7m72UIqwRb ZLKU4lxtZ2UQZZau6kGxKAX4l6plmzkwqzj01ggkybmNabbmCPHxrXSNgKWPZw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1691671995; a=rsa-sha256; cv=none; b=cvyb7kYcmt4cCUfZSkYI3jOIotWAKt7KOUuBskaMbUfB+8pHoN7QRXnImC/hV9oSrM0s39 9TSQ7ZqY4q4r9tz/eDOSXkMUAAxzs5xvYJBwYYfmieewHErQ5csKC5/kanBNtZ7uX+9ZGa 1mrPbsKfHvZ5Nk+8I4Y/yygxGjY30OKOoCQXCmyjC7ZwoxJNpel5HF0zCkuyRkDI0MPx/l HUorA0HT1XqdfHpLZO9HfVRGPE56GuGbyhINlw94GpXaQUH83ZMnPSWANE4oU6QUerhV28 tbdfjq8PWnwPpN1/eZoiGMIDFsT57OLz2BBeSRaBndyhvsVTefYeniI29Ji9qQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-Received: from [172.21.179.63] (unknown [195.226.174.194]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: corvink) by smtp.freebsd.org (Postfix) with ESMTPSA id 4RM6Kk27lzz34B; Thu, 10 Aug 2023 12:53:14 +0000 (UTC) (envelope-from corvink@FreeBSD.org) Message-ID: Subject: Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: build platform info HOB From: =?UTF-8?B?Q29ydmluIEvDtmhuZQ==?= To: devel@edk2.groups.io, ardb@kernel.org, Rebecca Cran , Michael Kinney , Michael Kubacki Cc: Jiewen Yao , Jordan Justen , Gerd Hoffmann , Peter Grehan Date: Thu, 10 Aug 2023 14:53:11 +0200 In-Reply-To: References: <20230724130006.427522-1-corvink@FreeBSD.org> <20230724130006.427522-2-corvink@FreeBSD.org> <899bbdac-5aa3-50c4-f6e2-926b7a22c799@bsdio.com> User-Agent: Evolution 3.48.4 MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,corvink@FreeBSD.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: hGv948Bp1330x5t8V5kFzNpux7686176AA= Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-M0/O0Drzbn74gGJZeM+m" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=eKp+Tmhi; arc=reject ("signature check failed: fail, {[1] = sig:freebsd.org:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --=-M0/O0Drzbn74gGJZeM+m Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2023-08-08 at 18:25 +0200, Ard Biesheuvel wrote: > On Tue, 8 Aug 2023 at 15:33, Rebecca Cran wrote: > >=20 > > Nit: "sizeof" is normally used like a function. And this patch > > mixes the > > two styles. > >=20 >=20 > Actually, this is not unidiomatic for OVMF - sizeof takes either a > type name (in which case the () are required) or an expression (in > which case they are optional), and we have always permitted both > idioms for the latter case. >=20 > $ git grep -cE 'sizeof\s*[:alnum:]' OvmfPkg/ > OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.c:4 > OvmfPkg/EnrollDefaultKeys/AuthData.c:4 > OvmfPkg/IncompatiblePciDeviceSupportDxe/IncompatiblePciDeviceSupport. > c:7 > OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.c:1 > OvmfPkg/PlatformPei/MemTypeInfo.c:1 > OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.c:5 > OvmfPkg/QemuVideoDxe/VbeShim.c:4 > OvmfPkg/SmmControl2Dxe/SmiFeatures.c:4 > OvmfPkg/Virtio10Dxe/Virtio10.c:1 > OvmfPkg/VirtioGpuDxe/DriverBinding.c:4 >=20 >=20 > > Other than that: > >=20 > >=20 > > Reviewed-by: Rebecca Cran > >=20 >=20 > Thanks >=20 >=20 > I've tried to merge this but I am getting errors and I cannot figure > out what they are: >=20 > https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=3D99505&vi= ew=3Dresults >=20 Thanks. Have you tried https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Code-Formattin= g#how-to-find-uncrustify-formatting-errors-in-continuous-integration-ci I'm stuck at step 5. I can't see something like "92.5% passed". Maybe I don't have the permission to see it? >=20 >=20 >=20 >=20 --=20 Kind regards, Corvin -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107686): https://edk2.groups.io/g/devel/message/107686 Mute This Topic: https://groups.io/mt/100327419/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --=-M0/O0Drzbn74gGJZeM+m Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgvRSla3m2t/H2U9G2FTaVjFeAmoFAmTU3bcACgkQ2FTaVjFe AmpiEg//QG0mStLCfdy1BBMsLK+XmylmrHTZyGq/mKYXTJkn6x+cy3MbwBuFO5Hs 445pzp0NKmnshtHwse4qNsYCUQu6EZRGcBfmMFrJsD3xacvEWIyb2VUuy3+WNmjS KohYsXWkDIcOOdtrdXN/nPnxsyksPwC6qLz2kRXKp58LDetE77DR9ynLB3ze90Jk aZ45gcglvrHP5d+OhiAvuR3z338vzY9SPcPtyZ5wMkDxt3a+vxxRe/JDxQ+k2dX9 vmy7LgpQvNPT10k4Y0wJtKORiRzkBDPOGPfG/cnjg0x/BERjYQmGgEl7gAx5ZDp5 nh6RREDwS+CYYw7W1TCRUIy9uOYzANOw+eQhkBGMB0iq8yyyI2KpJ0ozM3RpxjS0 ZrQb0wqpM3IvXbWJJDhQUosly4/An2X4Hwu4L9q7n4p6P+3IzsTQo8e/NAfrZvTM hUzM8GwIReufV90ZpAyv3PBAShqQlNyP7WW71Vq2jKi+Dtga1fOrJzNbyObU8cP6 F669mUWJZJCigDUTtP4Smu1SCV6AVxYHb5WLfC5dgf84HlfZA62Lu3kBX8CabkV5 YygvRcFt6ncMce48rNBYCwLf6swZvOcpqQlU1voRUHhJaiYtUKFyELOUjYdJKt9q 4jlK6/pdxhtMyTRfqU7id7Fm4A+prid7ykFs3RnFPfzxYk6wSrc= =1dIm -----END PGP SIGNATURE----- --=-M0/O0Drzbn74gGJZeM+m--