From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com;
 receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 28B182094606E
 for <edk2-devel@lists.01.org>; Fri,  4 May 2018 08:03:15 -0700 (PDT)
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com
 [10.11.54.3])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 897EFA1BCD;
 Fri,  4 May 2018 15:03:14 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-129.rdu2.redhat.com
 [10.10.120.129])
 by smtp.corp.redhat.com (Postfix) with ESMTP id CB2B6111AF05;
 Fri,  4 May 2018 15:03:13 +0000 (UTC)
To: "Carsey, Jaben" <jaben.carsey@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
 "Gao, Liming" <liming.gao@intel.com>
References: <cover.1524239027.git.jaben.carsey@intel.com>
 <c8410b977666561b40e92e5ce4d1ffb088576c6b.1524239027.git.jaben.carsey@intel.com>
 <814bebab-3b06-ce21-4fbb-326cc0a49121@redhat.com>
 <CB6E33457884FA40993F35157061515CA3CEDA4A@FMSMSX103.amr.corp.intel.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <ead24b1e-76a8-7ee4-59c9-23f3c473829c@redhat.com>
Date: Fri, 4 May 2018 17:03:12 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <CB6E33457884FA40993F35157061515CA3CEDA4A@FMSMSX103.amr.corp.intel.com>
X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.11.55.2]); Fri, 04 May 2018 15:03:14 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]);
 Fri, 04 May 2018 15:03:14 +0000 (UTC) for IP:'10.11.54.3'
 DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com'
 HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:''
Subject: Re: [PATCH v1 17/27] BaseTools: DataType - cleanup list constants
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Fri, 04 May 2018 15:03:16 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

On 05/04/18 16:18, Carsey, Jaben wrote:
> Laszlo,
> 
> Wow.  I thought I had tested, but clearly I missed that.
> 
> Do you think we just revert back the name change short term?  I agree
> that mixing internal data structure names and names in the config
> file seems wrong, I don’t know the ROI for separation.  Maybe use a
> dict to translate?
Using a dictionary to translate seems OK to me -- it doesn't look large
or complex, and it should be extensible in the future.

Thanks,
Laszlo