From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.66]) by mx.groups.io with SMTP id smtpd.web09.290.1626798295158040184 for ; Tue, 20 Jul 2021 09:24:55 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=2gP4TGPt; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.236.66, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YtEOUdD9g1dtJtNE0S3FHDkampsAsFW0Z9L5HQHZ4hgdLogz1WP2V953c2DfK1bEYk8JSDp/mJS+mB3BjOlIY8k1ypkBgmLtv/JO8e0lWBQ5R/jWsTd7IsccM8oDS81SfJ9qcN5IP96KpuZ9xwZpEpiySsFM035Log5uU44YpwLbEvpp0ZWL0HmEVvTA68BIhXxlSPF4Elk2yIISevFsvoyRJPCmR66R7nkRMVd6iPhvpdb2lCaFOHPE4GOTeVXXslzcnrfT8PPNpDW71+wMH/C/gDLPTPKvXYgewH+TmvfMhuQq+sqi9MqhI8vWXQYCUQ+i4iTk9UcQjfl7BgXnjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HixYq3JkHJrB5JBph7trGZfcZbhset629zl+g1Glt5U=; b=ToWkQ+nj4nN7b1PIs5TJFsteo8tVdFKHhtn2TTSirqa1detxZVtz9aShpMvQIjrytNW0ZyODxBvsmkOi3nTLgVqCcbO0eu5PSADQ5Qmxj15p47wrZJuZU7Z+zgXuyI5GWzqM9EMbep332nbA1EfKqiWRZBJLnynMLTBOSqfjKeJGpi3vp/8ZqaR3XyR45EOyprWwzu5FMOjfmgGbYkPx2aS8yl3LNHDQJsZnQKvgwABR4QexUrYDRK1CykD0AbNrsKm5HBsMW49N2jkEvKvfFueS30ykcSI144oSiLnFOmjK8W4zOaqkOLmhxc8kZu50BjwReM3xNJVXkJ1IxQlLXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HixYq3JkHJrB5JBph7trGZfcZbhset629zl+g1Glt5U=; b=2gP4TGPtqbuybKbbSjSm4vGX6dEhYLsmpPL5ayQp4TpsIfj81Bmtf3JxFabCl83NDb6huGHqsgzeciYtM9sX3mQag0BUtQncOOeIFuknXGZCJ6XNFs/Fms+ZwVVGBihV2FqeUO3clq0vowXYp+CpG5khW3v7kn6SQq+TWQxegfI= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) by DM4PR12MB5359.namprd12.prod.outlook.com (2603:10b6:5:39e::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.31; Tue, 20 Jul 2021 16:24:53 +0000 Received: from DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::73:2581:970b:3208]) by DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::73:2581:970b:3208%3]) with mapi id 15.20.4331.034; Tue, 20 Jul 2021 16:24:53 +0000 Subject: Re: [PATCH v3 08/11] OvmfPkg/AmdSev/SecretPei: build hob for full page To: Dov Murik , devel@edk2.groups.io Cc: Tobin Feldman-Fitzthum , Tobin Feldman-Fitzthum , Jim Cadden , James Bottomley , Hubertus Franke , Ard Biesheuvel , Jordan Justen , Ashish Kalra , Brijesh Singh , Erdem Aktas , Jiewen Yao , Min Xu References: <20210720080401.3662854-1-dovmurik@linux.ibm.com> <20210720080401.3662854-9-dovmurik@linux.ibm.com> From: "Lendacky, Thomas" Message-ID: Date: Tue, 20 Jul 2021 11:24:51 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210720080401.3662854-9-dovmurik@linux.ibm.com> X-ClientProxiedBy: SN4PR0501CA0019.namprd05.prod.outlook.com (2603:10b6:803:40::32) To DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) Return-Path: thomas.lendacky@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.236.30.241] (165.204.77.1) by SN4PR0501CA0019.namprd05.prod.outlook.com (2603:10b6:803:40::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.9 via Frontend Transport; Tue, 20 Jul 2021 16:24:52 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 296d69aa-0c39-443a-5972-08d94b9ae799 X-MS-TrafficTypeDiagnostic: DM4PR12MB5359: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2331; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 75W91bHTX7X0wjMrOUmppcqpLMpQGczOtdfX10L/KenI6O1JDVG2q+C1iI3hdAaDlFySaTNOSMurEytPykSPG5DTdnpu7n40+k3sq2pvQkHkCmxxf8I4IpxAqu6byx3kIcaF9DrcQqaqtCFy9piDjpOL+3wIFaBzUrAMp39fbxZOKReT7sIElGvpsy2ifZRDo+03LqlzhBISF/IYqBtCH1YyoV5KYZIHcXU9G0q9JdHZTXQl3UE1IqUQI9sX3+dLOac7XVbVoUTsSFg5+AURyJ0Txr0jR4PVQ+Nvx78JvdEdGUu33xNDiu1u7wHo8RuNFezmRQa0LDK88VhpPtQCW/288bO0re0/N3CYtET3HDiZNtRT6S+bCNoXGw52/BQtzJpvwoOb1wHjw7XxJkoEFLxiuMj94biK5w0lceLCjYMYJI4fPvHrNwzcaFCkLaZ/1N6jZdu4zMM3uUiPRuDpLEqvfd0jO9MH1qi2ptu6VaoB5vgPDDxu6yybRVfKXckw2kRKynP21kcAvfDi+WxIIZ3mQrF47PsVpvwF46RvvCWDsWOw8IbELDQNHe5ArmjtNH1c1BclxNP1423/fJgwyrLAKCqygTP+9FrcMOJABuQJDo1IMdLtXKKhrc13rPWZkwK2g/bpS3J4gwoic1bX1w4Xn1Gai+uH2XslwrlksxzNCf/VRq6oBqkSWtxdEGHfnF6miqFpYrZtMYvFdMOJ4PSspTh1HdSjWWMYR6fsYnxSEybH3CGfQro6I71SQ3mbCYbl5yPTlZaR+2khzNB7UAcyVgR4O9qET+RxECd840NqgaeW2TO2PnkuNlmqn0Jb X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5229.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(366004)(376002)(396003)(346002)(136003)(478600001)(54906003)(16576012)(31696002)(66556008)(83380400001)(38100700002)(66476007)(6486002)(4326008)(316002)(5660300002)(53546011)(2616005)(186003)(966005)(86362001)(31686004)(956004)(26005)(66946007)(8936002)(2906002)(4744005)(7416002)(8676002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZDJPOWVoMHhrR3BSSTgvNURocU9EcVBoRW54RHVNY1hvaG5tbUZ1SWdTMnNm?= =?utf-8?B?bHVNRDJyT3V3TzRVaGwzNjgrenp4QVRmbUlhZ3ZONkl1SGVMZGJKcDNkOUxU?= =?utf-8?B?cXc2dmJQcS92MGN6Z1o2cHlocGZuN0VZeWU1Z2hCdGNSbkw1V2p1OThUMmlF?= =?utf-8?B?a0E4dTY0amUwS1dtcEVaQWg0Wld5WnVGYXVZbEJ4K2JOUHpGYlVCKzNEbFFv?= =?utf-8?B?KzlHbWhoVXpKZjJBSEpOYlpSV3VGdkFaRmdpNk0xNWp0c2dhN0RHeXB5UjdK?= =?utf-8?B?NU93c3ZxcDdyV0t4Yk40RGU4OUlSYktRMlBwQ1crelZaajZhVnh3VndNU1lT?= =?utf-8?B?a2JQeUdDK0dvRmtIMXFEYXc0R0JzVkxkcVl1TnUvL0RnZzF6bzMwMEw0RUpS?= =?utf-8?B?bVlla3d0eFVjdHFkSEx2TGFoTnphbFI3bFB4R0RPU2ZML2xpcVFoQWcrOTQz?= =?utf-8?B?c2tmSjYxaS9NVTVGRkVnM0hsR0V6akllRmxqU2EwdWlTOEhlM3U4aFFXL25t?= =?utf-8?B?M3NQOEREZEN1ZEE2ZUQyMnZNMFM3YzJBRjM4OERXVFdMUWNJT0pKa1Nidzd5?= =?utf-8?B?T3c5TjJxbDFJRlloS2pQdEtzc0s4NGh4enNOYUhBUVdxVTRFazBSN0VBMTBP?= =?utf-8?B?SXVXa0t0SXdjU2kvazRZT2JQWXhUY1lLK0NZR3k1VXRsNDRrMUVwVTJLVE9j?= =?utf-8?B?MExYMmtpR21lZlA3VkN1cDE5bCtGY1lycS9rTktMazhQZjBXbmtRSE8zaUdI?= =?utf-8?B?L3ZIMnRIdDNadVRvRTByYmNaSmlPcXR1bkhWWlN6UkgveDgrWG9Mc05CcDZ3?= =?utf-8?B?NFZady9CTE9YUWFCVGZwNlVBY0d1YzZ3SmhwcHNFeTJUdWlsdWZCTUlGTHZM?= =?utf-8?B?N3FPOWl2SzhKSEZVVHBvb2pnV0F0S2NRbHk1NlZ6NFlleXpPN0FXWExjeDVp?= =?utf-8?B?YktYSTBkeFF3UlZOcHM4akJmVTRNY3NQb0srd0ZYdnRla2hjSldESXVURGE0?= =?utf-8?B?Q3pNWHpVOS81OW50S0YzZjdDS1JZdEpEQXhpZ010ckg0ZUhCVnYwR3hHTTQz?= =?utf-8?B?SEk0MjNIVENFbGVKZ3hRSis2VXZiT1VRSkllb2U5NWYvZElaczlrYmRaZXF3?= =?utf-8?B?QVRIRVgvb2UxeFM5Y2NkVG5HcGgzcGFlUUhvMlJuRDJDdG9OR1ZHR3Ixb1l2?= =?utf-8?B?M0NoOVQ5aDc4b0c1OWlaUFduUzIzYzd4L1BwUWhEUWg5Tm5SUkQzR0ZvMURP?= =?utf-8?B?QStZcTFzakl2azRjcmVpMmN6Q1k2MUZibDdSZHU2UE4vN3JUbVN2dmJVcThX?= =?utf-8?B?bnFBS0R3MWtja0prdTZ0S0dxMEhVelh1TnNER3F3WVpaa0Yvc0F0T1JOUFNR?= =?utf-8?B?YnJSbkJSR3Rrek1SZyt2dTg4ZjRXYS9XbnFHa1kranVrTHJPVG41ZXFmRkhy?= =?utf-8?B?ZzRJK1g5T3M5SXJGek5mWnM5MFVuaVM2OVZnQmVwTldnZ0ZaR2tGMnhUMEJM?= =?utf-8?B?cmVValZIRTZTand2UHdDVC9GWXlNYU42K2hKVHZTMmRQU01kWnE4WisxYUlY?= =?utf-8?B?U1RIWFRaY2t1OTdiQWQ4V1JtZFl1U0xWbHhacmxhRHlGcUdYWUdDenJkc3A2?= =?utf-8?B?eHJXd1BTRlRJOTQrb0RSMFlyK3YrSnhsOEc4YmNEVHZLeFVvSDM4WFFNM0x5?= =?utf-8?B?RnJhRGcrcHoyMFJ5M05qQzBpUW9lTUc3a0luRy8xUG1MQm5DcWxyN0w2a2Vy?= =?utf-8?Q?cX4VB6UkpZ0LZsvL3sWOycFk5+CpkSBQBf2Ak/o?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 296d69aa-0c39-443a-5972-08d94b9ae799 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2021 16:24:53.3175 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /fKQsC5asq+pn0z50efTBpzo50QDseEkmbjzM0CYXdneEeHgOXYVAP5c926PbiGOuOUeposU+U5iYksjjyYa9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5359 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 7/20/21 3:03 AM, Dov Murik wrote: > Round up the size of the SEV launch secret area to a whole page, as > required by BuildMemoryAllocationHob. This will allow the secret > area defined in the MEMFD to take less than a whole 4KB page. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Ashish Kalra > Cc: Brijesh Singh > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Min Xu > Cc: Tom Lendacky > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3457 > Signed-off-by: Dov Murik Reviewed-by: Tom Lendacky > --- > OvmfPkg/AmdSev/SecretPei/SecretPei.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >