From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web12.36200.1590430255370943642 for ; Mon, 25 May 2020 11:10:55 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aSrNhBgu; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590430254; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TWiOV1zTtHfZb4ZpKXNJWQ7xok4l/OQsyKNzU3YQAbM=; b=aSrNhBguvQovTJrjAKkQoyzRJ68emK+RjnWA9dFvXloLrrfwPXKs8KBQyxfyWLBF95kN3Q Pd3LD0USNcsXJ3trZqZWHo+wKeJRkSYCDDhj/p4ANOxjL09Cz8cJMfmEvcobR4dCHX51x5 fJisyd2kFayEmgqFKTr3+YF4OZqLksI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-197-YSET726TOVqcG61lAtHzUA-1; Mon, 25 May 2020 14:10:51 -0400 X-MC-Unique: YSET726TOVqcG61lAtHzUA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D4B258015CE; Mon, 25 May 2020 18:10:49 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-168.ams2.redhat.com [10.36.114.168]) by smtp.corp.redhat.com (Postfix) with ESMTP id D841D2E020; Mon, 25 May 2020 18:10:47 +0000 (UTC) Subject: Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process To: Andrew Fish , Bret Barkelew Cc: "devel@edk2.groups.io" , "spbrogan@outlook.com" , "rfc@edk2.groups.io" , "Desimone, Nathaniel L" , Mike Kinney , "Leif Lindholm (Nuvia address)" References: <2107AEA7-9145-4FC9-9E1A-C396F23877ED@apple.com> From: "Laszlo Ersek" Message-ID: Date: Mon, 25 May 2020 20:10:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <2107AEA7-9145-4FC9-9E1A-C396F23877ED@apple.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hi Andrew, On 05/25/20 06:09, Andrew Fish wrote: > I also found I had to Bing/Google to find the detailed instructions I > needed as a developer, as the Wiki seems to assume you just know the > Linux kernel patch process. That feels like an area we can improve. (apologies if I've lost context; please disregard my message below in that case). I wrote the following wiki article originally in 2016: https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers I wrote it specifically for developers & maintainers with no (or almost no) prior git / mailing list experience. Multiple developers confirmed later that the article had helped them. Thanks Laszlo