Re: [edk2-devel] [edk2-platforms PATCH 5/6] LoongArchQemuPkg: fix SEC ProcessLibraryConstructorList() prototype

["Chao Li" <lichao@loongson.cn>]

[-- Attachment #1: Type: text/plain, Size: 2567 bytes --]

Hi Laszlo,

I have tested:

1. Follow edk2 series patch 3 changes to 
BaseTools/Source/Python/AutoGen/GenC.py.

2. Follow edk2-platforms series patch 5 changes to 
edk2-platforms/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c.

After the changes, I have built and tested, and it works fine.


BTW, you can get the LoongArch cross-toolchain in two ways:

1. Download it from LoongArch cross-toolchain website, URL: 
https://github.com/loongson/build-tools, the last release date is Aug 8, 
2023.

2. Use the Fedora39 docker or virt-machin(X64), and install the 
LoongArch cross-toolchain from rpm source.


Build-tested-by: Chao Li <lichao@loongson.cn>

Reviewed-by: Chao Li <lichao@loongson.cn>


Thanks,
Chao
On 2024/2/7 09:09, Laszlo Ersek wrote:
> The current declaration of, and call to, SEC
> ProcessLibraryConstructorList() in LoongArchQemuPkg matches the PEIM entry
> point parameter list. Fix the call, and rely on AutoGen for the
> declaration.
>
> Untested (have no cross-toolchain installed for LOONGARCH64).
>
> Cc: Bibo Mao<maobibo@loongson.cn>
> Cc: Chao Li<lichao@loongson.cn>
> Cc: Xianglai li<lixianglai@loongson.cn>
> Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=990
> Signed-off-by: Laszlo Ersek<lersek@redhat.com>
> ---
>   Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c b/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c
> index 3f1998c48c12..50d898859a99 100644
> --- a/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c
> +++ b/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c
> @@ -9,7 +9,6 @@
>   
>   #include <PiPei.h>
>   
> -#include <Library/PeimEntryPoint.h>
>   #include <Library/BaseLib.h>
>   #include <Library/DebugLib.h>
>   #include <Library/BaseMemoryLib.h>
> @@ -378,7 +377,7 @@ SecCoreStartupWithStack (
>   
>     DEBUG ((DEBUG_INFO, "Entering C environment\n"));
>   
> -  ProcessLibraryConstructorList (NULL, NULL);
> +  ProcessLibraryConstructorList ();
>   
>     DEBUG ((DEBUG_INFO,
>       "SecCoreStartupWithStack (0x%lx, 0x%lx)\n",
>
>
>
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115575): https://edk2.groups.io/g/devel/message/115575
Mute This Topic: https://groups.io/mt/104210907/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 4718 bytes --]