From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1417078003C for ; Mon, 19 Feb 2024 02:22:06 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=blEplFrd7gtXKZmh7vbvIxzyivhXMjmReWYcoRlcIHc=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1708309325; v=1; b=KwxulX+XTMVg+as+p/Ml3wapSkp6Z4+hX90vT91yq2A9iIjx7WPktIgqTly1uFzENnFo0bMn IoTv39m4w9MKdkWl/blnk50Ehr73ec3/NWj/8D3b61oOknwswXxX+JEUYJZq8qKGEL6oT+hRSPg X369W7H0pF1/KqrDW/MYSndk= X-Received: by 127.0.0.2 with SMTP id 6jOiYY7687511xETWLIQuicF; Sun, 18 Feb 2024 18:22:05 -0800 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web10.32897.1708309324458422667 for ; Sun, 18 Feb 2024 18:22:05 -0800 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8DxJ+hHu9JlRDAOAA--.18257S3; Mon, 19 Feb 2024 10:21:59 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8DxdMxCu9Jlk7g7AA--.39278S3; Mon, 19 Feb 2024 10:21:54 +0800 (CST) Message-ID: Date: Mon, 19 Feb 2024 10:21:54 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [edk2-platforms PATCH 5/6] LoongArchQemuPkg: fix SEC ProcessLibraryConstructorList() prototype To: devel@edk2.groups.io, lersek@redhat.com Cc: Bibo Mao , Xianglai li References: <36593e23-d3e8-b71a-808d-ef94260b5fd0@redhat.com> <20240207010919.105860-1-lersek@redhat.com> <20240207010919.105860-6-lersek@redhat.com> From: "Chao Li" In-Reply-To: <20240207010919.105860-6-lersek@redhat.com> X-CM-TRANSID: AQAAf8DxdMxCu9Jlk7g7AA--.39278S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQAMCGXRv+MD2QABs2 X-Coremail-Antispam: 1Uk129KBj93XoWxGF4UuF1fGrW8uF4fAw4fWFX_yoW5Gr4rpF nxua9rKr4Fqw1jvw15J340gFyv9rZ0kr1DXa90y34S9as3J3Wkt3y2v3WDurW7uryFyFy0 qw48Kw4UXF4j9FXCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnRJUUUymb4IE77IF4wAF F20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r 106r15M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAF wI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1l84ACjcxK6I8E87Iv67 AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UM2AIxVAIcxkEcVAq07x2 0xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx1lYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx 0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCjr7xv wVCIw2I0I7xG6c02F41l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2 IqxVAqx4xG67AKxVWUGVWUWwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v2 6r126r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2 IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv 67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf 9x07UEFAJUUUUU= Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lichao@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: WI1ToyZrBUpY3WsyuUq3iMj8x7686176AA= Content-Type: multipart/alternative; boundary="------------0TCKM3IYt0sp0su2WgBrB9c3" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=KwxulX+X; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --------------0TCKM3IYt0sp0su2WgBrB9c3 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Laszlo, I have tested: 1. Follow edk2 series patch 3 changes to=20 BaseTools/Source/Python/AutoGen/GenC.py. 2. Follow edk2-platforms series patch 5 changes to=20 edk2-platforms/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c. After the changes, I have built and tested, and it works fine. BTW, you can get the LoongArch cross-toolchain in two ways: 1. Download it from LoongArch cross-toolchain website, URL:=20 https://github.com/loongson/build-tools, the last release date is Aug 8,=20 2023. 2. Use the Fedora39 docker or virt-machin(X64), and install the=20 LoongArch cross-toolchain from rpm source. Build-tested-by: Chao Li Reviewed-by: Chao Li Thanks, Chao On 2024/2/7 09:09, Laszlo Ersek wrote: > The current declaration of, and call to, SEC > ProcessLibraryConstructorList() in LoongArchQemuPkg matches the PEIM entr= y > point parameter list. Fix the call, and rely on AutoGen for the > declaration. > > Untested (have no cross-toolchain installed for LOONGARCH64). > > Cc: Bibo Mao > Cc: Chao Li > Cc: Xianglai li > Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=3D990 > Signed-off-by: Laszlo Ersek > --- > Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c b/Platform/= Loongson/LoongArchQemuPkg/Sec/SecMain.c > index 3f1998c48c12..50d898859a99 100644 > --- a/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c > +++ b/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c > @@ -9,7 +9,6 @@ > =20 > #include > =20 > -#include > #include > #include > #include > @@ -378,7 +377,7 @@ SecCoreStartupWithStack ( > =20 > DEBUG ((DEBUG_INFO, "Entering C environment\n")); > =20 > - ProcessLibraryConstructorList (NULL, NULL); > + ProcessLibraryConstructorList (); > =20 > DEBUG ((DEBUG_INFO, > "SecCoreStartupWithStack (0x%lx, 0x%lx)\n", > > > >=20 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115575): https://edk2.groups.io/g/devel/message/115575 Mute This Topic: https://groups.io/mt/104210907/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --------------0TCKM3IYt0sp0su2WgBrB9c3 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Hi Laszlo,

I have tested:

1. Follow edk2 series patch 3 changes to BaseTools/Source/Python/AutoGen/GenC.py.

2. Follow edk2-platforms series patch 5 changes to edk2-platforms/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c.

After the changes, I have built and tested, and it works fine.


BTW, you can get the LoongArch cross-toolchain in two ways:

1. Download it from LoongArch cross-toolchain website, URL: https://github.com/loongson/build-tools,= the last release date is Aug 8, 2023.

2. Use the Fedora39 docker or virt-machin(X64), and install the LoongArch cross-toolchain from rpm source.


Build-tested-by: Chao Li <lichao@loongson.cn>

Reviewed-by: Chao Li <lichao@loongson.cn>


=
Thanks,
Chao
On 2024/2/7 09:09, Laszlo Ersek wrote: 
The current declaration of, an=
d call to, SEC
ProcessLibraryConstructorList() in LoongArchQemuPkg matches the PEIM entry
point parameter list. Fix the call, and rely on AutoGen for the
declaration.

Untested (have no cross-toolchain installed for LOONGARCH64).

Cc: Bibo Mao <maobibo@loongson.cn>
Cc: Chao Li <lichao@loongson.cn>
Cc: Xianglai li <lixianglai@loongson.cn>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=
=3D990
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c b/Platform/Lo=
ongson/LoongArchQemuPkg/Sec/SecMain.c
index 3f1998c48c12..50d898859a99 100644
--- a/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c
+++ b/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c
@@ -9,7 +9,6 @@
=20
 #include <PiPei.h>
=20
-#include <Library/PeimEntryPoint.h>
 #include <Library/BaseLib.h>
 #include <Library/DebugLib.h>
 #include <Library/BaseMemoryLib.h>
@@ -378,7 +377,7 @@ SecCoreStartupWithStack (
=20
   DEBUG ((DEBUG_INFO, "Entering C environment\n"));
=20
-  ProcessLibraryConstructorList (NULL, NULL);
+  ProcessLibraryConstructorList ();
=20
   DEBUG ((DEBUG_INFO,
     "SecCoreStartupWithStack (0x%lx, 0x%lx)\n",
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#115575) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------0TCKM3IYt0sp0su2WgBrB9c3--