From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) by mx.groups.io with SMTP id smtpd.web11.8271.1629624544897653149 for ; Sun, 22 Aug 2021 02:29:05 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@posteo.de header.s=2017 header.b=ODaaSSmf; spf=pass (domain: posteo.de, ip: 185.67.36.66, mailfrom: mhaeuser@posteo.de) Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id CE9FB240101 for ; Sun, 22 Aug 2021 11:29:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1629624541; bh=Wi81+0U1JTv6sOmwhLjCjqEqmXPXzEDw3bNzAz5BG7M=; h=Subject:From:To:Date:From; b=ODaaSSmfm4yIi0BeGEAnelV7MZi557TxMXn+wc25z7l3AjYwug5q/Vj6LB45EqKfF wsd3sc5l6nHVuTfvTHvQbq3+EtbnzieTpjrrmF/RDkKxUESwKQAl7y3ZyDN5E1anwL eGID2sRcUU4jvCxtqcOsN/xaUb65PBcmwhWNo9ZpSna3ccQyexeHVJ1AV9fVWjHgDy /invtFn1qqg9eOzN9fial+4T0FAc8MZGAd+mHyVdHpWIzp7OQJcAk/d8Ip4lpg+Qyv G0wTqmxRvOPkrFChVsnzN2S/qh/MemV/WGj6fWkyyojCATND7S39eEzD4adK8cNx7v IsccQLGWM0vJg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4GsqnT24mxz6tm4 for ; Sun, 22 Aug 2021 11:29:01 +0200 (CEST) Subject: Re: [edk2-devel] [PATCH 1/5] MdeModulePkg/PeiCore: Align fixed-address error behaviour From: =?UTF-8?B?TWFydmluIEjDpHVzZXI=?= To: devel@edk2.groups.io Reply-To: devel@edk2.groups.io, mhaeuser@posteo.de References: <6baa44c6ee3ead5e4ffdefd5fdd3961323c323d0.1629575593.git.mhaeuser@posteo.de> <3f1f8c6f-ec62-f30b-45c1-bda5c466a3ce@posteo.de> Message-ID: Date: Sun, 22 Aug 2021 09:28:57 +0000 MIME-Version: 1.0 In-Reply-To: <3f1f8c6f-ec62-f30b-45c1-bda5c466a3ce@posteo.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: quoted-printable Got it:=20 https://public-inbox.org/git/4db7759c-2123-533b-9f89-954c07f5832a@posteo.= de/T/#u Sorry, once more, for the "spam" :) Best regards, Marvin On 21/08/2021 22:10, Marvin H=C3=A4user wrote: > Good day, > > Is someone firm with the details around git send-mail? I explicitly=20 > disabled threading (i.e. "git config sendemail.thread" yields=20 > "false"), and the original patch file does not contain any=20 > "In-Reply-To" header. Yet I can see it being added referring to the=20 > cover letter of a different patch in the git log, with no explanation=20 > at all. Any pointers so I don't keep sending brokenly-threaded sets by=20 > accident? Sorry! > > Best regards, > Marvin > > On 21/08/2021 21:55, Marvin H=C3=A4user wrote: >> Update the control flow to take the same actions for failed >> fixed-address loading as if the feature was disabled. This >> primarily removes code duplication. >> >> Cc: Jian J Wang >> Cc: Hao A Wu >> Cc: Dandan Bi >> Cc: Liming Gao >> Cc: Debkumar De >> Cc: Harry Han >> Cc: Catharine West >> Cc: Vitaly Cheptsov >> Signed-off-by: Marvin H=C3=A4user >> --- >> =C2=A0 MdeModulePkg/Core/Pei/Image/Image.c | 14 +++++++------- >> =C2=A0 1 file changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/MdeModulePkg/Core/Pei/Image/Image.c=20 >> b/MdeModulePkg/Core/Pei/Image/Image.c >> index 5af3895191a5..94adbed82e44 100644 >> --- a/MdeModulePkg/Core/Pei/Image/Image.c >> +++ b/MdeModulePkg/Core/Pei/Image/Image.c >> @@ -364,18 +364,18 @@ LoadAndRelocatePeCoffImage ( >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 AlignImageSize +=3D ImageCo= ntext.SectionAlignment; >> >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } >> >> >> +=C2=A0=C2=A0=C2=A0 Status =3D EFI_UNSUPPORTED; >> >> + >> >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (PcdGet64(PcdLoadModuleAtFixAddressE= nable) !=3D 0 &&=20 >> (Private->HobList.HandoffInformationTable->BootMode !=3D=20 >> BOOT_ON_S3_RESUME)) { >> >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Status =3D=20 >> GetPeCoffImageFixLoadingAssignedAddress(&ImageContext, Private); >> >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (EFI_ERROR (Status)){ >> >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 DEBUG ((EFI_D_I= NFO|EFI_D_LOAD, "LOADING MODULE FIXED ERROR:=20 >> Failed to load module at fixed address. \n")); >> >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 // >> >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 // The PEIM is not assigne= d valid address, try to allocate=20 >> page to load it. >> >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 // >> >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Status =3D PeiServicesAllo= catePages (EfiBootServicesCode, >> >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 EFI_SIZE_TO_PAGES=20 >> ((UINT32) AlignImageSize), >> >> - &ImageContext.ImageAddress); >> >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } >> >> -=C2=A0=C2=A0=C2=A0 } else { >> >> +=C2=A0=C2=A0=C2=A0 } >> >> +=C2=A0=C2=A0=C2=A0 if (EFI_ERROR (Status)){ >> >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 // >> >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 // The PEIM is not assigned valid addr= ess, try to allocate=20 >> page to load it. >> >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 // >> >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Status =3D PeiServicesAlloc= atePages (EfiBootServicesCode, >> >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 EFI_SIZE_TO_PAGES=20 >> ((UINT32) AlignImageSize), >> >> &ImageContext.ImageAddress); >> >