From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Pete Batard <pete@akeo.ie>,
devel@edk2.groups.io, jmcneill@invisible.ca,
Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH] Platform/RPi4: Fix SDHC interrupt numbers.
Date: Tue, 31 Dec 2019 17:15:01 +0100 [thread overview]
Message-ID: <eb659322-731a-8c86-ec37-9241a0a75f03@redhat.com> (raw)
In-Reply-To: <a96aa03f-aa41-8a74-4a19-5e5baa76ea95@akeo.ie>
On 12/31/19 3:47 PM, Pete Batard wrote:
> Hi Philippe,
>
> For the record these fixes were validated by Jared by booting NetBSD as
> per [1]:
>
> [ 1.000007] sdhc0 at acpi0 (SDC1, BCM2847-0): mem
> 0xfe300000-0xfe3000ff irq 158
Nice :)
>
> We'll have a few more of these coming up in [2], which we need to sort
> out before we send a patch, but at least for the SDHC, we're pretty
> confident the proposed changes are indeed correct.
>
> It's more for the FIXMEs in [2] that we may require help from someone
> with access to the datasheet. Of course, double checking what we already
> have won't hurt either.
Good idea to add "Validated on physical hw" comments there!
Acked-by: Philippe Mathieu-Daude <philmd@redhat.com>
>
> Regards,
>
> /Pete
>
> [1] https://dmesgd.nycbug.org/index.cgi?do=view&id=5273
> [2]
> https://github.com/pftf/edk2-platforms/commit/e6df781e25fc3dc51e83393c127410a1e4fc4345
>
>
> On 2019-12-31 14:30, Philippe Mathieu-Daudé wrote:
>> Cc'ing Samer because he has access to the datasheet, and I wonder if
>> Linux is right.
>>
>> Samer, do you mind to confirm this fix?
>>
>> Thanks,
>>
>> Phil.
>>
>> On 12/31/19 11:39 AM, Pete Batard wrote:
>>> Many thanks for fixing these.
>>>
>>> Reviewed-by: Pete Batard <pete@akeo.ie>
>>>
>>> On 2019-12-30 15:07, Jared McNeill wrote:
>>>> According to the bcm2711 devicetree, the Arasan SDHCI uses GIC SPI 126
>>>> and the Broadcom SDHost uses GIC SPI 120.
>>>>
>>>> Signed-off-by: Jared McNeill <jmcneill@invisible.ca>
>>>> ---
>>>> Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl | 4 ++--
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl
>>>> b/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl
>>>> index 57ee411a61..56d15c3927 100644
>>>> --- a/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl
>>>> +++ b/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl
>>>> @@ -33,7 +33,7 @@ Device (SDC1)
>>>> Name (RBUF, ResourceTemplate ()
>>>> {
>>>> MEMORY32FIXED (ReadWrite, 0xFE300000, 0x100,)
>>>> - Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) {
>>>> 0x5E }
>>>> + Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) {
>>>> 0x9E }
>>>> })
>>>> Return (RBUF)
>>>> }
>>>> @@ -76,7 +76,7 @@ Device (SDC2)
>>>> Name (RBUF, ResourceTemplate ()
>>>> {
>>>> MEMORY32FIXED (ReadWrite, 0xFE202000, 0x100,)
>>>> - Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) {
>>>> 0x58 }
>>>> + Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) {
>>>> 0x98 }
>>>> })
>>>> Return (RBUF)
>>>> }
>>>>
>>>
>>>
>>>
>>>
>>
>
next prev parent reply other threads:[~2019-12-31 16:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-30 14:07 [edk2-platforms][PATCH] Platform/RPi4: Fix SDHC interrupt numbers Jared McNeill
2019-12-31 10:39 ` [edk2-devel] " Pete Batard
2019-12-31 13:30 ` Philippe Mathieu-Daudé
2019-12-31 14:47 ` Pete Batard
2019-12-31 16:15 ` Philippe Mathieu-Daudé [this message]
2020-02-14 8:58 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb659322-731a-8c86-ec37-9241a0a75f03@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox