From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web09.4992.1577808910699562152 for ; Tue, 31 Dec 2019 08:15:11 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=h43wTD1Q; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1577808909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sbt2p/jc2yraHhKD0wEratPoRl9bufCsZyejLF3mrDs=; b=h43wTD1Q7t7Bgy5aGaJBECFqCOHil/HS/GmMMGPf2H9w82dKNGjsfrOP47UlhY8OiJbPFC cPSYiv9kG98XOw6Zst8coFrgCtwj+sTxPrjBJcqrD9GBJVhveC/5ie9fz6XBMxuabIy7GX PDx2RovGARJ795cyKinJNXAKBkj+Zvg= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-103-OgzFjSxfP-up5RpbU6tBCQ-1; Tue, 31 Dec 2019 11:15:04 -0500 Received: by mail-wr1-f71.google.com with SMTP id c6so9917350wrm.18 for ; Tue, 31 Dec 2019 08:15:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ItE2NkOx09mbLX98FIYPhvns6gcnQ1au+FXlBL0uUOg=; b=jLOhxKRF3qLCaFAlnq6HstgAThoDOXrrwG4ntxPOIzK5AXCoSdYXlke2LMLwUrpUUZ lrvGtLpHzE/I10GSh3BStLIBZHEf9w2SbL6HM6vLz6SHv0EXPr3x3A4Kz4UxWjqmoCtZ ofbrw2tpVTgozn61FWFWHiQxlEGW4qum+AJrp4Pawyi6jLIbUCRa62U1Qh12O2mm02eY KPNc9ZU501bGv3kuwtw7TaE46f24s8cOO6E8vevdhgiuTJVlbxpPNsaOQ2MBY56lco6l ZqImE6nAd6P1nVD21xLy1RfYx9XgRoR8CN6NXeDjvmMHQSYo45FkjqRpRAxWvyT1b+eG fKgA== X-Gm-Message-State: APjAAAXHswb/E2neoy6xM/toG4akokDWlANSo+8m5twdD5RUtqwbu+pu c92D6qbOwj5FXJFlnbUJq4ccOU5ejpZAGqTZFt76Ho3sDlW61c2dUnibuZFsOPnTAZ+NaNjxOIv Ol2zmgTfnK2PuaQ== X-Received: by 2002:adf:df90:: with SMTP id z16mr77569756wrl.273.1577808902528; Tue, 31 Dec 2019 08:15:02 -0800 (PST) X-Google-Smtp-Source: APXvYqwcw6wsRjVABriVqNoLtb2WCWVnKrH9+RJK9S8zhYEtzQVTdAE1VS2a8pn62H6f0r00ZJNCoQ== X-Received: by 2002:adf:df90:: with SMTP id z16mr77569732wrl.273.1577808902293; Tue, 31 Dec 2019 08:15:02 -0800 (PST) Return-Path: Received: from ?IPv6:2a01:cb18:8372:6b00:691b:aac5:8837:d4da? ([2a01:cb18:8372:6b00:691b:aac5:8837:d4da]) by smtp.gmail.com with ESMTPSA id e12sm49386528wrn.56.2019.12.31.08.15.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Dec 2019 08:15:01 -0800 (PST) Subject: Re: [edk2-devel] [edk2-platforms][PATCH] Platform/RPi4: Fix SDHC interrupt numbers. To: Pete Batard , devel@edk2.groups.io, jmcneill@invisible.ca, Samer El-Haj-Mahmoud , Ard Biesheuvel References: <39052ebe-f126-6c84-5d95-8c91297216bd@akeo.ie> <53e1b682-4d9a-2ba2-6f17-89f44afc32a6@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Tue, 31 Dec 2019 17:15:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: X-MC-Unique: OgzFjSxfP-up5RpbU6tBCQ-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 12/31/19 3:47 PM, Pete Batard wrote: > Hi Philippe, >=20 > For the record these fixes were validated by Jared by booting NetBSD as= =20 > per [1]: >=20 > [=C2=A0=C2=A0=C2=A0=C2=A0 1.000007] sdhc0 at acpi0 (SDC1, BCM2847-0): me= m=20 > 0xfe300000-0xfe3000ff irq 158 Nice :) >=20 > We'll have a few more of these coming up in [2], which we need to sort= =20 > out before we send a patch, but at least for the SDHC, we're pretty=20 > confident the proposed changes are indeed correct. >=20 > It's more for the FIXMEs in [2] that we may require help from someone=20 > with access to the datasheet. Of course, double checking what we already= = =20 > have won't hurt either. Good idea to add "Validated on physical hw" comments there! Acked-by: Philippe Mathieu-Daude >=20 > Regards, >=20 > /Pete >=20 > [1] https://dmesgd.nycbug.org/index.cgi?do=3Dview&id=3D5273 > [2]=20 > https://github.com/pftf/edk2-platforms/commit/e6df781e25fc3dc51e83393c12= 7410a1e4fc4345=20 >=20 >=20 > On 2019-12-31 14:30, Philippe Mathieu-Daud=C3=A9 wrote: >> Cc'ing Samer because he has access to the datasheet, and I wonder if=20 >> Linux is right. >> >> Samer, do you mind to confirm this fix? >> >> Thanks, >> >> Phil. >> >> On 12/31/19 11:39 AM, Pete Batard wrote: >>> Many thanks for fixing these. >>> >>> Reviewed-by: Pete Batard >>> >>> On 2019-12-30 15:07, Jared McNeill wrote: >>>> According to the bcm2711 devicetree, the Arasan SDHCI uses GIC SPI 12= 6 >>>> and the Broadcom SDHost uses GIC SPI 120. >>>> >>>> Signed-off-by: Jared McNeill >>>> --- >>>> =C2=A0 Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl | 4 ++-- >>>> =C2=A0 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl=20 >>>> b/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl >>>> index 57ee411a61..56d15c3927 100644 >>>> --- a/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl >>>> +++ b/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl >>>> @@ -33,7 +33,7 @@ Device (SDC1) >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Name (RBUF, ResourceTemplate () >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 { >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 MEMORY32FIXED (ReadWrite, = 0xFE300000, 0x100,) >>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Interrupt (ResourceConsumer, Level, A= ctiveHigh, Exclusive) {=20 >>>> 0x5E } >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Interrupt (ResourceConsumer, Level, A= ctiveHigh, Exclusive) {=20 >>>> 0x9E } >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 }) >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Return (RBUF) >>>> =C2=A0=C2=A0=C2=A0 } >>>> @@ -76,7 +76,7 @@ Device (SDC2) >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Name (RBUF, ResourceTemplate () >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 { >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 MEMORY32FIXED (ReadWrite, = 0xFE202000, 0x100,) >>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Interrupt (ResourceConsumer, Level, A= ctiveHigh, Exclusive) {=20 >>>> 0x58 } >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Interrupt (ResourceConsumer, Level, A= ctiveHigh, Exclusive) {=20 >>>> 0x98 } >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 }) >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Return (RBUF) >>>> =C2=A0=C2=A0=C2=A0 } >>>> >>> >>> >>>=20 >>> >> >=20