From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web11.772.1614884839790151724 for ; Thu, 04 Mar 2021 11:07:20 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=AosMvULv; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614884838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cUlCkw9mfwE534rx91ZKpt/Pf0e39OzQ4ejmzmkP2iE=; b=AosMvULvEuzgMdUVloSbcWTq1dpqvjkinKtRP0N1qbfoI+d8mO2RBCDK+LITyOvJCzIDxi bE6TIfWsfcCCoSdj38JgZwJlMMkOClr0rYQOqFgNk22t/NEVVrjdj1XNap0V8XoVAfp1Zy /CK+tkSrI+MuzrMkbeD3LL9QZ2+m7zI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-287-ODdZZVGvN8ywFGEOYO7upg-1; Thu, 04 Mar 2021 14:07:14 -0500 X-MC-Unique: ODdZZVGvN8ywFGEOYO7upg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 58622801814; Thu, 4 Mar 2021 19:07:13 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-76.ams2.redhat.com [10.36.112.76]) by smtp.corp.redhat.com (Postfix) with ESMTP id 05A9F5C1B4; Thu, 4 Mar 2021 19:07:11 +0000 (UTC) Subject: Re: [EXTERNAL] Re: [edk2-devel] generating the test matrix for local CI runs To: Bret Barkelew , "devel@edk2.groups.io" , "rebecca@nuviainc.com" Cc: Sean Brogan , "Kinney, Michael D" References: <95b5738d-6af2-15ea-e69d-759b1599b00d@redhat.com> From: "Laszlo Ersek" Message-ID: Date: Thu, 4 Mar 2021 20:07:10 +0100 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit On 03/04/21 19:32, Bret Barkelew wrote: > Can you share the specific PR youre failing so that we can talk in > concrete terms? Sure. In January, I posted the following patch series: [edk2-devel] [PATCH 0/8] ShellPkg, ArmVirtPkg, OvmfPkg: shell usability improvements https://edk2.groups.io/g/devel/message/69590 https://www.redhat.com/archives/edk2-devel-archive/2021-January/msg00070.html Message-Id: 20210104154235.31785-1-lersek@redhat.com This series cleared my local CI just fine (both Windows and Linux VM), before I posted it. When review was done, I attempted to merge the series: https://github.com/tianocore/edk2/pull/1336 Although the PR does not show it now (or at least I cannot make it show it), the github CI uncovered a real problem in my patch set, one that my local run missed. Namely, I had added an OrderedCollectionLib class dependency to the (singleton) UefiShellCommandLib instance, but failed to resolve the OrderedCollectionLib class in the EmulatorPkg and UefiPayloadPkg DSC files. Consequently, those DSC files would no longer build. My local CI runs didn't extend to these packages, but -- thankfully -- the github.com-based CI did. In v2, I added one extra patch for each of EmulatorPkg and UefiPayloadPkg DSC: [edk2-devel] [PATCH v2 00/10] multiple packages: shell usability improvements https://edk2.groups.io/g/devel/message/70216 https://www.redhat.com/archives/edk2-devel-archive/2021-January/msg00700.html Message-Id: 20210113085453.10168-1-lersek@redhat.com (What's more, I tracked down the DSC files in edk2-platforms that used to build the shell, and I resolved the OrderedCollectionLib class in them as well -- see the links inside the above-referenced blurbs.) The v2 CI succeded on github (personal, then merge): https://github.com/tianocore/edk2/pull/1337 https://github.com/tianocore/edk2/pull/1370 In summary, the bug (in my local CI usage) was that I didn't cover EmulatorPkg and UefiPayloadPkg. So, I'd like if the local test builds determined the affected set of packages as well -- I'd like to be *unable* to miss EmulatorPkg and UefiPayloadPkg in the above type of situation. Thanks! Laszlo