From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.61]) by mx.groups.io with SMTP id smtpd.web11.21296.1673436016376200750 for ; Wed, 11 Jan 2023 03:20:17 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=FhrKN1Se; spf=pass (domain: arm.com, ip: 40.107.22.61, mailfrom: vivek.gautam@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6sWoI2M0ssfGP90gaEIr8tL48dybOGtvxiVsLiy9H8w=; b=FhrKN1Seoc13+UP+5dDBQmfXGf6r+8inxjdo5VW6hU+Opcp4vTXXZmqHZIHl8cOfMfF303JLA2GBf3Rn6ffOpoPt0WvS4wmCXWbf5NBg5XUtVyrG7HHe3BxOmj/RKg9TIWYT5Zro5X+5OzvWBNgjC+hS2JcVAUtUh13sWYMuRhc= Received: from DB6P193CA0009.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::19) by DB9PR08MB7535.eurprd08.prod.outlook.com (2603:10a6:10:303::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 11:20:13 +0000 Received: from DBAEUR03FT007.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:29:cafe::95) by DB6P193CA0009.outlook.office365.com (2603:10a6:6:29::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Wed, 11 Jan 2023 11:20:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT007.mail.protection.outlook.com (100.127.142.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13 via Frontend Transport; Wed, 11 Jan 2023 11:20:12 +0000 Received: ("Tessian outbound baf1b7a96f25:v132"); Wed, 11 Jan 2023 11:20:12 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: a7d4d2704aa33b04 X-CR-MTA-TID: 64aa7808 Received: from e6cc5ee92720.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2A0F9C44-6CC4-4446-99CD-91E821ADAB37.1; Wed, 11 Jan 2023 11:20:01 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e6cc5ee92720.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 Jan 2023 11:20:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FXsBLNm5NB3b/oun1TqS8pmnX5nDI1caQjdNkQllPsu4jzEW17jXphIynSh++gmupc8R/JzU6MpCG9huxWLjVTaHusIJ11+SZrSd52QWRT3oA/GjATpSNas5/VctGV/hbLC5tk3rPSOrzrNnnYYGxBII7K1cpyUf8V033BGhP656KzUQqlOipnDuXfRrs+0ubBJZaxaOIHGtVWEkZ5eXee6DKzk9//fra9Zf3HS+LQVu6lEp9XgQ0lZL+xkqb95VMR2Ehi/iVrzVuWUDPU1hylN++ZWUNRctscycUzoAAF1b3swZ79+IHA/w8HnEz501GKiAYP9O+vusNora0Dt3wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6sWoI2M0ssfGP90gaEIr8tL48dybOGtvxiVsLiy9H8w=; b=eZK+xEdxddvJQY4Q/0nxmBF6rmIHxc1W2uhOIySIGokYMGAaLqmjinvKIGlpaKoXPM/pzFsApSbiwl1d58YVm84eaFZzl8GL6dptctjfmARt0GkRglqFZ7z/ByGAldHwHaSmcYdZoZAcEpYNitwByTXvOL8gUitaoljvxSCMmeAPa7CkXsEaOfHxG9eRLx3FoPXGGH6Iqbc5nuQRqYwxPakFWUovANXFXtXCRq1tC3wPIfudKMkJpi2mMqgY2OxI9L64SmMQnXLRqdqwPG0BnZCHaAdI/r+47Zar1eqYNv84lGJl2QLk4YNMY3OsuSEM73JwkWbuOub6P0NYuY3kqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6sWoI2M0ssfGP90gaEIr8tL48dybOGtvxiVsLiy9H8w=; b=FhrKN1Seoc13+UP+5dDBQmfXGf6r+8inxjdo5VW6hU+Opcp4vTXXZmqHZIHl8cOfMfF303JLA2GBf3Rn6ffOpoPt0WvS4wmCXWbf5NBg5XUtVyrG7HHe3BxOmj/RKg9TIWYT5Zro5X+5OzvWBNgjC+hS2JcVAUtUh13sWYMuRhc= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from PAXPR08MB7247.eurprd08.prod.outlook.com (2603:10a6:102:212::7) by PAVPR08MB10329.eurprd08.prod.outlook.com (2603:10a6:102:32c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 11:19:59 +0000 Received: from PAXPR08MB7247.eurprd08.prod.outlook.com ([fe80::a7fe:3b9:691d:641f]) by PAXPR08MB7247.eurprd08.prod.outlook.com ([fe80::a7fe:3b9:691d:641f%7]) with mapi id 15.20.6002.013; Wed, 11 Jan 2023 11:19:59 +0000 Message-ID: Date: Wed, 11 Jan 2023 16:49:42 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [edk2-platforms][PATCH V1 1/1] Revert "Platform/Sgi: Fix missing FdtLib instance issue" To: Sami Mujawar , "devel@edk2.groups.io" CC: "ardb+tianocore@kernel.org" , Pierre Gondois , nd References: <20230111101342.3936253-1-vivek.gautam@arm.com> From: "Vivek Kumar Gautam" In-Reply-To: X-ClientProxiedBy: PN3PR01CA0161.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:c8::17) To PAXPR08MB7247.eurprd08.prod.outlook.com (2603:10a6:102:212::7) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: PAXPR08MB7247:EE_|PAVPR08MB10329:EE_|DBAEUR03FT007:EE_|DB9PR08MB7535:EE_ X-MS-Office365-Filtering-Correlation-Id: 817b74f0-88e1-43d4-77dd-08daf3c5cec3 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: /dKC/cJ3WrRtpN6RV8HLXndj7u2PqXcSFbyH1tRsEyM2Y9sbRIoExpvoToKXTAspYCM6ZFenrnLZez4Mb2gZGgc/umlQZV23ecTjAYR8nGngL2W5hr1byWUdmkW1JyJBHe4FdchVFhSDq9giwyAhdpO7tHr/Tkmcdg6yYtjmwCCRIEwJoH2+BlUU5yoK5SvQz1RBbQaf96SoZ7ikP2kfrfphq9WizRg4h5kgcaDIFTNe6tTEgm3z4jhopPyUWnTZRSXwozoLoYEFaU8GLvfT5M1jApETn6uyGIONolzFTMkP378ORHeyyW0hcESaYAue264wSH25Vn8bTmk8dQEKVbrDp5CPcz904VfA62ID0MbHeojIrKALHDAcpMGHyNYOqMMWUPn4OjFvZBqY8HupJfoDsTLd+yFxzEL6KMJa3/KUs54vllFCDuy7EIoVvvF7wn9ISNcpU5WrhcJVfn42ys7o83F+e7TnwPuUNPiH3bDeFM948rI8kyylGVY43OfjVyWoL6ic/x7zdpdT2jIjPKd8kDvBCiZj6rUMGuBpsU/g0BbLmSSKdTu+FKlQT1fIEvSV9ee2q4sXJnVQmoeqA5wowmL+PXUllW1FKmVB3b/GaKy7jnJiSA7dfLkUm3XRDd7SkjJiOLQiKz+kjFktIDbeM0uBwk05GKQpWeSc8yv7RS7m94ar2fnOPHBwWb7cV5SfXnm482Z5phPPF3SQ1D6evzNuC+ADnTA+TTVfrPc= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7247.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(346002)(136003)(39860400002)(396003)(451199015)(31686004)(36756003)(31696002)(86362001)(41300700001)(66946007)(8676002)(54906003)(66556008)(110136005)(66476007)(4326008)(38100700002)(6666004)(6486002)(53546011)(186003)(478600001)(26005)(316002)(6506007)(2906002)(5660300002)(8936002)(83380400001)(2616005)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB10329 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Vivek.Gautam@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 57a6d9b8-a859-498a-ef35-08daf3c5c641 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CFgIcQMdGKgWqDxiTSVwGKjTQwkZGWANJTXWAmuaNjhXyRB3fFZveb32O+hTt/fQq1S6WIfOFyP881ofDKwBvoYCXaKKKuM8F0afizeb02WViKbfPTXY9Z0HKt/rUQPtyEf3Yl1LWeJBm6fuyO2JNsHSFI/XEN0jk6rXFd2CE752cn5Y4mObo5GPkKN6xmpYbv6VmEf4zrwRJFfZmYafzR2f9db7cTN3Z5kA57uB9vcj86UMu69V3rsoyF509xgNliF05LAPn0XO+kPrCFWDjAD1EaXBxSzKDmOkkmbW7Q7bQCsyXbAleJNGz+jn3x1g+Uu+fVb3AVqohTd6l5Wheq/1O7xHYy4SLJ7fZLxtA/wPOedIPqL/W+J3B5UlpQGIEsqUVT5Ir6OVc46o/8YDQaOs5gnRqeieUip+nYHYt2KNU+XUHWRh7wscKfZ6okYFrkA9Mkd+18OBvVh4AGpRrjnsjo0BWseJAEIZe3fDfQFel4toinzllTlUZNFMPqA0I2ixpZT6OJABTZwOnpBD7uyGggqRgJAvrowr1btxzCeU0C8Fx52iQkBRc4R2z7JkY+tGz0JN9oexiNhYUndSfleMnAsM6MUcBVyW83oyXNsIiOjBL3do84IXaFhcKB0ciUQw0mcwxoMcP+tfg6lnc/KTy8LGjSv5ECLYTlNuONilp0N4kPcC4F3/GhJSIMwAxrLad6f96Cu3HlEfSFdv2GNJifqm3bpvfvZwJ/69E+8= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(396003)(39860400002)(136003)(451199015)(46966006)(40470700004)(36840700001)(110136005)(54906003)(356005)(82310400005)(41300700001)(6486002)(316002)(2906002)(82740400003)(6666004)(6506007)(36860700001)(53546011)(6512007)(83380400001)(4326008)(336012)(8676002)(40480700001)(26005)(186003)(86362001)(478600001)(31696002)(40460700003)(5660300002)(36756003)(2616005)(31686004)(81166007)(70586007)(70206006)(47076005)(8936002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 11:20:12.9370 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 817b74f0-88e1-43d4-77dd-08daf3c5cec3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7535 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Sami, On 1/11/23 16:03, Sami Mujawar wrote: > Hi Vivek, >=20 > Thank you for this fix. >=20 > Reviewed-by: Sami Mujawar Thanks for the review and apologies again for the mixup. Best regards Vivek >=20 > Regards, >=20 > Sami Mujawar >=20 > =EF=BB=BFOn 11/01/2023, 10:13, "Vivek Gautam" wrot= e: >=20 > This reverts commit eb3950b842d3f335671600fdfa9b58c482886c79. >=20 > This commit referenced the change (9ad168c9e0 StandaloneMmPkg: > Include libfdt in the StMM) in edk2 as the dependency to add FdtLib > instance. However, as this change is not yet upstreamed, it was > incorrect to introduce this dependency and refer to the change in > the commit message. So reverting this patch. >=20 > Signed-off-by: Vivek Gautam > --- > Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc | 1 - > 1 file changed, 1 deletion(-) >=20 > Apologies, this was a mistake on my part. I used a bunch of commits > on edk2 that were not upstreamed and based the patch on them. This > led me to believe that there is a build break and so posted the > commit eb3950b842d3f335671600fdfa9b58c482886c79 for review. >=20 > diff --git a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc b/Platform/AR= M/SgiPkg/SgiPlatformMm.dsc.inc > index 01f0a7657c51..ae0ff7247a6a 100644 > --- a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc > +++ b/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc > @@ -38,7 +38,6 @@ > ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf >=20 > StandaloneMmMmuLib|ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStanda= loneMmLib.inf >=20 > ArmSvcLib|ArmPkg/Library/ArmSvcLib/ArmSvcLib.inf >=20 > - FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf >=20 > CacheMaintenanceLib|ArmPkg/Library/ArmCacheMaintenanceLib/ArmCach= eMaintenanceLib.inf >=20 > PeCoffExtraActionLib|StandaloneMmPkg/Library/StandaloneMmPeCoffEx= traActionLib/StandaloneMmPeCoffExtraActionLib.inf >=20 >=20 >=20 > -- > 2.25.1 >=20 >=20