From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (NAM04-DM6-obe.outbound.protection.outlook.com [40.107.102.102]) by mx.groups.io with SMTP id smtpd.web10.15427.1683859895909684883 for ; Thu, 11 May 2023 19:51:36 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="no key for verify" header.i=@amperemail.onmicrosoft.com header.s=selector1-amperemail-onmicrosoft-com header.b=lCn2kvvt; spf=pass (domain: os.amperecomputing.com, ip: 40.107.102.102, mailfrom: nhi@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XDa3+07/cf1hb2umv6854QrJZG9r1BnlFN3cdE5l5V9wSig4JsYBgMEljDtIlcpP9cNvB0UubCFbMPuKBNyvpHY9KeHRBogL2paZTPJjPH93F7DEXpwu4BVi5zKOCES9LWzr4gadL/7aNbTr1z4xCfHUPe7QsU1w88d95HF+0gxispxcqLauVg/r3odLJCzQ/jU1RgpOY7C/C2LyoMvG73V8KajFj/dSf+AbM8p0Sah/iUhml3lMAe2030f93a+njx3jOG1DwUGP51ydUBH7zRTP+wqHjVkU1yrMsm6P/1oZgULkSnrcom/IgA5lIyfD0Wlj74Vm9mG3BKIqz6dR4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A6cquh8SwP3mmexZBRwZSBLLaxyDMXhRvZn8Y+HYij8=; b=BfRepqC2VsI1wmQMFmgC0mOm/WhGui+MrR3TQwUKeB41yei+DTPdg0S760nZk6go9A1vKIVzkJf33Si6sFlP1lEOKxor9F1l2SASOugBbL3hLX8uxrqZBg+ejO8cAnu+HV2rn9lzTfN00m37B7NGZBuMBY01M3eFXkynHJpERjPMh231Ah4VU5p3ltS2qGmuQnEJcxO1iYcmZiLafh4Li69MPJROLOCBsNnMKICy5+faODXw2rpDnVWP7E3WMeh2htyXMJjIDqBlcrqWmHDvZloWKXWy00cSfAQQyFZzuYHsAyZ6pcQwdzklnSIdmBcO9NxlqRyALwVZ7Ul/hQYOCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=amperemail.onmicrosoft.com; dkim=pass header.d=amperemail.onmicrosoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amperemail.onmicrosoft.com; s=selector1-amperemail-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A6cquh8SwP3mmexZBRwZSBLLaxyDMXhRvZn8Y+HYij8=; b=lCn2kvvtj3k0Tre28h/yUHvLhoMXsETM1iP7bw9uimzUYpwWjHsbP4HstJBSt40biOPTxu1hxh3hVYCNjPStAeZ7bAJeerKD9TqeaPiq7ZCQeJOdHZQK4X+70320jjQentmmiC5LQKUEso/PKQS0zk1NYJ6LfFuvw77eNWcX5JU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amperemail.onmicrosoft.com; Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by BN6PR01MB2788.prod.exchangelabs.com (2603:10b6:404:d1::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.23; Fri, 12 May 2023 02:51:30 +0000 Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::8b9f:c392:42fb:e468]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::8b9f:c392:42fb:e468%5]) with mapi id 15.20.6363.033; Fri, 12 May 2023 02:51:29 +0000 Message-ID: Date: Fri, 12 May 2023 09:51:19 +0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [edk2-platforms][PATCH 0/3] Add necessary changes for PCIe core and remove unnecessary checks for PCIe Devmap mode To: Minh Nguyen , quic_llindhol@quicinc.com, ardb+tianocore@kernel.org Cc: devel@edk2.groups.io, patches@amperecomputing.com, nhi@os.amperecomputing.com, tinhnguyen@os.amperecomputing.com References: <20230511075143.2690207-1-minhnguyen1@os.amperecomputing.com> From: "Nhi Pham" In-Reply-To: <20230511075143.2690207-1-minhnguyen1@os.amperecomputing.com> X-ClientProxiedBy: SGBP274CA0022.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b0::34) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) Return-Path: nhi@os.amperecomputing.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB7287:EE_|BN6PR01MB2788:EE_ X-MS-Office365-Filtering-Correlation-Id: dcdc9123-6c2b-4d12-3734-08db5293c902 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OzeKy9oQT/p13MPVDJ8TrrJ3WNzv+fcOPeH9Agpoj6lkOz4GTgJbjK9aaZk22eWGrdWVXhE9y5gNx3qzvI2Qg3zHv65fNJgNsFEwV0GAM4HZ4dB/AS9j6YddYBwkDh1dpBcNZ3B4VbHYLUSGJysCNHs4lBHthLWrjh7XGefnm0s+Vuk8fSL8Lp5nI9oHsTm5PH52hgyGC9xBhHgcYPXd7Ks9ncfmAvijURu47sLaJZTMZ1LiyFZ52mP70SnyB76nHbzGcwkiIs1wIaoGsSfGvhAua7SzNIi+nzx/UuktcNiTqo6+EFMh7VP/+JRQ4FGDpRnpmBsaQGvxfOnSm5RWCd39cNUbgCS7XJSb3IkCXke9eG1UE2riOgQ2d78Cqcf6y7NVcHxzZWZgTDrGFtVs8EUCZuTbbsBqR3mfKF/QRdkHAf5qO+ZjGdchOYeCGzDhmWeznL2VoP44oxjrAS1uLbk9boGxCF9aj/ETZu5+pQzFWhGkpo2O++QTM3aBTZKGJIQu4Y+Lp1V9y/iwlz+tyqEabd09K8GrDmZ1jAB2tQqDQd61oYWviLU8oqlbfjFeBEQxlOuHKLGW1ssMCsjAq0wuCFaXG9PnGdVUz68xiOzZw2R8x5ougvdIMgPZZxSz X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR01MB7287.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(396003)(39850400004)(366004)(346002)(451199021)(53546011)(26005)(107886003)(186003)(6506007)(6512007)(478600001)(83170400001)(38100700002)(6486002)(6666004)(4744005)(2906002)(31696002)(8676002)(42882007)(8936002)(5660300002)(41300700001)(31686004)(66946007)(66476007)(66556008)(83380400001)(316002)(4326008)(2616005)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L1A1MmFiMHVGRXp3MmZvV0I0WmVsYUkrQzg2MUtTWWM3MXVGaFFjREhBUzJ3?= =?utf-8?B?eEtSZmROZ3pmbzJpRHZtUHpSOUZIUTZ2eUY0bnRmRGJvQ09BZ2ZqbkpMSUJk?= =?utf-8?B?cUg0VjBIMjlBV3RKV0JpYTdhU1ZhY2JqVG9COC9vV21PSXpsOTBITytCaWhP?= =?utf-8?B?YzU4aXpvb1NySjBsczdqaVhSU0NwZDVJTWl3TGNlRDZOUDF3SWxncVU3YXVF?= =?utf-8?B?VHpmeUg0bE9HSzQ4RUEzN2E4NHlyWjJrZStabVJpekE5azhPOG1oelpqZ3Nt?= =?utf-8?B?WXN0aVlJQmVYa1RlSG9YakplMW9KNDJIRk9HSVR1aVVqTWlHa21jaDJCaXph?= =?utf-8?B?RkplRnJ1SUdqaVA1eHBWT3psekpKM0paOTdjYnhkOUZqQUhTU21uUXdReVRD?= =?utf-8?B?MC9sQnlsdklvY2RSZWdQZFloalhXaVdmMDZyY29PbXE5VXQ4aUR5WkFhQnpo?= =?utf-8?B?QzJHNUlubGw0ckJxVnpVNElUK2tNWGhQYTdzM3VVVkMzekhtMlg5SWdmTXZ3?= =?utf-8?B?RUo5dG5TTGYwNDdsUzBVY3Y0SlF1b1RnVWhvU3kwR2FQUXJOaGErZ2ZsZi8y?= =?utf-8?B?Z3M4YmV2dWVqWG4yTmtmZ2FWa1hSb0NXUVFCUHJjWXVnWXRuRy9mOWZaWjNu?= =?utf-8?B?d0tHSjZaTHBaSFM1VWxrQjh1LzlITjFERC9ncmtEc3ZTcUQ1WWh3VCtVaU9E?= =?utf-8?B?aW9ha29VK0htRzlkYjhNS1ZZUTgvd2g2RkpsNE1mTElQWldncjFRanBmM0tx?= =?utf-8?B?cHAvNUkzNVB6SS9xTTQ1STBzWCtTa29YNTZKZHhYam1ibEhoWUdieEpNeU5v?= =?utf-8?B?S3habllyL1RBU1lTSVRPSy9jNm5WZk5HQ1RpN2p1b3U5TkFva3N2bXpMLzNG?= =?utf-8?B?Z1JaYjlNVkRUWTkyNXFQa01QRFRQeVlTWmFKcldBR2NVVXMwZmNlaVNVNkVu?= =?utf-8?B?MHB5U1pndVhZdkMySS85MXBFTzg1ZitMQjV4MVBqL3E5aDBzSEFMbmdZMnNJ?= =?utf-8?B?dVF6UEh0QW1iYU1VU3ZhNXowYXAyeXNlVlJ3UVV3dzJ1UVhCMlljVG83dzJs?= =?utf-8?B?WFd2Mm1zMkF1TExuVGtLTjdLRFI1Q2U4Z2U5eW11YkswZ0FhK05zQkoxTDBH?= =?utf-8?B?N1dFL1NjTGFRZmdFWjRQV20wc1dpY1pSUXY3aGU1SCtSRFkvbUlxSCtzUzFD?= =?utf-8?B?d1hLR0JhOURLOXZGM3FwK2tjNjVvQjgwNUY5YXB6aENDM2NGTk04cFZ3NE8w?= =?utf-8?B?QVZGVElLbXJNU0ZoSjRzYlJQNEZKY0lpQ2tXOXVvM0p3OWs0c0NCTEoyckZa?= =?utf-8?B?OXJRVlh6ZUh1UUpaYi9oTkFrM1dKSnVxcldoaVZ1Z09vYVBZb0g1b1RwZEdH?= =?utf-8?B?SHQzSXlDK1ppMW9xWllWU3BnQzBwS3ZZTCtvRGVzK3ZrMDFpcUIyemFPZmI3?= =?utf-8?B?VnJnVW5BaG8zVml5YTNCVys0UG4yMDRVY294NVVPQ2xFOUFJQmdvaWdmVVpt?= =?utf-8?B?aUdOY3hZRGdCYmJIOVh0aEUwL0FWVzhlOFJ6dUdVcjB3dVNNS1JGYVg0WTZn?= =?utf-8?B?Tm9yQXd4OFFTaUpUT3ZkUGFlaFdKcXUrZ2dqT1FyWUtTcHlyQ3IzQVlkc0lE?= =?utf-8?B?R0hVV1lUNXZtRmdhNmFSczdJeHBzQ0xsSVFSUkJIQ0p4V1lTR1lRNC9TV3ZS?= =?utf-8?B?VXlSbGdwbUh1LzZiNDFjZDBNWWREaFM2QVRrSFJOTXErQjVCUHpQbU45ZzFl?= =?utf-8?B?anM3R0Fya2xBbmRpMGt0T3EyajdVUnRrQzl4Mm8yWEMzV2ZHQWNGcCs5WDRx?= =?utf-8?B?N3l5Y09POExjMWlpVkNYeFZPd1JiYkpxYjhNS1BQMm9XcXBTSUF2SUNxRVpV?= =?utf-8?B?QjdzMGpnS3NOQVB0VDFBR2RZWDJBaXIrYU9IL3lZbTlBNXY5cFpyMjBDN0FC?= =?utf-8?B?WTNvbDcrUmhqZHRVbFE0T0NCczc2bWpXUWhpclJ5L1pkUWZ6bWc4dU04OTdp?= =?utf-8?B?RkNTZ0x5T1FEN21sOE5rZ081WUoyb2ZKTnVrbUhWams4VytUVVRQWTBKbkl5?= =?utf-8?B?bnVHUjF2R1N6K25KTjhaL2hXT1FYN1FsaVhCdVQrYW04Q3ZRSG1TczFGUGFG?= =?utf-8?B?alNjbFpRQ3BHVUJpZUxMcGxBNkEwckdVcEZXcEtNVmxZUjlrVXliREd3ZUJq?= =?utf-8?Q?aEnCkUFjxuY7/VEwbQh8Mvc=3D?= X-OriginatorOrg: amperemail.onmicrosoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: dcdc9123-6c2b-4d12-3734-08db5293c902 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2023 02:51:29.5432 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VniyCps+MJ+jteFJGjlmKG9NldW7Nq+DvtOZuNR6naxYr6yM9iSZ5tKN2Xb5nZlH3dL8Is/lh+H5TpTVNvgRY8hwSxvEUX0KzbWE3fEfibY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR01MB2788 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Minh, Thanks for this patchset. It looks good to me. Reviewed-by: Nhi Pham Hi Leif, Ard - Could you please help merge this series? Thanks, Nhi On 5/11/2023 2:51 PM, Minh Nguyen wrote: > These patches help to improve PCIe core for Link training sequence and > add logic to check PCIe card is present or not. One patch also removes > unnecessary checks for PCIe Devmap mode. > > Minh Nguyen (2): > AmpereAltraPkg: Remove PCIe "DevMapModeAuto" case in retrieving Devmap > mode > AmpereAltraPkg: Fix PCIe link training sequence > > Tinh Nguyen (1): > AmpereAltraPkg: Add retry logic when PCIe card is present > > Silicon/Ampere/AmpereAltraPkg/Drivers/PcieInitPei/RootComplexNVParam.c | 2 +- > Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c | 12 ++++++++---- > 2 files changed, 9 insertions(+), 5 deletions(-) >