From: "Liran Alon" <liran.alon@oracle.com>
To: Laszlo Ersek <lersek@redhat.com>, devel@edk2.groups.io
Cc: nikita.leshchenko@oracle.com, aaron.young@oracle.com,
jordan.l.justen@intel.com, ard.biesheuvel@linaro.org
Subject: Re: [PATCH v2] OvmfPkg/PvScsiDxe: Refactor setup of rings to separate function
Date: Wed, 1 Apr 2020 14:06:50 +0300 [thread overview]
Message-ID: <eb8e3a5f-c0f0-ca44-0741-addc592debd3@oracle.com> (raw)
In-Reply-To: <7378622f-092c-e7b2-6309-903a4dcc4f13@redhat.com>
On 01/04/2020 13:41, Laszlo Ersek wrote:
> On 04/01/20 00:56, Liran Alon wrote:
>
>
> + //
> + // Setup rings against device
> + //
> + Status = PvScsiSetupRings (Dev);
> + if (EFI_ERROR (Status)) {
> + goto FreeDMACommBuffer;
> I'm going to rename this label to "FreeDmaCommBuffer" upon pushing (due
> to de-capitalization of acronyms in edk2 CamelCase).
Thanks. Will note this for next time.
-Liran
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>
> Thank you!
> Laszlo
next prev parent reply other threads:[~2020-04-01 11:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 22:56 [PATCH v2] OvmfPkg/PvScsiDxe: Refactor setup of rings to separate function Liran Alon
2020-04-01 10:41 ` Laszlo Ersek
2020-04-01 11:06 ` Liran Alon [this message]
2020-04-01 14:48 ` [edk2-devel] " Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb8e3a5f-c0f0-ca44-0741-addc592debd3@oracle.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox