From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85]) by mx.groups.io with SMTP id smtpd.web12.3727.1585739228948722140 for ; Wed, 01 Apr 2020 04:07:09 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=f/3Pwdwz; spf=pass (domain: oracle.com, ip: 156.151.31.85, mailfrom: liran.alon@oracle.com) Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 031Aqhcs155869; Wed, 1 Apr 2020 11:07:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=fKTGbCFOnenPU2ps6Mxa1+MeG+LShlCY7FcIVvhmZ2o=; b=f/3PwdwzOVBzNVIxPVDqZmPfr5NP7WqEodXaCaG3hIqoZBS44MOCPOrie9ylCfH2+kpa WgTAS61wTO7QQuirMDyYJMZSt3AqTGQdPEzmjMI6nR4CjBMLodsraqDAx0uBShMkyrk0 50rRFN7eQn9QvwbtP/DVBAFPJZVtEn9SSty2EZAe8sy8sZRmuJOc5PsUvppyodffGsXH jjxAFd7XqmnE5MMaRIiUGddJ3/LMXz7A6bcPAtgmyIas9NvnMSj57QZGxDZ3RdFnOo1P JZOMgh66RP4orpzRgkgZ2Bb5Oa6o5AA0jMdqJCWEnhTttChU3Mb0FQEU8SdElvhQksPs xQ== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 303aqhn86w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 01 Apr 2020 11:07:08 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 031B76Jq188285; Wed, 1 Apr 2020 11:07:07 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3020.oracle.com with ESMTP id 304sjk12yw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 01 Apr 2020 11:07:07 +0000 Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 031B6tnF001770; Wed, 1 Apr 2020 11:06:55 GMT Received: from [192.168.14.112] (/79.180.216.197) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 01 Apr 2020 04:06:55 -0700 Subject: Re: [PATCH v2] OvmfPkg/PvScsiDxe: Refactor setup of rings to separate function To: Laszlo Ersek , devel@edk2.groups.io Cc: nikita.leshchenko@oracle.com, aaron.young@oracle.com, jordan.l.justen@intel.com, ard.biesheuvel@linaro.org References: <20200331225637.123318-1-liran.alon@oracle.com> <7378622f-092c-e7b2-6309-903a4dcc4f13@redhat.com> From: "Liran Alon" Message-ID: Date: Wed, 1 Apr 2020 14:06:50 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <7378622f-092c-e7b2-6309-903a4dcc4f13@redhat.com> X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9577 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 adultscore=0 mlxscore=0 malwarescore=0 phishscore=0 suspectscore=0 mlxlogscore=999 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004010100 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9577 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 clxscore=1015 malwarescore=0 impostorscore=0 mlxlogscore=999 spamscore=0 mlxscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004010100 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 01/04/2020 13:41, Laszlo Ersek wrote: > On 04/01/20 00:56, Liran Alon wrote: > > > + // > + // Setup rings against device > + // > + Status = PvScsiSetupRings (Dev); > + if (EFI_ERROR (Status)) { > + goto FreeDMACommBuffer; > I'm going to rename this label to "FreeDmaCommBuffer" upon pushing (due > to de-capitalization of acronyms in edk2 CamelCase). Thanks. Will note this for next time. -Liran > > Reviewed-by: Laszlo Ersek > > Thank you! > Laszlo