From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) by mx.groups.io with SMTP id smtpd.web08.9590.1608132078070400712 for ; Wed, 16 Dec 2020 07:21:18 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=NCGGo3WP; spf=pass (domain: nuviainc.com, ip: 209.85.210.49, mailfrom: rebecca@nuviainc.com) Received: by mail-ot1-f49.google.com with SMTP id j20so18770840otq.5 for ; Wed, 16 Dec 2020 07:21:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=JyaWVRuMUGnYFpyN+gUgHcst6xE591ytDF2ms56U5/I=; b=NCGGo3WPtnwjhGiKOyjJi5EEkpR5CVvFplW8pxLtIIzm7L8ZkHs+d8ZN9jjbPMNDv1 7RmXIBQsRwh1+iw7WdFkXzvKWi/zdYaKFZJmkRUKvKirEw8t/bOzPWp6aB4XPU+Z5LIG lx8hqJiK2FM4qBedPKa61nUUzl3oIFp6u//SWMKuDXwBenHSnRaLGOg7VpK6XUwVhG2W AKVdjBgxVEZDSOpP2wIs65G1RT4Yd36U4r2xJ8az1yzJT5ZIORZI5BsEcgfV3649nw1C hPWBzXeV+i8sNDf46EmosGtiQq7oQo+OxBkQoEWmv2Zk9qHMZZCQcFvjr3Us9EUKAoBS 3TWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JyaWVRuMUGnYFpyN+gUgHcst6xE591ytDF2ms56U5/I=; b=bZaeaWAoG++5qDXg0FIir43X+GN7RWx+xfSnfSFx/m6j1S1mBfG2j//meRaljBnaXo m1vt5ZkFzGXLrzW9b/8Nn8ADmKw3si46DqItxZXuYezWCnN+qoo/HIyYPO8xn8UKjlcR 3u7VRdw2v4soNAs4SuUiWauiVTlUoAr/n0cBFy3Uj7o+45tGD+zc+VQPT4miskKOZRj2 dzzbi528P6sa+px7/Olb3D51QpyWoF4xtDWwqKRjiSLBzFSoVXNgZFXSbMYItz590Amf FomVvtWxn7l6nfvwm2K0UsYEI+s/RTlUaKBqZkYx9JW1jaSr7BHAOB/FGWRA998LoaOU kBRw== X-Gm-Message-State: AOAM5339DGd4VFDZ1lO11dWelgGFhChcEXuizmZIQmygR7Re/L+AhkBF X1VMTBexNU6zBwgUNijc8+6k2g== X-Google-Smtp-Source: ABdhPJxs82yLPr7GGbZVZuORwj/hnHFWlUTIvmi0nrH8HZ375wd/fJqQ0qd1oqdxpcFc28V4TpJUzA== X-Received: by 2002:a9d:12d7:: with SMTP id g81mr9935352otg.103.1608132077415; Wed, 16 Dec 2020 07:21:17 -0800 (PST) Return-Path: Received: from [10.0.10.142] (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id j46sm515090oof.36.2020.12.16.07.21.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Dec 2020 07:21:16 -0800 (PST) Subject: Re: [edk2-devel] [PATCH v4 10/10] ArmPkg: Add Universal/Smbios, a generic SMBIOS library for ARM To: Sami Mujawar , "devel@edk2.groups.io" Cc: Michael D Kinney , Liming Gao , Zhiguang Liu , Leif Lindholm , Ard Biesheuvel , nd References: <20201207175427.28712-1-rebecca@nuviainc.com> <20201207175427.28712-11-rebecca@nuviainc.com> From: "Rebecca Cran" Message-ID: Date: Wed, 16 Dec 2020 08:21:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/16/20 8:13 AM, Sami Mujawar wrote: > Sorry for pushing for the function documentation. We are in process of enabling EKDII Core CI support for ArmPlatformPkg and ArmPkg. > The ECC tool (checks for coding style and general good programming practices) is run as part of the Core CI. There are numerous issues reported by ECC tool and we are working towards fixing them before the Core CI is enabled. > > Can you run the ECC tool for this patch and fix the reported issues, please? > The following command can be used to run ECC on the ArmPkg\Universal\Smbios folder. >> python BaseTools\Source\Python\Ecc\EccMain.py -c W:\edk2-review\edk2\BaseTools\Source\Python\Ecc\config.ini -e W:\edk2-review\edk2\BaseTools\Source\Python\Ecc\exception.xml -r W:\edk2-exports\edk2\Ecc.csv -t W:\edk2-review\edk2\ArmPkg\Universal\Smbios > > The ECC errors 10002, 10006 and 10022 can be ignored for now (I don't know if these errors are real problems or false positives). Given that I maintain the site with the Doxygen pages at https://bsdio.com/edk2/docs/master/ I'm all for adding function documentation! I'll run the ECC tool and fix the errors. -- Rebecca Cran