From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.85.128.45, mailfrom: philmd@redhat.com) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by groups.io with SMTP; Tue, 16 Jul 2019 07:59:46 -0700 Received: by mail-wm1-f45.google.com with SMTP id v15so19019056wml.0 for ; Tue, 16 Jul 2019 07:59:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=I+ekwqeKIMI0UrPqVFyBhQclP6RTsq1MfIfB6M/fls4=; b=TL115BeBDspFvSEjWwotsoZeiWUkoQNf9G9fn1UcbxwN1R9zDyGjuKQxR/Iy7w5bMl 1VzFK6gTfBpxqsAGLyCYGuYf84j/mIZ0RdBUYUpa7xqceLHW5cQIiwqbcFHCnd5QxrzL 1Ws6uSNoh6HspGomLpIK8y8afCX367dc8FmbaXt3qJzzr0WJwRK27USWBRKwzXxTJBfG FODQrNiDhLC3RJ1FRDusHMvyFJCT3w1jZdaiG9CZI0ui/sU7T3+xoxw8D8KJA1S0Zw3l sqINlCsC7lLwOtRHouPcRx9+Om5ijeiGA+04OaQaAr18/YSOtZk19NxUT1LiF52VmYDp FW9Q== X-Gm-Message-State: APjAAAXp2nmyele8WzpDUWVZn7L7RxtGiYPlSoRhiRWzZCiZbxbtbUZx a9lcFlo483j8kUus0CWy5jfy7g== X-Google-Smtp-Source: APXvYqxckx38mrbKi5lOp/M85iSRa1Agaa1O1YJAs/OzhOgM4oPPIKWgkxnhDPIzY3C5G/OlNKb5oQ== X-Received: by 2002:a7b:c7d8:: with SMTP id z24mr31438892wmk.10.1563289184769; Tue, 16 Jul 2019 07:59:44 -0700 (PDT) Return-Path: Received: from [192.168.1.38] (62.red-83-42-61.dynamicip.rima-tde.net. [83.42.61.62]) by smtp.gmail.com with ESMTPSA id c1sm39257336wrh.1.2019.07.16.07.59.43 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 16 Jul 2019 07:59:44 -0700 (PDT) Subject: Re: [PATCH 1/3] MdePkg/BaseLib: re-specify Base64Decode(), and add temporary stub impl To: Laszlo Ersek , edk2-devel-groups-io Cc: Liming Gao , =?UTF-8?Q?Marvin_H=c3=a4user?= , Michael D Kinney , Zhichao Gao References: <20190702102836.27589-1-lersek@redhat.com> <20190702102836.27589-2-lersek@redhat.com> <6dd4f56b-b7df-7986-11cf-1780981c1d0e@redhat.com> <4865d268-7867-a8c3-c1f0-2613d7667679@redhat.com> <4bea421a-43af-2c97-9885-d3266785222c@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: Date: Tue, 16 Jul 2019 16:59:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <4bea421a-43af-2c97-9885-d3266785222c@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 7/16/19 4:14 PM, Laszlo Ersek wrote: > On 07/16/19 11:41, Philippe Mathieu-Daudé wrote: >> Hi Laszlo, >> >> On 7/16/19 10:38 AM, Philippe Mathieu-Daudé wrote: >>> On 7/2/19 12:28 PM, Laszlo Ersek wrote: >>>> Rewrite Base64Decode() from scratch, due to reasons listed in the second >>>> reference below. >>>> >>>> As first step, redo the interface contract, and replace the current >>>> implementation with a stub that asserts FALSE, then fails. >>>> >>>> Cc: Liming Gao >>>> Cc: Marvin Häuser >>>> Cc: Michael D Kinney >>>> Cc: Philippe Mathieu-Daudé >>>> Cc: Zhichao Gao >>>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1891 >>>> Ref: http://mid.mail-archive.com/c495bd0b-ea4d-7206-8a4f-a7149760d19a@redhat.com >>>> Signed-off-by: Laszlo Ersek >>>> --- >>>> MdePkg/Include/Library/BaseLib.h | 99 +++++-- >>>> MdePkg/Library/BaseLib/String.c | 285 ++++++-------------- >>>> 2 files changed, 168 insertions(+), 216 deletions(-) >> >> You forgot to update the copyright in both files. > > I didn't: I never intended to. > > Updating or extending *existing* copyright notices is not a general edk2 > requirement. Some companies insist that their associates do that, when > they contribute patches. Red Hat doesn't (we don't extend copyright > notices like that in QEMU either). Oh OK, I did not know :S Thanks for telling me, Phil.