public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, michael.d.kinney@intel.com,
	Sean Brogan <sean.brogan@microsoft.com>,
	Bret Barkelew <Bret.Barkelew@microsoft.com>,
	"Gao, Liming" <liming.gao@intel.com>, Ray Ni <ray.ni@intel.com>
Subject: Re: [edk2-devel] EDK II Maintainers - EDK II CI is now active on edk2/master
Date: Wed, 13 Nov 2019 09:57:18 +0100	[thread overview]
Message-ID: <eb9ff988-5310-ac0b-656e-7ea9f97ab65f@redhat.com> (raw)
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F5B9E173A1@ORSMSX113.amr.corp.intel.com>

Hi again,

(+Ray)

On 11/12/19 03:55, Michael D Kinney wrote:
> EDK II Maintainers,
> 
> EDK II CI Phase 1 feature is now active on edk2/master.
> 
> Please use a GitHub pull request from a branch in a personal
> fork of the edk2 repository with a 'push' label to request
> a set of patches to be pushed to edk2/master.  The GitHub PR
> replaces the 'git push' operation currently used to commit
> changes to edk2/master.
> 
> You will need to configure your notifications from the edk2
> repository to make sure you receive email notifications
> when the checks against the GitHub PR passes or fails.
> 
> If you submit a GitHub Pull Request without the 'push'
> label, then the CI checks are run and the results are
> generated.
> 
> Please let us know if there are any questions about this
> change in the development process.

now that a few PRs have been merged "in production", using the above
procedure, I'd like to propose an addition.

I've received a number of PR notifications, and I generally have no idea
how to associate them with what happens on the list. My proposal is
supposed to improve on that.

Note that, I have always suggested / requested including links, pointing
into the mailing list archive, in Bugzilla tickets for which new
versions of patch sets have been posted. This (brief) proposal is a
natural continuation / extension of that idea.

- When opening a GitHub PR, as described in the above procedure, please
*always* include a reference in the PR's title to the associated
TianoCore bugzilla ticket, if there is one.

- Similarly, please add a link, pointing to the GitHub PR, to the
bugzilla ticket.

For example, if I look at the following email:

  [tianocore/edk2] Cpu/remove xd (#164)

it tells me basically *nothing*. And if I open

  https://github.com/tianocore/edk2/pull/164

in my web browser, it still tells me nothing.

The PR title should include a reference to TianoCore#2329, and
TianoCore#2329 should include a reference to
<https://github.com/tianocore/edk2/pull/164>.

Yes, this is more work than before. It is necessary because now we have
*more artifacts* related to pushing (merging) a patch series. Those
artifacts should not just hang in the air.

Ray: now that the series has been merged, can you please reference the
GitHub PR, and the resultant commit range, in TianoCore#2329? Also, can
you please close the bugzilla as fixed?

Thanks,
Laszlo


  parent reply	other threads:[~2019-11-13  8:57 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-12  2:55 EDK II Maintainers - EDK II CI is now active on edk2/master Michael D Kinney
2019-11-12  8:56 ` [edk2-devel] " Laszlo Ersek
2019-11-12 19:50   ` Michael D Kinney
2019-11-12 19:52     ` Michael D Kinney
2019-11-13  7:56     ` Laszlo Ersek
2019-11-13  8:57 ` Laszlo Ersek [this message]
2019-11-13 16:23   ` Michael D Kinney
2019-11-13 17:03     ` Laszlo Ersek
2019-11-26  8:23 ` Laszlo Ersek
2019-11-27 19:03   ` Michael D Kinney
2019-11-28 12:00     ` Laszlo Ersek
2019-12-02 19:55       ` Michael D Kinney
2019-12-03  8:56         ` Laszlo Ersek
2019-12-03 17:07           ` Michael D Kinney
2019-12-03 20:39             ` Laszlo Ersek
2019-12-06 11:02 ` Laszlo Ersek
2019-12-06 11:07   ` Laszlo Ersek
2020-01-02 14:42 ` Philippe Mathieu-Daudé
2020-01-02 18:36   ` Michael D Kinney
2020-01-06 14:58     ` Philippe Mathieu-Daudé
2020-01-03 13:29   ` Laszlo Ersek
2020-01-06 17:29 ` Laszlo Ersek
2020-01-06 18:17   ` Michael D Kinney
2020-01-07  9:00     ` Laszlo Ersek
2020-01-09 21:30     ` Laszlo Ersek
2020-01-09 21:37       ` Michael D Kinney
2020-01-10 10:51         ` Laszlo Ersek
2020-03-08 11:12 ` Laszlo Ersek
  -- strict thread matches above, loose matches on Subject: below --
2020-03-08 19:21 Sean
2020-03-08 19:53 ` Michael D Kinney
2020-03-09 19:29   ` Laszlo Ersek
2020-03-09 19:32     ` Laszlo Ersek
2020-03-09 22:00       ` Michael D Kinney
2020-03-09 19:37     ` Laszlo Ersek
2020-03-09 20:06   ` Laszlo Ersek
2020-03-09 21:44     ` Michael D Kinney
2020-03-10  7:53       ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb9ff988-5310-ac0b-656e-7ea9f97ab65f@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox